From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 925AE33CB for ; Mon, 6 Jun 2022 21:27:08 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id q7so21492601wrg.5 for ; Mon, 06 Jun 2022 14:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=UKJAaMHvsMk3isiZOfnAHzy5T2BlXzSGz/br0IRqcPitgBBVswDiMU6CXUv2eiX+nx RtmdEv+IiJCozRPwLIHyhiIyHX8UkEIEekJdyqSEVdGV+zcFG2qYr1e9p6q8bvQixB7p 15JkXEd+vp/VA3LRa3S4XcxWTbO8UKgPqHnx5ErXRzDDHDfnR2sWqATzGOV0K6e5Vl1x yG3GYe/AUb11OTOogIbyyneef7kjpiAg/E6/Ii1t5wUVPjW4lMUi+k1MDO/miT7zHmp2 Mh4ATTgL3Zvtj5mbpJrMAn/yZZF5Tud1O7hRPZUG6QEVu7P+pw3aPO3eicFyto8R2A8f pfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=jt8UF0eauzFOihTP/Sl//GUJdtSKYHDeMtybhwO3ANOPP7mrIoLJLr02/0S8x2BR6r RmLc8qebHCH+iRQgo5U1YI9+bEvRTQEbxfsFYZdh7NZYuIUWuga28bdcut7VcGp8yOiC Z2J3DcBM+Qrwx45EhkR6tgsrBt5ZGGYaUAJVhSN0eTrGWJnE5C0ug5Pt69PkheoTRRWV roJuHXz3ybQiR9fd+OCAqaqMk6PS1K6ufWQUIW/vyarBEShohNrsel07xRcA3iLxPDFd 7hojyH5IMb9dtq0ssC/bZdHfZPjKA2TADTPV9I8brZNEQ9PTkrhSxbXnDKkYYXHwjIAJ FjeQ== X-Gm-Message-State: AOAM531k0tOFLO/jaHFB2sS8qv/ZOBi6xDBWYWl0fiGf4LVWn6SmCoog FiveI4zT3gG9p7xXnit/rqY= X-Google-Smtp-Source: ABdhPJyTo9+sRapDu7NrIA5yA88XZaxNNZffIkE8/f8rSHy8reybydN8y/QdAITvfzIrsF/UeVWGSw== X-Received: by 2002:a5d:44d1:0:b0:218:418a:3e8e with SMTP id z17-20020a5d44d1000000b00218418a3e8emr6120121wrr.112.1654550826754; Mon, 06 Jun 2022 14:27:06 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c4f8600b0039b006bd6d9sm24758061wmq.6.2022.06.06.14.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 14:27:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Cc: mripard@kernel.org, wens@csie.org, airlied@linux.ie, Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, megi@xff.cz, Roman Stratiienko Subject: Re: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property Date: Mon, 06 Jun 2022 23:27:05 +0200 Message-ID: <2240089.ElGaqSPkdT@kista> In-Reply-To: References: <20220605154731.17362-1-roman.o.stratiienko@globallogic.com> <4714286.GXAFRqVoOG@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne ponedeljek, 06. junij 2022 ob 10:17:20 CEST je Roman Stratiienko=20 napisal(a): > Hello Jernej, >=20 > Thank you for having a look. >=20 > =D0=B2=D1=81, 5 =D0=B8=D1=8E=D0=BD. 2022 =D0=B3. =D0=B2 23:37, Jernej =C5= =A0krabec : > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko=20 napisal(a): > > > Allwinner DE2 and DE3 hardware support 3 pixel blend modes: > > > "None", "Pre-multiplied", "Coverage" > > > > > > Add the blend mode property and route it to the appropriate registers. > > > > > > Note: > > > "force_premulti" parameter was added to handle multi-overlay channel > > > cases in future changes. It must be set to true for cases when more > > > than 1 overlay layer is used within a channel and at least one of the > > > overlay layers within a group uses premultiplied blending mode. > > > > Please remove this parameter. It's nothing special, so it can be easily= =20 added > > once it's actually needed. For now, it only complicates code. >=20 > I would prefer keeping it if you do not have any strong opinion against i= t. Actually I do. Patch will be smaller and easier to follow if there is no ex= tra=20 variables with fixed values in it. >=20 > I am working now on exposing all overlays, so it will be needed soon anyw= ay. Well, it will just be one patch more there, if at all. Regards, Jernej >=20 > Also it helps to better understand the COV2PREMULT mode which has not > the best description in the datasheet. Only after testing this > register using devmem I became confident on its purpose. >=20 > > > > > > > > Test: > > > Manually tested all the modes using kmsxx python wrapper with and > > > without 'force_premulti' flag enabled. > > > > > > Signed-off-by: Roman Stratiienko > > > --- > > > drivers/gpu/drm/sun4i/sun8i_mixer.h | 2 ++ > > > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 48 ++++++++++++++++++++----- > > > drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 5 +++ > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 49 ++++++++++++++++++++++--= =2D- > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.h | 5 +++ > > > 5 files changed, 94 insertions(+), 15 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > b/drivers/gpu/drm/sun4i/sun8i_mixer.h index ebfc276b2464..5c05907e26fb > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > @@ -65,6 +65,8 @@ > > > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_MSK(n) (0xf << ((n) << 2)) > > > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_SHIFT(n) ((n) << 2) > > > > > > +#define SUN8I_MIXER_BLEND_PREMULTIPLY_EN(pipe) BIT(pipe) > > > + > > > #define SUN8I_MIXER_BLEND_OUTCTL_INTERLACED BIT(1) > > > > > > #define SUN50I_MIXER_BLEND_CSC_CTL_EN(ch) BIT(ch) > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c index 6ccbbca3176d.. 29c0d9cca19a > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > @@ -58,24 +58,46 @@ static void sun8i_ui_layer_enable(struct sun8i_mi= xer > > > *mixer, int channel, } > > > > > > static void sun8i_ui_layer_update_alpha(struct sun8i_mixer *mixer, i= nt > > > channel, - int overlay, struct > > drm_plane *plane) > > > + int overlay, struct > > drm_plane *plane, > > > + unsigned int zpos, > > bool force_premulti) > > > { > > > - u32 mask, val, ch_base; > > > + u32 mask, val, ch_base, bld_base; > > > + bool in_premulti, out_premulti; > > > > > > + bld_base =3D sun8i_blender_base(mixer); > > > ch_base =3D sun8i_channel_base(mixer, channel); > > > > > > + in_premulti =3D plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PREMULTI; > > > + out_premulti =3D force_premulti || in_premulti; > > > + > > > mask =3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_MASK | > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MASK; > > > + SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MASK | > > > + SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_MASK; > > > > > > val =3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA(plane->state->alph= a >> > > 8); > > > > > > - val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OPAQUE) ? > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + if (plane->state->pixel_blend_mode =3D=3D DRM_MODE_BLEND_PIXEL_= NONE) { > > > + val |=3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_LAYE= R; > > > + } else { > > > + val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OP= AQUE) > > ? > > > + > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > + > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + > > > + if (in_premulti) > > > + val |=3D > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_PREMULTI; > > > + } > > > + > > > + if (!in_premulti && out_premulti) > > > + val |=3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COV2PREM; > > > > > > regmap_update_bits(mixer->engine.regs, > > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR(ch_base, > > overlay), > > > mask, val); > > > + > > > + regmap_update_bits( > > > + mixer->engine.regs, > > SUN8I_MIXER_BLEND_PREMULTIPLY(bld_base), > > > + SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos), > > > + out_premulti ? SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos) : > > 0); > > > } > > > > > > static int sun8i_ui_layer_update_coord(struct sun8i_mixer *mixer, int > > > channel, @@ -274,7 +296,7 @@ static void > > > sun8i_ui_layer_atomic_update(struct drm_plane *plane, > > > sun8i_ui_layer_update_coord(mixer, layer->channel, > > > layer->overlay, plane, zpos); > > > sun8i_ui_layer_update_alpha(mixer, layer->channel, > > > - layer->overlay, plane); > > > + layer->overlay, plane, zpos, > > false); > > > sun8i_ui_layer_update_formats(mixer, layer->channel, > > > layer->overlay, plane); > > > sun8i_ui_layer_update_buffer(mixer, layer->channel, > > > @@ -332,8 +354,8 @@ struct sun8i_ui_layer=20 *sun8i_ui_layer_init_one(struct > > > drm_device *drm, { > > > enum drm_plane_type type =3D DRM_PLANE_TYPE_OVERLAY; > > > int channel =3D mixer->cfg->vi_num + index; > > > + unsigned int plane_cnt, blend_modes; > > > struct sun8i_ui_layer *layer; > > > - unsigned int plane_cnt; > > > int ret; > > > > > > layer =3D devm_kzalloc(drm->dev, sizeof(*layer), GFP_KERNEL); > > > @@ -362,6 +384,16 @@ struct sun8i_ui_layer=20 *sun8i_ui_layer_init_one(struct > > > drm_device *drm, return ERR_PTR(ret); > > > } > > > > > > + blend_modes =3D BIT(DRM_MODE_BLEND_PREMULTI) | > > > + BIT(DRM_MODE_BLEND_COVERAGE) | > > > + BIT(DRM_MODE_BLEND_PIXEL_NONE); > > > + > > > + ret =3D drm_plane_create_blend_mode_property(&layer->plane, > > blend_modes); > > > + if (ret) { > > > + dev_err(drm->dev, "Couldn't add blend mode > > property\n"); > > > + return ERR_PTR(ret); > > > + } > > > + > > > ret =3D drm_plane_create_zpos_property(&layer->plane, channel, > > > 0, plane_cnt - > > 1); > > > if (ret) { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.h index=20 43c48cf7bc51..bd3c30e8058d > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > @@ -46,6 +46,11 @@ > > > #define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_LAYER = =20 ((1) << 1) > > > #define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED ((2) <<= 1) > > > > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_MASK GENMASK(17, 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COVERAGE ((0) <<= 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COV2PREM ((1) <<= 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_PREMULTI ((2) <<= 16) > > > + > > > struct sun8i_mixer; > > > > > > struct sun8i_ui_layer { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index=20 662ba1018cc4..6581fc7d9668 > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > @@ -52,21 +52,38 @@ static void sun8i_vi_layer_enable(struct sun8i_mi= xer > > > *mixer, int channel, } > > > > > > static void sun8i_vi_layer_update_alpha(struct sun8i_mixer *mixer, i= nt > > > channel, - int overlay, struct > > drm_plane *plane) > > > + int overlay, struct > > drm_plane *plane, > > > + unsigned int zpos, > > bool force_premulti) > > > { > > > - u32 mask, val, ch_base; > > > + u32 mask, val, ch_base, bld_base; > > > + bool in_premulti =3D false, out_premulti =3D false; > > > > > > ch_base =3D sun8i_channel_base(mixer, channel); > > > + bld_base =3D sun8i_blender_base(mixer); > > > > > > if (mixer->cfg->is_de3) { > > > + in_premulti =3D plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PREMULTI; > > > + out_premulti =3D force_premulti || in_premulti; > > > + > > > mask =3D SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MASK | > > > - SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_MASK; > > > + SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_MASK > > | > > > + SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_MASK; > > > val =3D SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA > > > (plane->state->alpha >> 8); > > > > > > - val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OP= AQUE) > > ? > > > - > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > - > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + if (plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PIXEL_NONE) { > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_LAYER; > > > + } else { > > > + val |=3D (plane->state->alpha =3D=3D > > DRM_BLEND_ALPHA_OPAQUE) ? > > > + > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > + > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + > > > + if (in_premulti) > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_PREMULTI; > > > + } > > > + > > > + if (!in_premulti && out_premulti) > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COV2PREM; > > > > > > regmap_update_bits(mixer->engine.regs, > > > > > SUN8I_MIXER_CHAN_VI_LAYER_ATTR(ch_base, > > > @@ -79,6 +96,11 @@ static void sun8i_vi_layer_update_alpha(struct > > > sun8i_mixer *mixer, int channel, SUN8I_MIXER_FCC_GLOBAL_ALPHA > > > (plane->state->alpha > > >> 8)); > > > } > > > + > > > + regmap_update_bits( > > > + mixer->engine.regs, > > SUN8I_MIXER_BLEND_PREMULTIPLY(bld_base), > > > + SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos), > > > + out_premulti ? SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos) : > > 0); > > > > Shouldn't be above block inside DE3 if block? >=20 > No, we have to update the value to non-premulti in case it was set to > premulti by another layer. >=20 >=20 > Regards, > Roman. >=20 > > > > Looks good otherwise. > > > > Best regards, > > Jernej > > > > > } > > > > > > static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int > > > channel, @@ -408,7 +430,7 @@ static void > > > sun8i_vi_layer_atomic_update(struct drm_plane *plane, > > > sun8i_vi_layer_update_coord(mixer, layer->channel, > > > layer->overlay, plane, zpos); > > > sun8i_vi_layer_update_alpha(mixer, layer->channel, > > > - layer->overlay, plane); > > > + layer->overlay, plane, zpos, > > false); > > > sun8i_vi_layer_update_formats(mixer, layer->channel, > > > layer->overlay, plane); > > > sun8i_vi_layer_update_buffer(mixer, layer->channel, > > > @@ -563,6 +585,19 @@ struct sun8i_vi_layer=20 *sun8i_vi_layer_init_one(struct > > > drm_device *drm, } > > > } > > > > > > + if (mixer->cfg->is_de3) { > > > + unsigned int blend_modes =3D BIT(DRM_MODE_BLEND_PREMULT= I) > > | > > > + > > BIT(DRM_MODE_BLEND_COVERAGE) | > > > + > > BIT(DRM_MODE_BLEND_PIXEL_NONE); > > > + > > > + ret =3D drm_plane_create_blend_mode_property(&layer- > > >plane, > > > + > > blend_modes); > > > + if (ret) { > > > + dev_err(drm->dev, "Couldn't add blend mode > > property\n"); > > > + return ERR_PTR(ret); > > > + } > > > + } > > > + > > > ret =3D drm_plane_create_zpos_property(&layer->plane, index, > > > 0, plane_cnt - > > 1); > > > if (ret) { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.h index=20 9939a4cc7a52..ccf91f09f1fe > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > @@ -44,6 +44,11 @@ > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MASK GENMASK(31, 24) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA(x) ((x) << 24) > > > > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_MASK GENMASK(17, 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COVERAGE ((0) <<= 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COV2PREM ((1) <<= 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_PREMULTI ((2) <<= 16) > > > + > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL ((0) << > > 1) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_LAYER ((1) << > > 1) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED ((2) <<= 1) > > > > > > > > >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B8BEC43334 for ; Mon, 6 Jun 2022 21:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y1EtXcUWPgU7OkMuQo7pcHozQe21GF0TgIyDss69kSk=; b=llSE02Ua8nJIO2 N+b4UfJQPjXYS3GCYgMjCBn75kcDXad2ds07h0qZzfJZ/5Q+8NoL6B4MCbuln7FA4+2KgOoym/CXw LhDBhb6XHNzKr1I3qVIP6GVq5ZKDbitiIbaNigoGoHUlzud5Gpeg1M+ucVGYZRqSdoUETWYc2dzyp RG6Zw6qG6a8iyO8zvPKYVEAGry29jrBEjMAsTL73limhneiB33V/srCDEOyS5PAmvxsWpjeO+Uvab ZprrLYz7GC4rYHFiav8baVvWZNyFeRb4HVNtQJOt3Fl7+AA91LJkbiBXfoYFLEGsk4OzcKpxHuS9F pzK+8RHVOAsiNxBiyrNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyKFl-002s3R-UV; Mon, 06 Jun 2022 21:27:14 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyKFi-002s2U-NH for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 21:27:12 +0000 Received: by mail-wr1-x42d.google.com with SMTP id q15so13455256wrc.11 for ; Mon, 06 Jun 2022 14:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=UKJAaMHvsMk3isiZOfnAHzy5T2BlXzSGz/br0IRqcPitgBBVswDiMU6CXUv2eiX+nx RtmdEv+IiJCozRPwLIHyhiIyHX8UkEIEekJdyqSEVdGV+zcFG2qYr1e9p6q8bvQixB7p 15JkXEd+vp/VA3LRa3S4XcxWTbO8UKgPqHnx5ErXRzDDHDfnR2sWqATzGOV0K6e5Vl1x yG3GYe/AUb11OTOogIbyyneef7kjpiAg/E6/Ii1t5wUVPjW4lMUi+k1MDO/miT7zHmp2 Mh4ATTgL3Zvtj5mbpJrMAn/yZZF5Tud1O7hRPZUG6QEVu7P+pw3aPO3eicFyto8R2A8f pfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=684o5v7cf9DyqM1up3q2KCdMBEWzkGHVs4lGadDkJbNELF2ZH9ZomQk51MEXf74Wjl BmAjbRYBCYntswm0WnPKld0roWgqU1ApLsT3u4yNDIVQA+1MUwqFePYXL4qxfOeZPQsA iw8+jKXhl+fkIlNQZvVXTx9izEE3/6XGXID/P1WwlvJnlAm453tFt+BogVvZc9TmFzQl jw/lNNUD/qJfMyfjTPoxxlZl1zyusrnAFkRggVubxQiQf4iqfCM46dVfRz8kJFgPkOVC f/RW1UUMYRnylewM+E57UmZOoiUcj16r9ikP0G8AEC6OC/htQASWyl+NF7+qgJtcLCBw QhiA== X-Gm-Message-State: AOAM530U3mJAqYfMNcwaVU9aQTdldTDOl23jPOmzTHK7w2jLLxdjDvbS J3c8zVX59rZIqcx+Mq1HPmI= X-Google-Smtp-Source: ABdhPJyTo9+sRapDu7NrIA5yA88XZaxNNZffIkE8/f8rSHy8reybydN8y/QdAITvfzIrsF/UeVWGSw== X-Received: by 2002:a5d:44d1:0:b0:218:418a:3e8e with SMTP id z17-20020a5d44d1000000b00218418a3e8emr6120121wrr.112.1654550826754; Mon, 06 Jun 2022 14:27:06 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c4f8600b0039b006bd6d9sm24758061wmq.6.2022.06.06.14.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 14:27:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Cc: mripard@kernel.org, wens@csie.org, airlied@linux.ie, Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, megi@xff.cz, Roman Stratiienko Subject: Re: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property Date: Mon, 06 Jun 2022 23:27:05 +0200 Message-ID: <2240089.ElGaqSPkdT@kista> In-Reply-To: References: <20220605154731.17362-1-roman.o.stratiienko@globallogic.com> <4714286.GXAFRqVoOG@jernej-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_142710_811442_D4603F51 X-CRM114-Status: GOOD ( 34.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHBvbmVkZWxqZWssIDA2LiBqdW5paiAyMDIyIG9iIDEwOjE3OjIwIENFU1QgamUgUm9tYW4g U3RyYXRpaWVua28gCm5hcGlzYWwoYSk6Cj4gSGVsbG8gSmVybmVqLAo+IAo+IFRoYW5rIHlvdSBm b3IgaGF2aW5nIGEgbG9vay4KPiAKPiDQstGBLCA1INC40Y7QvS4gMjAyMiDQsy4g0LIgMjM6Mzcs IEplcm5laiDFoGtyYWJlYyA8amVybmVqLnNrcmFiZWNAZ21haWwuY29tPjoKPiA+Cj4gPiBEbmUg bmVkZWxqYSwgMDUuIGp1bmlqIDIwMjIgb2IgMTc6NDc6MzEgQ0VTVCBqZSBSb21hbiBTdHJhdGlp ZW5rbyAKbmFwaXNhbChhKToKPiA+ID4gQWxsd2lubmVyIERFMiBhbmQgREUzIGhhcmR3YXJlIHN1 cHBvcnQgMyBwaXhlbCBibGVuZCBtb2RlczoKPiA+ID4gIk5vbmUiLCAiUHJlLW11bHRpcGxpZWQi LCAiQ292ZXJhZ2UiCj4gPiA+Cj4gPiA+IEFkZCB0aGUgYmxlbmQgbW9kZSBwcm9wZXJ0eSBhbmQg cm91dGUgaXQgdG8gdGhlIGFwcHJvcHJpYXRlIHJlZ2lzdGVycy4KPiA+ID4KPiA+ID4gTm90ZToK PiA+ID4gImZvcmNlX3ByZW11bHRpIiBwYXJhbWV0ZXIgd2FzIGFkZGVkIHRvIGhhbmRsZSBtdWx0 aS1vdmVybGF5IGNoYW5uZWwKPiA+ID4gY2FzZXMgaW4gZnV0dXJlIGNoYW5nZXMuIEl0IG11c3Qg YmUgc2V0IHRvIHRydWUgZm9yIGNhc2VzIHdoZW4gbW9yZQo+ID4gPiB0aGFuIDEgb3ZlcmxheSBs YXllciBpcyB1c2VkIHdpdGhpbiBhIGNoYW5uZWwgYW5kIGF0IGxlYXN0IG9uZSBvZiB0aGUKPiA+ ID4gb3ZlcmxheSBsYXllcnMgd2l0aGluIGEgZ3JvdXAgdXNlcyBwcmVtdWx0aXBsaWVkIGJsZW5k aW5nIG1vZGUuCj4gPgo+ID4gUGxlYXNlIHJlbW92ZSB0aGlzIHBhcmFtZXRlci4gSXQncyBub3Ro aW5nIHNwZWNpYWwsIHNvIGl0IGNhbiBiZSBlYXNpbHkgCmFkZGVkCj4gPiBvbmNlIGl0J3MgYWN0 dWFsbHkgbmVlZGVkLiBGb3Igbm93LCBpdCBvbmx5IGNvbXBsaWNhdGVzIGNvZGUuCj4gCj4gSSB3 b3VsZCBwcmVmZXIga2VlcGluZyBpdCBpZiB5b3UgZG8gbm90IGhhdmUgYW55IHN0cm9uZyBvcGlu aW9uIGFnYWluc3QgaXQuCgpBY3R1YWxseSBJIGRvLiBQYXRjaCB3aWxsIGJlIHNtYWxsZXIgYW5k IGVhc2llciB0byBmb2xsb3cgaWYgdGhlcmUgaXMgbm8gZXh0cmEgCnZhcmlhYmxlcyB3aXRoIGZp eGVkIHZhbHVlcyBpbiBpdC4KCj4gCj4gSSBhbSB3b3JraW5nIG5vdyBvbiBleHBvc2luZyBhbGwg b3ZlcmxheXMsIHNvIGl0IHdpbGwgYmUgbmVlZGVkIHNvb24gYW55d2F5LgoKV2VsbCwgaXQgd2ls bCBqdXN0IGJlIG9uZSBwYXRjaCBtb3JlIHRoZXJlLCBpZiBhdCBhbGwuCgpSZWdhcmRzLApKZXJu ZWoKCj4gCj4gQWxzbyBpdCBoZWxwcyB0byBiZXR0ZXIgdW5kZXJzdGFuZCB0aGUgQ09WMlBSRU1V TFQgbW9kZSB3aGljaCBoYXMgbm90Cj4gdGhlIGJlc3QgZGVzY3JpcHRpb24gaW4gdGhlIGRhdGFz aGVldC4gT25seSBhZnRlciB0ZXN0aW5nIHRoaXMKPiByZWdpc3RlciB1c2luZyBkZXZtZW0gSSBi ZWNhbWUgY29uZmlkZW50IG9uIGl0cyBwdXJwb3NlLgo+IAo+ID4KPiA+ID4KPiA+ID4gVGVzdDoK PiA+ID4gTWFudWFsbHkgdGVzdGVkIGFsbCB0aGUgbW9kZXMgdXNpbmcga21zeHggcHl0aG9uIHdy YXBwZXIgd2l0aCBhbmQKPiA+ID4gd2l0aG91dCAnZm9yY2VfcHJlbXVsdGknIGZsYWcgZW5hYmxl ZC4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUm9tYW4gU3RyYXRpaWVua28gPHJvbWFuLm8u c3RyYXRpaWVua29AZ2xvYmFsbG9naWMuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9zdW40aS9zdW44aV9taXhlci5oICAgIHwgIDIgKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9zdW40aS9zdW44aV91aV9sYXllci5jIHwgNDggKysrKysrKysrKysrKysrKysrKystLS0tLQo+ ID4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX3VpX2xheWVyLmggfCAgNSArKysKPiA+ ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5jIHwgNDkgKysrKysrKysr KysrKysrKysrKysrKy0tLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV92aV9s YXllci5oIHwgIDUgKysrCj4gPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDk0IGluc2VydGlvbnMoKyks IDE1IGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3N1bjRpL3N1bjhpX21peGVyLmgKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlf bWl4ZXIuaCBpbmRleCBlYmZjMjc2YjI0NjQuLjVjMDU5MDdlMjZmYgo+ID4gPiAxMDA2NDQKPiA+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX21peGVyLmgKPiA+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX21peGVyLmgKPiA+ID4gQEAgLTY1LDYgKzY1LDgg QEAKPiA+ID4gICNkZWZpbmUgU1VOOElfTUlYRVJfQkxFTkRfUk9VVEVfUElQRV9NU0sobikgICgw eGYgPDwgKChuKSA8PCAyKSkKPiA+ID4gICNkZWZpbmUgU1VOOElfTUlYRVJfQkxFTkRfUk9VVEVf UElQRV9TSElGVChuKSAgICAgICAgKChuKSA8PCAyKQo+ID4gPgo+ID4gPiArI2RlZmluZSBTVU44 SV9NSVhFUl9CTEVORF9QUkVNVUxUSVBMWV9FTihwaXBlKSAgICAgICBCSVQocGlwZSkKPiA+ID4g Kwo+ID4gPiAgI2RlZmluZSBTVU44SV9NSVhFUl9CTEVORF9PVVRDVExfSU5URVJMQUNFRCAgQklU KDEpCj4gPiA+Cj4gPiA+ICAjZGVmaW5lIFNVTjUwSV9NSVhFUl9CTEVORF9DU0NfQ1RMX0VOKGNo KSAgICBCSVQoY2gpCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3Vu OGlfdWlfbGF5ZXIuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV91aV9sYXll ci5jIGluZGV4IDZjY2JiY2EzMTc2ZC4uCjI5YzBkOWNjYTE5YQo+ID4gPiAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX3VpX2xheWVyLmMKPiA+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX3VpX2xheWVyLmMKPiA+ID4gQEAgLTU4LDI0ICs1 OCw0NiBAQCBzdGF0aWMgdm9pZCBzdW44aV91aV9sYXllcl9lbmFibGUoc3RydWN0IHN1bjhpX21p eGVyCj4gPiA+ICptaXhlciwgaW50IGNoYW5uZWwsIH0KPiA+ID4KPiA+ID4gIHN0YXRpYyB2b2lk IHN1bjhpX3VpX2xheWVyX3VwZGF0ZV9hbHBoYShzdHJ1Y3Qgc3VuOGlfbWl4ZXIgKm1peGVyLCBp bnQKPiA+ID4gY2hhbm5lbCwgLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlu dCBvdmVybGF5LCBzdHJ1Y3QKPiA+IGRybV9wbGFuZSAqcGxhbmUpCj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IG92ZXJsYXksIHN0cnVjdAo+ID4gZHJtX3Bs YW5lICpwbGFuZSwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 bnNpZ25lZCBpbnQgenBvcywKPiA+IGJvb2wgZm9yY2VfcHJlbXVsdGkpCj4gPiA+ICB7Cj4gPiA+ IC0gICAgIHUzMiBtYXNrLCB2YWwsIGNoX2Jhc2U7Cj4gPiA+ICsgICAgIHUzMiBtYXNrLCB2YWws IGNoX2Jhc2UsIGJsZF9iYXNlOwo+ID4gPiArICAgICBib29sIGluX3ByZW11bHRpLCBvdXRfcHJl bXVsdGk7Cj4gPiA+Cj4gPiA+ICsgICAgIGJsZF9iYXNlID0gc3VuOGlfYmxlbmRlcl9iYXNlKG1p eGVyKTsKPiA+ID4gICAgICAgY2hfYmFzZSA9IHN1bjhpX2NoYW5uZWxfYmFzZShtaXhlciwgY2hh bm5lbCk7Cj4gPiA+Cj4gPiA+ICsgICAgIGluX3ByZW11bHRpID0gcGxhbmUtPnN0YXRlLT5waXhl bF9ibGVuZF9tb2RlID09Cj4gPiBEUk1fTU9ERV9CTEVORF9QUkVNVUxUSTsKPiA+ID4gKyAgICAg b3V0X3ByZW11bHRpID0gZm9yY2VfcHJlbXVsdGkgfHwgaW5fcHJlbXVsdGk7Cj4gPiA+ICsKPiA+ ID4gICAgICAgbWFzayA9IFNVTjhJX01JWEVSX0NIQU5fVUlfTEFZRVJfQVRUUl9BTFBIQV9NT0RF X01BU0sgfAo+ID4gPiAtICAgICAgICAgICAgIFNVTjhJX01JWEVSX0NIQU5fVUlfTEFZRVJfQVRU Ul9BTFBIQV9NQVNLOwo+ID4gPiArICAgICAgICAgICAgU1VOOElfTUlYRVJfQ0hBTl9VSV9MQVlF Ul9BVFRSX0FMUEhBX01BU0sgfAo+ID4gPiArICAgICAgICAgICAgU1VOOElfTUlYRVJfQ0hBTl9V SV9MQVlFUl9BVFRSX0JMRU5EX01BU0s7Cj4gPiA+Cj4gPiA+ICAgICAgIHZhbCA9IFNVTjhJX01J WEVSX0NIQU5fVUlfTEFZRVJfQVRUUl9BTFBIQShwbGFuZS0+c3RhdGUtPmFscGhhID4+Cj4gPiA4 KTsKPiA+ID4KPiA+ID4gLSAgICAgdmFsIHw9IChwbGFuZS0+c3RhdGUtPmFscGhhID09IERSTV9C TEVORF9BTFBIQV9PUEFRVUUpID8KPiA+ID4gLSAgICAgICAgICAgICBTVU44SV9NSVhFUl9DSEFO X1VJX0xBWUVSX0FUVFJfQUxQSEFfTU9ERV9QSVhFTCA6Cj4gPiA+IC0gICAgICAgICAgICAgU1VO OElfTUlYRVJfQ0hBTl9VSV9MQVlFUl9BVFRSX0FMUEhBX01PREVfQ09NQklORUQ7Cj4gPiA+ICsg ICAgIGlmIChwbGFuZS0+c3RhdGUtPnBpeGVsX2JsZW5kX21vZGUgPT0gRFJNX01PREVfQkxFTkRf UElYRUxfTk9ORSkgewo+ID4gPiArICAgICAgICAgICAgIHZhbCB8PSBTVU44SV9NSVhFUl9DSEFO X1VJX0xBWUVSX0FUVFJfQUxQSEFfTU9ERV9MQVlFUjsKPiA+ID4gKyAgICAgfSBlbHNlIHsKPiA+ ID4gKyAgICAgICAgICAgICB2YWwgfD0gKHBsYW5lLT5zdGF0ZS0+YWxwaGEgPT0gRFJNX0JMRU5E X0FMUEhBX09QQVFVRSkKPiA+ID8KPiA+ID4gKwo+ID4gU1VOOElfTUlYRVJfQ0hBTl9VSV9MQVlF Ul9BVFRSX0FMUEhBX01PREVfUElYRUwgOgo+ID4gPiArCj4gPiBTVU44SV9NSVhFUl9DSEFOX1VJ X0xBWUVSX0FUVFJfQUxQSEFfTU9ERV9DT01CSU5FRDsKPiA+ID4gKwo+ID4gPiArICAgICAgICAg ICAgIGlmIChpbl9wcmVtdWx0aSkKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIHZhbCB8PQo+ ID4gU1VOOElfTUlYRVJfQ0hBTl9VSV9MQVlFUl9BVFRSX0JMRU5EX1BSRU1VTFRJOwo+ID4gPiAr ICAgICB9Cj4gPiA+ICsKPiA+ID4gKyAgICAgaWYgKCFpbl9wcmVtdWx0aSAmJiBvdXRfcHJlbXVs dGkpCj4gPiA+ICsgICAgICAgICAgICAgdmFsIHw9IFNVTjhJX01JWEVSX0NIQU5fVUlfTEFZRVJf QVRUUl9CTEVORF9DT1YyUFJFTTsKPiA+ID4KPiA+ID4gICAgICAgcmVnbWFwX3VwZGF0ZV9iaXRz KG1peGVyLT5lbmdpbmUucmVncywKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgIFNVTjhJ X01JWEVSX0NIQU5fVUlfTEFZRVJfQVRUUihjaF9iYXNlLAo+ID4gb3ZlcmxheSksCj4gPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgICBtYXNrLCB2YWwpOwo+ID4gPiArCj4gPiA+ICsgICAgIHJl Z21hcF91cGRhdGVfYml0cygKPiA+ID4gKyAgICAgICAgICAgICBtaXhlci0+ZW5naW5lLnJlZ3Ms Cj4gPiBTVU44SV9NSVhFUl9CTEVORF9QUkVNVUxUSVBMWShibGRfYmFzZSksCj4gPiA+ICsgICAg ICAgICAgICAgU1VOOElfTUlYRVJfQkxFTkRfUFJFTVVMVElQTFlfRU4oenBvcyksCj4gPiA+ICsg ICAgICAgICAgICAgb3V0X3ByZW11bHRpID8gU1VOOElfTUlYRVJfQkxFTkRfUFJFTVVMVElQTFlf RU4oenBvcykgOgo+ID4gMCk7Cj4gPiA+ICB9Cj4gPiA+Cj4gPiA+ICBzdGF0aWMgaW50IHN1bjhp X3VpX2xheWVyX3VwZGF0ZV9jb29yZChzdHJ1Y3Qgc3VuOGlfbWl4ZXIgKm1peGVyLCBpbnQKPiA+ ID4gY2hhbm5lbCwgQEAgLTI3NCw3ICsyOTYsNyBAQCBzdGF0aWMgdm9pZAo+ID4gPiBzdW44aV91 aV9sYXllcl9hdG9taWNfdXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gPiBzdW44 aV91aV9sYXllcl91cGRhdGVfY29vcmQobWl4ZXIsIGxheWVyLT5jaGFubmVsLAo+ID4gPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXItPm92ZXJsYXksIHBsYW5lLCB6cG9z KTsKPiA+ID4gICAgICAgc3VuOGlfdWlfbGF5ZXJfdXBkYXRlX2FscGhhKG1peGVyLCBsYXllci0+ Y2hhbm5lbCwKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxheWVyLT5v dmVybGF5LCBwbGFuZSk7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs YXllci0+b3ZlcmxheSwgcGxhbmUsIHpwb3MsCj4gPiBmYWxzZSk7Cj4gPiA+ICAgICAgIHN1bjhp X3VpX2xheWVyX3VwZGF0ZV9mb3JtYXRzKG1peGVyLCBsYXllci0+Y2hhbm5lbCwKPiA+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXItPm92ZXJsYXksIHBsYW5lKTsK PiA+ID4gICAgICAgc3VuOGlfdWlfbGF5ZXJfdXBkYXRlX2J1ZmZlcihtaXhlciwgbGF5ZXItPmNo YW5uZWwsCj4gPiA+IEBAIC0zMzIsOCArMzU0LDggQEAgc3RydWN0IHN1bjhpX3VpX2xheWVyIAoq c3VuOGlfdWlfbGF5ZXJfaW5pdF9vbmUoc3RydWN0Cj4gPiA+IGRybV9kZXZpY2UgKmRybSwgewo+ ID4gPiAgICAgICBlbnVtIGRybV9wbGFuZV90eXBlIHR5cGUgPSBEUk1fUExBTkVfVFlQRV9PVkVS TEFZOwo+ID4gPiAgICAgICBpbnQgY2hhbm5lbCA9IG1peGVyLT5jZmctPnZpX251bSArIGluZGV4 Owo+ID4gPiArICAgICB1bnNpZ25lZCBpbnQgcGxhbmVfY250LCBibGVuZF9tb2RlczsKPiA+ID4g ICAgICAgc3RydWN0IHN1bjhpX3VpX2xheWVyICpsYXllcjsKPiA+ID4gLSAgICAgdW5zaWduZWQg aW50IHBsYW5lX2NudDsKPiA+ID4gICAgICAgaW50IHJldDsKPiA+ID4KPiA+ID4gICAgICAgbGF5 ZXIgPSBkZXZtX2t6YWxsb2MoZHJtLT5kZXYsIHNpemVvZigqbGF5ZXIpLCBHRlBfS0VSTkVMKTsK PiA+ID4gQEAgLTM2Miw2ICszODQsMTYgQEAgc3RydWN0IHN1bjhpX3VpX2xheWVyIAoqc3VuOGlf dWlfbGF5ZXJfaW5pdF9vbmUoc3RydWN0Cj4gPiA+IGRybV9kZXZpY2UgKmRybSwgcmV0dXJuIEVS Ul9QVFIocmV0KTsKPiA+ID4gICAgICAgfQo+ID4gPgo+ID4gPiArICAgICBibGVuZF9tb2RlcyA9 IEJJVChEUk1fTU9ERV9CTEVORF9QUkVNVUxUSSkgfAo+ID4gPiArICAgICAgICAgICAgICAgICAg IEJJVChEUk1fTU9ERV9CTEVORF9DT1ZFUkFHRSkgfAo+ID4gPiArICAgICAgICAgICAgICAgICAg IEJJVChEUk1fTU9ERV9CTEVORF9QSVhFTF9OT05FKTsKPiA+ID4gKwo+ID4gPiArICAgICByZXQg PSBkcm1fcGxhbmVfY3JlYXRlX2JsZW5kX21vZGVfcHJvcGVydHkoJmxheWVyLT5wbGFuZSwKPiA+ IGJsZW5kX21vZGVzKTsKPiA+ID4gKyAgICAgaWYgKHJldCkgewo+ID4gPiArICAgICAgICAgICAg IGRldl9lcnIoZHJtLT5kZXYsICJDb3VsZG4ndCBhZGQgYmxlbmQgbW9kZQo+ID4gcHJvcGVydHlc biIpOwo+ID4gPiArICAgICAgICAgICAgIHJldHVybiBFUlJfUFRSKHJldCk7Cj4gPiA+ICsgICAg IH0KPiA+ID4gKwo+ID4gPiAgICAgICByZXQgPSBkcm1fcGxhbmVfY3JlYXRlX3pwb3NfcHJvcGVy dHkoJmxheWVyLT5wbGFuZSwgY2hhbm5lbCwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDAsIHBsYW5lX2NudCAtCj4gPiAxKTsKPiA+ID4gICAgICAgaWYg KHJldCkgewo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX3Vp X2xheWVyLmgKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfdWlfbGF5ZXIuaCBp bmRleCAKNDNjNDhjZjdiYzUxLi5iZDNjMzBlODA1OGQKPiA+ID4gMTAwNjQ0Cj4gPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV91aV9sYXllci5oCj4gPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9zdW40aS9zdW44aV91aV9sYXllci5oCj4gPiA+IEBAIC00Niw2ICs0NiwxMSBA QAo+ID4gPiAgI2RlZmluZSBTVU44SV9NSVhFUl9DSEFOX1VJX0xBWUVSX0FUVFJfQUxQSEFfTU9E RV9MQVlFUiAgICAgICAgICAgICAgCigoMSkgPDwgMSkKPiA+ID4gICNkZWZpbmUgU1VOOElfTUlY RVJfQ0hBTl9VSV9MQVlFUl9BVFRSX0FMUEhBX01PREVfQ09NQklORUQgICAoKDIpIDw8IDEpCj4g PiA+Cj4gPiA+ICsjZGVmaW5lIFNVTjhJX01JWEVSX0NIQU5fVUlfTEFZRVJfQVRUUl9CTEVORF9N QVNLICAgIEdFTk1BU0soMTcsIDE2KQo+ID4gPiArI2RlZmluZSBTVU44SV9NSVhFUl9DSEFOX1VJ X0xBWUVSX0FUVFJfQkxFTkRfQ09WRVJBR0UgICAgICAgICgoMCkgPDwgMTYpCj4gPiA+ICsjZGVm aW5lIFNVTjhJX01JWEVSX0NIQU5fVUlfTEFZRVJfQVRUUl9CTEVORF9DT1YyUFJFTSAgICAgICAg KCgxKSA8PCAxNikKPiA+ID4gKyNkZWZpbmUgU1VOOElfTUlYRVJfQ0hBTl9VSV9MQVlFUl9BVFRS X0JMRU5EX1BSRU1VTFRJICAgICAgICAoKDIpIDw8IDE2KQo+ID4gPiArCj4gPiA+ICBzdHJ1Y3Qg c3VuOGlfbWl4ZXI7Cj4gPiA+Cj4gPiA+ICBzdHJ1Y3Qgc3VuOGlfdWlfbGF5ZXIgewo+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX3ZpX2xheWVyLmMKPiA+ID4g Yi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfdmlfbGF5ZXIuYyBpbmRleCAKNjYyYmExMDE4 Y2M0Li42NTgxZmM3ZDk2NjgKPiA+ID4gMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9zdW40aS9zdW44aV92aV9sYXllci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zdW40 aS9zdW44aV92aV9sYXllci5jCj4gPiA+IEBAIC01MiwyMSArNTIsMzggQEAgc3RhdGljIHZvaWQg c3VuOGlfdmlfbGF5ZXJfZW5hYmxlKHN0cnVjdCBzdW44aV9taXhlcgo+ID4gPiAqbWl4ZXIsIGlu dCBjaGFubmVsLCB9Cj4gPiA+Cj4gPiA+ICBzdGF0aWMgdm9pZCBzdW44aV92aV9sYXllcl91cGRh dGVfYWxwaGEoc3RydWN0IHN1bjhpX21peGVyICptaXhlciwgaW50Cj4gPiA+IGNoYW5uZWwsIC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgb3ZlcmxheSwgc3RydWN0Cj4g PiBkcm1fcGxhbmUgKnBsYW5lKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBvdmVybGF5LCBzdHJ1Y3QKPiA+IGRybV9wbGFuZSAqcGxhbmUsCj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHpwb3MsCj4g PiBib29sIGZvcmNlX3ByZW11bHRpKQo+ID4gPiAgewo+ID4gPiAtICAgICB1MzIgbWFzaywgdmFs LCBjaF9iYXNlOwo+ID4gPiArICAgICB1MzIgbWFzaywgdmFsLCBjaF9iYXNlLCBibGRfYmFzZTsK PiA+ID4gKyAgICAgYm9vbCBpbl9wcmVtdWx0aSA9IGZhbHNlLCBvdXRfcHJlbXVsdGkgPSBmYWxz ZTsKPiA+ID4KPiA+ID4gICAgICAgY2hfYmFzZSA9IHN1bjhpX2NoYW5uZWxfYmFzZShtaXhlciwg Y2hhbm5lbCk7Cj4gPiA+ICsgICAgIGJsZF9iYXNlID0gc3VuOGlfYmxlbmRlcl9iYXNlKG1peGVy KTsKPiA+ID4KPiA+ID4gICAgICAgaWYgKG1peGVyLT5jZmctPmlzX2RlMykgewo+ID4gPiArICAg ICAgICAgICAgIGluX3ByZW11bHRpID0gcGxhbmUtPnN0YXRlLT5waXhlbF9ibGVuZF9tb2RlID09 Cj4gPiBEUk1fTU9ERV9CTEVORF9QUkVNVUxUSTsKPiA+ID4gKyAgICAgICAgICAgICBvdXRfcHJl bXVsdGkgPSBmb3JjZV9wcmVtdWx0aSB8fCBpbl9wcmVtdWx0aTsKPiA+ID4gKwo+ID4gPiAgICAg ICAgICAgICAgIG1hc2sgPSBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FMUEhBX01B U0sgfAo+ID4gPiAtICAgICAgICAgICAgICAgICAgICBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlF Ul9BVFRSX0FMUEhBX01PREVfTUFTSzsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgU1VONTBJ X01JWEVSX0NIQU5fVklfTEFZRVJfQVRUUl9BTFBIQV9NT0RFX01BU0sKPiA+IHwKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgU1VONTBJX01JWEVSX0NIQU5fVklfTEFZRVJfQVRUUl9CTEVORF9N QVNLOwo+ID4gPiAgICAgICAgICAgICAgIHZhbCA9IFNVTjUwSV9NSVhFUl9DSEFOX1ZJX0xBWUVS X0FUVFJfQUxQSEEKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIChwbGFuZS0+c3RhdGUtPmFs cGhhID4+IDgpOwo+ID4gPgo+ID4gPiAtICAgICAgICAgICAgIHZhbCB8PSAocGxhbmUtPnN0YXRl LT5hbHBoYSA9PSBEUk1fQkxFTkRfQUxQSEFfT1BBUVVFKQo+ID4gPwo+ID4gPiAtCj4gPiBTVU41 MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FMUEhBX01PREVfUElYRUwgOgo+ID4gPiAtCj4g PiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FMUEhBX01PREVfQ09NQklORUQ7Cj4g PiA+ICsgICAgICAgICAgICAgaWYgKHBsYW5lLT5zdGF0ZS0+cGl4ZWxfYmxlbmRfbW9kZSA9PQo+ ID4gRFJNX01PREVfQkxFTkRfUElYRUxfTk9ORSkgewo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgdmFsIHw9Cj4gPiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FMUEhBX01PREVf TEFZRVI7Cj4gPiA+ICsgICAgICAgICAgICAgfSBlbHNlIHsKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgIHZhbCB8PSAocGxhbmUtPnN0YXRlLT5hbHBoYSA9PQo+ID4gRFJNX0JMRU5EX0FMUEhB X09QQVFVRSkgPwo+ID4gPiArCj4gPiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FM UEhBX01PREVfUElYRUwgOgo+ID4gPiArCj4gPiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9B VFRSX0FMUEhBX01PREVfQ09NQklORUQ7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgIGlmIChpbl9wcmVtdWx0aSkKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dmFsIHw9Cj4gPiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0JMRU5EX1BSRU1VTFRJ Owo+ID4gPiArICAgICAgICAgICAgIH0KPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAgIGlmICgh aW5fcHJlbXVsdGkgJiYgb3V0X3ByZW11bHRpKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg dmFsIHw9Cj4gPiBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0JMRU5EX0NPVjJQUkVN Owo+ID4gPgo+ID4gPiAgICAgICAgICAgICAgIHJlZ21hcF91cGRhdGVfYml0cyhtaXhlci0+ZW5n aW5lLnJlZ3MsCj4gPiA+Cj4gPiBTVU44SV9NSVhFUl9DSEFOX1ZJX0xBWUVSX0FUVFIoY2hfYmFz ZSwKPiA+ID4gQEAgLTc5LDYgKzk2LDExIEBAIHN0YXRpYyB2b2lkIHN1bjhpX3ZpX2xheWVyX3Vw ZGF0ZV9hbHBoYShzdHJ1Y3QKPiA+ID4gc3VuOGlfbWl4ZXIgKm1peGVyLCBpbnQgY2hhbm5lbCwg U1VOOElfTUlYRVJfRkNDX0dMT0JBTF9BTFBIQQo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChwbGFuZS0+c3RhdGUtPmFscGhhCj4gPiA+PiA4KSk7Cj4gPiA+ICAg ICAgIH0KPiA+ID4gKwo+ID4gPiArICAgICByZWdtYXBfdXBkYXRlX2JpdHMoCj4gPiA+ICsgICAg ICAgICAgICAgbWl4ZXItPmVuZ2luZS5yZWdzLAo+ID4gU1VOOElfTUlYRVJfQkxFTkRfUFJFTVVM VElQTFkoYmxkX2Jhc2UpLAo+ID4gPiArICAgICAgICAgICAgIFNVTjhJX01JWEVSX0JMRU5EX1BS RU1VTFRJUExZX0VOKHpwb3MpLAo+ID4gPiArICAgICAgICAgICAgIG91dF9wcmVtdWx0aSA/IFNV TjhJX01JWEVSX0JMRU5EX1BSRU1VTFRJUExZX0VOKHpwb3MpIDoKPiA+IDApOwo+ID4KPiA+IFNo b3VsZG4ndCBiZSBhYm92ZSBibG9jayBpbnNpZGUgREUzIGlmIGJsb2NrPwo+IAo+IE5vLCB3ZSBo YXZlIHRvIHVwZGF0ZSB0aGUgdmFsdWUgdG8gbm9uLXByZW11bHRpIGluIGNhc2UgaXQgd2FzIHNl dCB0bwo+IHByZW11bHRpIGJ5IGFub3RoZXIgbGF5ZXIuCj4gCj4gCj4gUmVnYXJkcywKPiBSb21h bi4KPiAKPiA+Cj4gPiBMb29rcyBnb29kIG90aGVyd2lzZS4KPiA+Cj4gPiBCZXN0IHJlZ2FyZHMs Cj4gPiBKZXJuZWoKPiA+Cj4gPiA+ICB9Cj4gPiA+Cj4gPiA+ICBzdGF0aWMgaW50IHN1bjhpX3Zp X2xheWVyX3VwZGF0ZV9jb29yZChzdHJ1Y3Qgc3VuOGlfbWl4ZXIgKm1peGVyLCBpbnQKPiA+ID4g Y2hhbm5lbCwgQEAgLTQwOCw3ICs0MzAsNyBAQCBzdGF0aWMgdm9pZAo+ID4gPiBzdW44aV92aV9s YXllcl9hdG9taWNfdXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gPiBzdW44aV92 aV9sYXllcl91cGRhdGVfY29vcmQobWl4ZXIsIGxheWVyLT5jaGFubmVsLAo+ID4gPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXItPm92ZXJsYXksIHBsYW5lLCB6cG9zKTsK PiA+ID4gICAgICAgc3VuOGlfdmlfbGF5ZXJfdXBkYXRlX2FscGhhKG1peGVyLCBsYXllci0+Y2hh bm5lbCwKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxheWVyLT5vdmVy bGF5LCBwbGFuZSk7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXll ci0+b3ZlcmxheSwgcGxhbmUsIHpwb3MsCj4gPiBmYWxzZSk7Cj4gPiA+ICAgICAgIHN1bjhpX3Zp X2xheWVyX3VwZGF0ZV9mb3JtYXRzKG1peGVyLCBsYXllci0+Y2hhbm5lbCwKPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGF5ZXItPm92ZXJsYXksIHBsYW5lKTsKPiA+ ID4gICAgICAgc3VuOGlfdmlfbGF5ZXJfdXBkYXRlX2J1ZmZlcihtaXhlciwgbGF5ZXItPmNoYW5u ZWwsCj4gPiA+IEBAIC01NjMsNiArNTg1LDE5IEBAIHN0cnVjdCBzdW44aV92aV9sYXllciAKKnN1 bjhpX3ZpX2xheWVyX2luaXRfb25lKHN0cnVjdAo+ID4gPiBkcm1fZGV2aWNlICpkcm0sIH0KPiA+ ID4gICAgICAgfQo+ID4gPgo+ID4gPiArICAgICBpZiAobWl4ZXItPmNmZy0+aXNfZGUzKSB7Cj4g PiA+ICsgICAgICAgICAgICAgdW5zaWduZWQgaW50IGJsZW5kX21vZGVzID0gQklUKERSTV9NT0RF X0JMRU5EX1BSRU1VTFRJKQo+ID4gfAo+ID4gPiArCj4gPiBCSVQoRFJNX01PREVfQkxFTkRfQ09W RVJBR0UpIHwKPiA+ID4gKwo+ID4gQklUKERSTV9NT0RFX0JMRU5EX1BJWEVMX05PTkUpOwo+ID4g PiArCj4gPiA+ICsgICAgICAgICAgICAgcmV0ID0gZHJtX3BsYW5lX2NyZWF0ZV9ibGVuZF9tb2Rl X3Byb3BlcnR5KCZsYXllci0KPiA+ID5wbGFuZSwKPiA+ID4gKwo+ID4gYmxlbmRfbW9kZXMpOwo+ ID4gPiArICAgICAgICAgICAgIGlmIChyZXQpIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg IGRldl9lcnIoZHJtLT5kZXYsICJDb3VsZG4ndCBhZGQgYmxlbmQgbW9kZQo+ID4gcHJvcGVydHlc biIpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEVSUl9QVFIocmV0KTsKPiA+ ID4gKyAgICAgICAgICAgICB9Cj4gPiA+ICsgICAgIH0KPiA+ID4gKwo+ID4gPiAgICAgICByZXQg PSBkcm1fcGxhbmVfY3JlYXRlX3pwb3NfcHJvcGVydHkoJmxheWVyLT5wbGFuZSwgaW5kZXgsCj4g PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCBwbGFuZV9j bnQgLQo+ID4gMSk7Cj4gPiA+ICAgICAgIGlmIChyZXQpIHsKPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5oCj4gPiA+IGIvZHJpdmVycy9ncHUv ZHJtL3N1bjRpL3N1bjhpX3ZpX2xheWVyLmggaW5kZXggCjk5MzlhNGNjN2E1Mi4uY2NmOTFmMDlm MWZlCj4gPiA+IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlf dmlfbGF5ZXIuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfdmlfbGF5 ZXIuaAo+ID4gPiBAQCAtNDQsNiArNDQsMTEgQEAKPiA+ID4gICNkZWZpbmUgU1VONTBJX01JWEVS X0NIQU5fVklfTEFZRVJfQVRUUl9BTFBIQV9NQVNLICAgR0VOTUFTSygzMSwgMjQpCj4gPiA+ICAj ZGVmaW5lIFNVTjUwSV9NSVhFUl9DSEFOX1ZJX0xBWUVSX0FUVFJfQUxQSEEoeCkgICAgICgoeCkg PDwgMjQpCj4gPiA+Cj4gPiA+ICsjZGVmaW5lIFNVTjUwSV9NSVhFUl9DSEFOX1ZJX0xBWUVSX0FU VFJfQkxFTkRfTUFTSyAgIEdFTk1BU0soMTcsIDE2KQo+ID4gPiArI2RlZmluZSBTVU41MElfTUlY RVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0JMRU5EX0NPVkVSQUdFICAgICAgICgoMCkgPDwgMTYpCj4g PiA+ICsjZGVmaW5lIFNVTjUwSV9NSVhFUl9DSEFOX1ZJX0xBWUVSX0FUVFJfQkxFTkRfQ09WMlBS RU0gICAgICAgKCgxKSA8PCAxNikKPiA+ID4gKyNkZWZpbmUgU1VONTBJX01JWEVSX0NIQU5fVklf TEFZRVJfQVRUUl9CTEVORF9QUkVNVUxUSSAgICAgICAoKDIpIDw8IDE2KQo+ID4gPiArCj4gPiA+ ICAjZGVmaW5lIFNVTjUwSV9NSVhFUl9DSEFOX1ZJX0xBWUVSX0FUVFJfQUxQSEFfTU9ERV9QSVhF TCAgICAgKCgwKSA8PAo+ID4gMSkKPiA+ID4gICNkZWZpbmUgU1VONTBJX01JWEVSX0NIQU5fVklf TEFZRVJfQVRUUl9BTFBIQV9NT0RFX0xBWUVSICAgICAoKDEpIDw8Cj4gPiAxKQo+ID4gPiAgI2Rl ZmluZSBTVU41MElfTUlYRVJfQ0hBTl9WSV9MQVlFUl9BVFRSX0FMUEhBX01PREVfQ09NQklORUQg ICgoMikgPDwgMSkKPiA+Cj4gPgo+ID4KPiA+Cj4gCgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56445C43334 for ; Mon, 6 Jun 2022 21:27:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 468E210E8E0; Mon, 6 Jun 2022 21:27:10 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2687910E8E0 for ; Mon, 6 Jun 2022 21:27:08 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id k19so21472406wrd.8 for ; Mon, 06 Jun 2022 14:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=UKJAaMHvsMk3isiZOfnAHzy5T2BlXzSGz/br0IRqcPitgBBVswDiMU6CXUv2eiX+nx RtmdEv+IiJCozRPwLIHyhiIyHX8UkEIEekJdyqSEVdGV+zcFG2qYr1e9p6q8bvQixB7p 15JkXEd+vp/VA3LRa3S4XcxWTbO8UKgPqHnx5ErXRzDDHDfnR2sWqATzGOV0K6e5Vl1x yG3GYe/AUb11OTOogIbyyneef7kjpiAg/E6/Ii1t5wUVPjW4lMUi+k1MDO/miT7zHmp2 Mh4ATTgL3Zvtj5mbpJrMAn/yZZF5Tud1O7hRPZUG6QEVu7P+pw3aPO3eicFyto8R2A8f pfXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R9WXEt0d5VWVPT45RFnI3iwWeV57Th5zrE4OG14fWsM=; b=Dk0Wyf1ccovQodmHengy+QR9pjwRWljbl4Wpcz5ZEpepUt7YZoKLDvUPI0uDonINHI PddJRZElGSuJ5Yv9YalbRqbu+C80Yi7mfPI/I9JbDzpTu0BwkQE5uqkHMRDDg8eiDj1b PPKJ6ssSA/yUL6kBY4MiXggKyOx23gHr9/5hwBAkIgRhMNmqLY4ajUEYOvPiWXj9b09X yj7rP/RZO5cwVTBH5zdj1KUUKAOHEz9Wmi/uZjPJ+xce1ZmQML9Verg3v9uiWK3wyhK6 ItBKeyTbgf3vGQqByVxuGteDHy0D80diKiJGbs7fBcc3teuB4U/AKZF9r6zHSgIl5Esm ORIg== X-Gm-Message-State: AOAM531VIpsXYBXJ8I1O60l1O2Zkj+y2gTwysH3vI0ITdHujj/N513oQ UyRkUG1wlhK7qULQnvAs9Lw= X-Google-Smtp-Source: ABdhPJyTo9+sRapDu7NrIA5yA88XZaxNNZffIkE8/f8rSHy8reybydN8y/QdAITvfzIrsF/UeVWGSw== X-Received: by 2002:a5d:44d1:0:b0:218:418a:3e8e with SMTP id z17-20020a5d44d1000000b00218418a3e8emr6120121wrr.112.1654550826754; Mon, 06 Jun 2022 14:27:06 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c4f8600b0039b006bd6d9sm24758061wmq.6.2022.06.06.14.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 14:27:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Subject: Re: Re: [PATCH] drm/sun4i: sun8i: Add support for pixel blend mode property Date: Mon, 06 Jun 2022 23:27:05 +0200 Message-ID: <2240089.ElGaqSPkdT@kista> In-Reply-To: References: <20220605154731.17362-1-roman.o.stratiienko@globallogic.com> <4714286.GXAFRqVoOG@jernej-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , airlied@linux.ie, Roman Stratiienko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, megi@xff.cz, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne ponedeljek, 06. junij 2022 ob 10:17:20 CEST je Roman Stratiienko=20 napisal(a): > Hello Jernej, >=20 > Thank you for having a look. >=20 > =D0=B2=D1=81, 5 =D0=B8=D1=8E=D0=BD. 2022 =D0=B3. =D0=B2 23:37, Jernej =C5= =A0krabec : > > > > Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko=20 napisal(a): > > > Allwinner DE2 and DE3 hardware support 3 pixel blend modes: > > > "None", "Pre-multiplied", "Coverage" > > > > > > Add the blend mode property and route it to the appropriate registers. > > > > > > Note: > > > "force_premulti" parameter was added to handle multi-overlay channel > > > cases in future changes. It must be set to true for cases when more > > > than 1 overlay layer is used within a channel and at least one of the > > > overlay layers within a group uses premultiplied blending mode. > > > > Please remove this parameter. It's nothing special, so it can be easily= =20 added > > once it's actually needed. For now, it only complicates code. >=20 > I would prefer keeping it if you do not have any strong opinion against i= t. Actually I do. Patch will be smaller and easier to follow if there is no ex= tra=20 variables with fixed values in it. >=20 > I am working now on exposing all overlays, so it will be needed soon anyw= ay. Well, it will just be one patch more there, if at all. Regards, Jernej >=20 > Also it helps to better understand the COV2PREMULT mode which has not > the best description in the datasheet. Only after testing this > register using devmem I became confident on its purpose. >=20 > > > > > > > > Test: > > > Manually tested all the modes using kmsxx python wrapper with and > > > without 'force_premulti' flag enabled. > > > > > > Signed-off-by: Roman Stratiienko > > > --- > > > drivers/gpu/drm/sun4i/sun8i_mixer.h | 2 ++ > > > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 48 ++++++++++++++++++++----- > > > drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 5 +++ > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 49 ++++++++++++++++++++++--= =2D- > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.h | 5 +++ > > > 5 files changed, 94 insertions(+), 15 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > b/drivers/gpu/drm/sun4i/sun8i_mixer.h index ebfc276b2464..5c05907e26fb > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > > > @@ -65,6 +65,8 @@ > > > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_MSK(n) (0xf << ((n) << 2)) > > > #define SUN8I_MIXER_BLEND_ROUTE_PIPE_SHIFT(n) ((n) << 2) > > > > > > +#define SUN8I_MIXER_BLEND_PREMULTIPLY_EN(pipe) BIT(pipe) > > > + > > > #define SUN8I_MIXER_BLEND_OUTCTL_INTERLACED BIT(1) > > > > > > #define SUN50I_MIXER_BLEND_CSC_CTL_EN(ch) BIT(ch) > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c index 6ccbbca3176d.. 29c0d9cca19a > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > > > @@ -58,24 +58,46 @@ static void sun8i_ui_layer_enable(struct sun8i_mi= xer > > > *mixer, int channel, } > > > > > > static void sun8i_ui_layer_update_alpha(struct sun8i_mixer *mixer, i= nt > > > channel, - int overlay, struct > > drm_plane *plane) > > > + int overlay, struct > > drm_plane *plane, > > > + unsigned int zpos, > > bool force_premulti) > > > { > > > - u32 mask, val, ch_base; > > > + u32 mask, val, ch_base, bld_base; > > > + bool in_premulti, out_premulti; > > > > > > + bld_base =3D sun8i_blender_base(mixer); > > > ch_base =3D sun8i_channel_base(mixer, channel); > > > > > > + in_premulti =3D plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PREMULTI; > > > + out_premulti =3D force_premulti || in_premulti; > > > + > > > mask =3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_MASK | > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MASK; > > > + SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MASK | > > > + SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_MASK; > > > > > > val =3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA(plane->state->alph= a >> > > 8); > > > > > > - val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OPAQUE) ? > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > - SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + if (plane->state->pixel_blend_mode =3D=3D DRM_MODE_BLEND_PIXEL_= NONE) { > > > + val |=3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_LAYE= R; > > > + } else { > > > + val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OP= AQUE) > > ? > > > + > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > + > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + > > > + if (in_premulti) > > > + val |=3D > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_PREMULTI; > > > + } > > > + > > > + if (!in_premulti && out_premulti) > > > + val |=3D SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COV2PREM; > > > > > > regmap_update_bits(mixer->engine.regs, > > > SUN8I_MIXER_CHAN_UI_LAYER_ATTR(ch_base, > > overlay), > > > mask, val); > > > + > > > + regmap_update_bits( > > > + mixer->engine.regs, > > SUN8I_MIXER_BLEND_PREMULTIPLY(bld_base), > > > + SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos), > > > + out_premulti ? SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos) : > > 0); > > > } > > > > > > static int sun8i_ui_layer_update_coord(struct sun8i_mixer *mixer, int > > > channel, @@ -274,7 +296,7 @@ static void > > > sun8i_ui_layer_atomic_update(struct drm_plane *plane, > > > sun8i_ui_layer_update_coord(mixer, layer->channel, > > > layer->overlay, plane, zpos); > > > sun8i_ui_layer_update_alpha(mixer, layer->channel, > > > - layer->overlay, plane); > > > + layer->overlay, plane, zpos, > > false); > > > sun8i_ui_layer_update_formats(mixer, layer->channel, > > > layer->overlay, plane); > > > sun8i_ui_layer_update_buffer(mixer, layer->channel, > > > @@ -332,8 +354,8 @@ struct sun8i_ui_layer=20 *sun8i_ui_layer_init_one(struct > > > drm_device *drm, { > > > enum drm_plane_type type =3D DRM_PLANE_TYPE_OVERLAY; > > > int channel =3D mixer->cfg->vi_num + index; > > > + unsigned int plane_cnt, blend_modes; > > > struct sun8i_ui_layer *layer; > > > - unsigned int plane_cnt; > > > int ret; > > > > > > layer =3D devm_kzalloc(drm->dev, sizeof(*layer), GFP_KERNEL); > > > @@ -362,6 +384,16 @@ struct sun8i_ui_layer=20 *sun8i_ui_layer_init_one(struct > > > drm_device *drm, return ERR_PTR(ret); > > > } > > > > > > + blend_modes =3D BIT(DRM_MODE_BLEND_PREMULTI) | > > > + BIT(DRM_MODE_BLEND_COVERAGE) | > > > + BIT(DRM_MODE_BLEND_PIXEL_NONE); > > > + > > > + ret =3D drm_plane_create_blend_mode_property(&layer->plane, > > blend_modes); > > > + if (ret) { > > > + dev_err(drm->dev, "Couldn't add blend mode > > property\n"); > > > + return ERR_PTR(ret); > > > + } > > > + > > > ret =3D drm_plane_create_zpos_property(&layer->plane, channel, > > > 0, plane_cnt - > > 1); > > > if (ret) { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.h index=20 43c48cf7bc51..bd3c30e8058d > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.h > > > @@ -46,6 +46,11 @@ > > > #define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_LAYER = =20 ((1) << 1) > > > #define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_ALPHA_MODE_COMBINED ((2) <<= 1) > > > > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_MASK GENMASK(17, 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COVERAGE ((0) <<= 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_COV2PREM ((1) <<= 16) > > > +#define SUN8I_MIXER_CHAN_UI_LAYER_ATTR_BLEND_PREMULTI ((2) <<= 16) > > > + > > > struct sun8i_mixer; > > > > > > struct sun8i_ui_layer { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index=20 662ba1018cc4..6581fc7d9668 > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > > @@ -52,21 +52,38 @@ static void sun8i_vi_layer_enable(struct sun8i_mi= xer > > > *mixer, int channel, } > > > > > > static void sun8i_vi_layer_update_alpha(struct sun8i_mixer *mixer, i= nt > > > channel, - int overlay, struct > > drm_plane *plane) > > > + int overlay, struct > > drm_plane *plane, > > > + unsigned int zpos, > > bool force_premulti) > > > { > > > - u32 mask, val, ch_base; > > > + u32 mask, val, ch_base, bld_base; > > > + bool in_premulti =3D false, out_premulti =3D false; > > > > > > ch_base =3D sun8i_channel_base(mixer, channel); > > > + bld_base =3D sun8i_blender_base(mixer); > > > > > > if (mixer->cfg->is_de3) { > > > + in_premulti =3D plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PREMULTI; > > > + out_premulti =3D force_premulti || in_premulti; > > > + > > > mask =3D SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MASK | > > > - SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_MASK; > > > + SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_MASK > > | > > > + SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_MASK; > > > val =3D SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA > > > (plane->state->alpha >> 8); > > > > > > - val |=3D (plane->state->alpha =3D=3D DRM_BLEND_ALPHA_OP= AQUE) > > ? > > > - > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > - > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + if (plane->state->pixel_blend_mode =3D=3D > > DRM_MODE_BLEND_PIXEL_NONE) { > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_LAYER; > > > + } else { > > > + val |=3D (plane->state->alpha =3D=3D > > DRM_BLEND_ALPHA_OPAQUE) ? > > > + > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL : > > > + > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED; > > > + > > > + if (in_premulti) > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_PREMULTI; > > > + } > > > + > > > + if (!in_premulti && out_premulti) > > > + val |=3D > > SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COV2PREM; > > > > > > regmap_update_bits(mixer->engine.regs, > > > > > SUN8I_MIXER_CHAN_VI_LAYER_ATTR(ch_base, > > > @@ -79,6 +96,11 @@ static void sun8i_vi_layer_update_alpha(struct > > > sun8i_mixer *mixer, int channel, SUN8I_MIXER_FCC_GLOBAL_ALPHA > > > (plane->state->alpha > > >> 8)); > > > } > > > + > > > + regmap_update_bits( > > > + mixer->engine.regs, > > SUN8I_MIXER_BLEND_PREMULTIPLY(bld_base), > > > + SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos), > > > + out_premulti ? SUN8I_MIXER_BLEND_PREMULTIPLY_EN(zpos) : > > 0); > > > > Shouldn't be above block inside DE3 if block? >=20 > No, we have to update the value to non-premulti in case it was set to > premulti by another layer. >=20 >=20 > Regards, > Roman. >=20 > > > > Looks good otherwise. > > > > Best regards, > > Jernej > > > > > } > > > > > > static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int > > > channel, @@ -408,7 +430,7 @@ static void > > > sun8i_vi_layer_atomic_update(struct drm_plane *plane, > > > sun8i_vi_layer_update_coord(mixer, layer->channel, > > > layer->overlay, plane, zpos); > > > sun8i_vi_layer_update_alpha(mixer, layer->channel, > > > - layer->overlay, plane); > > > + layer->overlay, plane, zpos, > > false); > > > sun8i_vi_layer_update_formats(mixer, layer->channel, > > > layer->overlay, plane); > > > sun8i_vi_layer_update_buffer(mixer, layer->channel, > > > @@ -563,6 +585,19 @@ struct sun8i_vi_layer=20 *sun8i_vi_layer_init_one(struct > > > drm_device *drm, } > > > } > > > > > > + if (mixer->cfg->is_de3) { > > > + unsigned int blend_modes =3D BIT(DRM_MODE_BLEND_PREMULT= I) > > | > > > + > > BIT(DRM_MODE_BLEND_COVERAGE) | > > > + > > BIT(DRM_MODE_BLEND_PIXEL_NONE); > > > + > > > + ret =3D drm_plane_create_blend_mode_property(&layer- > > >plane, > > > + > > blend_modes); > > > + if (ret) { > > > + dev_err(drm->dev, "Couldn't add blend mode > > property\n"); > > > + return ERR_PTR(ret); > > > + } > > > + } > > > + > > > ret =3D drm_plane_create_zpos_property(&layer->plane, index, > > > 0, plane_cnt - > > 1); > > > if (ret) { > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.h index=20 9939a4cc7a52..ccf91f09f1fe > > > 100644 > > > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.h > > > @@ -44,6 +44,11 @@ > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MASK GENMASK(31, 24) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA(x) ((x) << 24) > > > > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_MASK GENMASK(17, 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COVERAGE ((0) <<= 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_COV2PREM ((1) <<= 16) > > > +#define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_BLEND_PREMULTI ((2) <<= 16) > > > + > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_PIXEL ((0) << > > 1) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_LAYER ((1) << > > 1) > > > #define SUN50I_MIXER_CHAN_VI_LAYER_ATTR_ALPHA_MODE_COMBINED ((2) <<= 1) > > > > > > > > >=20