From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?P=E9ter?= Ujfalusi Subject: Re: Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains Date: Wed, 21 Sep 2011 12:22:26 +0300 Message-ID: <2240573.6cRWXtKJB6@barack> References: <1316090379-30760-1-git-send-email-peter.ujfalusi@ti.com> <2033664.fWQvF2IA53@barack> <20110919114031.GI23727@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110919114031.GI23727@opensource.wolfsonmicro.com> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Samuel Ortiz , Dmitry Torokhov , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Misael Lopez Cruz List-Id: alsa-devel@alsa-project.org On Monday 19 September 2011 12:40:32 Mark Brown wrote: > On Mon, Sep 19, 2011 at 02:26:31PM +0300, P=E9ter Ujfalusi wrote: > > Here in twl6040 we also have event handlers to do the ramp up/down = on > > the > > gains. AFAIK some wm* codec have similar code. >=20 > WM8350. The implementation in twl6040 looks similar to the one in the wm8350 in= =20 regards to the ramp code, and caching of the user configured gains. If you take a look at the wm8350 driver it is also changing the L/R OUT= 1/2=20 registers at probe time. I don't see any difference in the two. Also it seams that wm8350 has the same problem: The default after the reset is 0x39 (0 dB) In the wm8350 probe it is changed to 0x00 (-57dB) The twl6040 already had the ramp up, and down code, but it was missing = the=20 initialization part (IOW configuring the lowest gain on the outputs aft= er=20 first power on). We do have other scenarios covered, but this initialization was missing= =2E This=20 resulted that the _first_ playback has pop noise, but all subsequent pl= aybacks=20 were fine, since we had the runtime fix for this. -- P=E9ter