From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes Date: Tue, 26 Nov 2013 01:32:07 +0100 Message-ID: <2242006.0l244SkK9j@flatron> References: <1384881034-10520-1-git-send-email-t.figa@samsung.com> <7242109.um7KlGhuI2@amdc1227> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mail-bk0-f50.google.com ([209.85.214.50]:44768 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609Ab3KZAcK (ORCPT ); Mon, 25 Nov 2013 19:32:10 -0500 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Tomasz Figa , "devicetree@vger.kernel.org" , linux-samsung-soc , Heiko =?ISO-8859-1?Q?St=FCbner?= , Stephen Warren , Doug Anderson , "linux-kernel@vger.kernel.org" , Kyungmin Park , Kukjin Kim , Thomas Abraham , Marek Szyprowski On Monday 25 of November 2013 15:46:12 Linus Walleij wrote: > On Wed, Nov 20, 2013 at 3:00 PM, Tomasz Figa wrote: > > Stephen: > >> Is the lifetime of the string "returned" by > >> of_property_read_string_index() really so short that you must copy the > >> string? I'd be tempted just to store the pointer, although perhaps you > >> need to get() the node so that's safe. > > > > Right. I have done it the copy-less way in other places, but missed this > > one. Thanks. > > So I guess I'm waiting for a new version of this patch, right? Right. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Tue, 26 Nov 2013 01:32:07 +0100 Subject: [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes In-Reply-To: References: <1384881034-10520-1-git-send-email-t.figa@samsung.com> <7242109.um7KlGhuI2@amdc1227> Message-ID: <2242006.0l244SkK9j@flatron> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 25 of November 2013 15:46:12 Linus Walleij wrote: > On Wed, Nov 20, 2013 at 3:00 PM, Tomasz Figa wrote: > > Stephen: > >> Is the lifetime of the string "returned" by > >> of_property_read_string_index() really so short that you must copy the > >> string? I'd be tempted just to store the pointer, although perhaps you > >> need to get() the node so that's safe. > > > > Right. I have done it the copy-less way in other places, but missed this > > one. Thanks. > > So I guess I'm waiting for a new version of this patch, right? Right. Best regards, Tomasz