From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/5] drm/cma-helper: Stop using drm_framebuffer_unregister_private
Date: Thu, 12 Jan 2017 12:00:38 +0200 [thread overview]
Message-ID: <2244308.HBH1rW6joL@avalon> (raw)
In-Reply-To: <1482835765-12044-2-git-send-email-daniel.vetter@ffwll.ch>
Hi Daniel,
Thank you for the patch.
On Tuesday 27 Dec 2016 11:49:22 Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But cma helpers are using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index 591f30ebc42a..769a3b3236ee
> 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -485,8 +485,7 @@ int drm_fbdev_cma_create_with_funcs(struct drm_fb_helper
> *helper, return 0;
>
> err_cma_destroy:
> - drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
> - drm_fb_cma_destroy(&fbdev_cma->fb->fb);
> + drm_framebuffer_remove(&fbdev_cma->fb->fb);
> err_fb_info_destroy:
> drm_fb_helper_release_fbi(helper);
> err_gem_free_object:
> @@ -592,10 +591,8 @@ void drm_fbdev_cma_fini(struct drm_fbdev_cma
> *fbdev_cma) drm_fbdev_cma_defio_fini(fbdev_cma->fb_helper.fbdev);
> drm_fb_helper_release_fbi(&fbdev_cma->fb_helper);
>
> - if (fbdev_cma->fb) {
> - drm_framebuffer_unregister_private(&fbdev_cma->fb->fb);
> - drm_fb_cma_destroy(&fbdev_cma->fb->fb);
> - }
> + if (fbdev_cma->fb)
> + drm_framebuffer_remove(&fbdev_cma->fb->fb);
>
> drm_fb_helper_fini(&fbdev_cma->fb_helper);
> kfree(fbdev_cma);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-12 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
2017-01-12 10:00 ` Laurent Pinchart [this message]
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
2017-01-12 8:21 ` Inki Dae
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
2017-01-12 9:56 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 10:15 ` Archit Taneja
2017-01-12 14:37 ` Thierry Reding
2017-01-12 9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2244308.HBH1rW6joL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.