From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@amd.com>, Ori Kam <orika@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Kiran Kumar K <kirankumark@marvell.com>, dev@dpdk.org
Subject: Re: [PATCH] ethdev: fix Tx queue mask endianness
Date: Thu, 29 Jun 2023 17:42:19 +0200 [thread overview]
Message-ID: <2246452.o7ts2hSHzF@thomas> (raw)
In-Reply-To: <CAJFAV8yVD0zR+DOuZKVqx2L4SKWxtEO_4m2o=vThQVEHYobmvQ@mail.gmail.com>
29/06/2023 17:40, David Marchand:
> On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 29/06/2023 15:58, David Marchand:
> > > - .tx_queue = RTE_BE16(0xffff),
> > > + .tx_queue = 0xffff,
> >
> > As I said in an earlier comment about the same issue,
> > UINT16_MAX would be better.
>
> I don't mind updating (or maybe Ferruh can squash this directly ?) but
> there are lots of uint16_t fields initialised with 0xffff in this same
> file.
It can be made in a separate patch for all occurences.
First I would like to get some comments, what do you prefer
between 0xffff and UINT16_MAX?
next prev parent reply other threads:[~2023-06-29 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:58 [PATCH] ethdev: fix Tx queue mask endianness David Marchand
2023-06-29 14:48 ` Ferruh Yigit
2023-06-29 15:31 ` Thomas Monjalon
2023-06-29 15:40 ` David Marchand
2023-06-29 15:42 ` Thomas Monjalon [this message]
2023-06-29 16:14 ` Ferruh Yigit
2023-06-30 7:00 ` David Marchand
2023-06-30 7:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2246452.o7ts2hSHzF@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kirankumark@marvell.com \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.