From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:41840 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932253AbcHKPg6 (ORCPT ); Thu, 11 Aug 2016 11:36:58 -0400 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , Linux-Renesas Subject: Re: [PATCH v2 4/4] arm64: dts: renesas: salvator-x: Enable DU Date: Thu, 11 Aug 2016 18:37:03 +0300 Message-ID: <2249176.5GrCTAfsB5@avalon> In-Reply-To: References: <1470745752-23738-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1470745752-23738-5-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Thursday 11 Aug 2016 11:17:17 Geert Uytterhoeven wrote: > On Tue, Aug 9, 2016 at 2:29 PM, Laurent Pinchart wrote: > > Only the VGA output is supported for now. > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Geert Uytterhoeven > > One question below, though... > > > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > > @@ -135,6 +135,50 @@ > > > > +&du { > > + status = "okay"; > > Don't you need pinctrl properties? Or are you relying on initial settings? > > GPSR initial settings for DU depend on MD[4:1] i.e. SW10[5:8]. > The defaults on my board are not 0000, so all DU pins are GPIOs? > IPSR initial settings don't seem to be documented. pinctrl configuration is needed, but isn't available yet in the sh-pfc driver. I guess I'll just have to bite the bullet and add it :-) -- Regards, Laurent Pinchart