From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Mark Hatle <mark.hatle@kernel.crashing.org>,
Jean-marie Lemetayer <jean-marie.lemetayer@savoirfairelinux.com>
Cc: Savoir-faire Linux Rennes <rennes@savoirfairelinux.com>,
bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [RFC][PATCH 2/2] fetch2/npm.py: refactor the npm fetcher
Date: Thu, 24 Oct 2019 09:12:02 +1300 [thread overview]
Message-ID: <2251883.mhDZDQ7Q5s@shodan> (raw)
In-Reply-To: <ead7c39d-6ac4-a469-b190-90f259433595@kernel.crashing.org>
On Thursday, 24 October 2019 3:27:11 AM NZDT Mark Hatle wrote:
> On 10/23/19 8:08 AM, Jean-marie Lemetayer wrote:
> > Thank you again. The former npm support does not have any tests so I did not
> > think about it. I will add some basic tests in the v2.
>
> If you need some pointers on where and how to write the tests, please let me
> know. I've had to write a number of them for the gitsm fetcher.
>
> Hint: https://git.openembedded.org/bitbake/tree/lib/bb/tests/fetch.py
>
> Stuff I added is mostly found by looking for 'test_git_submodule...'
>
> I'd expect we need a new test_npm_.... series.
Right, but if the functionality now relies on code in OE, then to fully test it you'd need to add oe-selftest tests in OE as well.
Cheers,
Paul
--
Paul Eggleton
Intel System Software Products
next prev parent reply other threads:[~2019-10-23 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 9:04 [RFC][PATCH 0/2] NPM refactoring Jean-Marie LEMETAYER
2019-10-22 9:04 ` [RFC][PATCH 1/2] bitbake: utils.py: add sha384_file and sha512_file Jean-Marie LEMETAYER
2019-10-22 9:04 ` [RFC][PATCH 2/2] fetch2/npm.py: refactor the npm fetcher Jean-Marie LEMETAYER
2019-10-22 17:10 ` Mark Hatle
2019-10-23 13:07 ` Jean-marie Lemetayer
2019-10-23 13:07 ` Jean-marie Lemetayer
2019-10-23 13:08 ` Jean-marie Lemetayer
2019-10-23 14:27 ` Mark Hatle
2019-10-23 20:12 ` Paul Eggleton [this message]
2019-10-23 20:16 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2251883.mhDZDQ7Q5s@shodan \
--to=paul.eggleton@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=jean-marie.lemetayer@savoirfairelinux.com \
--cc=mark.hatle@kernel.crashing.org \
--cc=rennes@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.