From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1muhaV-0000Uh-CJ for mharc-grub-devel@gnu.org; Tue, 07 Dec 2021 16:01:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muhaT-0000Sj-9n for grub-devel@gnu.org; Tue, 07 Dec 2021 16:01:21 -0500 Received: from mout.gmx.net ([212.227.15.15]:49669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muhaR-0008Di-Cm for grub-devel@gnu.org; Tue, 07 Dec 2021 16:01:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638910876; bh=9SWYCj8VtIYKTZABySyEct7Z2I5zyG1bAOM/fMhkAFY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=NFulN/MOdTD+CeGTMQSUTbELO2rYskA984E0jxMlvoShDjay5aWjNQBQdx8B9qP3F dAtnXaqyMFZ7xOvLrEdM/ZuCNgjO8O4xq5Bd1MY50+inzrw6AGkaNrykLd5zZMkuln JNd9btmH0YBcox4nDkMmJnVgY50QzqURjeNhc1os= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.23] ([79.195.95.75]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4s0j-1msmJI4BGR-0021fT; Tue, 07 Dec 2021 22:01:16 +0100 Message-ID: <22537d2d-ce09-2d01-400a-1f86f1debfac@gmx.de> Date: Tue, 7 Dec 2021 22:01:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2] misc: Allow selective disabling of debug facility names Content-Language: de-DE To: development@efficientek.com Cc: Daniel Kiper , grub-devel@gnu.org References: <20211206170312.811318-1-development@efficientek.com> <9af6034e-e8f4-5fbf-babf-fa4cd9988695@gmx.de> <20211207031742.17bd0474@crass-HP-ZBook-15-G2> From: Michael Schierl In-Reply-To: <20211207031742.17bd0474@crass-HP-ZBook-15-G2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Pk4zKu+cMK0Ge21SnLfQxkDyRQb9oFO8FL8dO3+qHaJrT8TBwER m1WA6r2RStVk2gb5yhHO3JStidQeuS1k46vJ2/AoDCDLRAj3ccF/tAhNKXBQaT+Nz2hVXOa E9Stl0CkGFmsi/0ihnt2v/6KmUYUOk5QCJzUIgh+UFXMVLQfIi1rmOr60CLkhNJgM7erC43 pZcyt2FfdKPWGV66eIKqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:gnh2eGj0L1c=:YhSJHkMU4+EKBx7Ia/nRXi kx0XApJahNfe7NfZTk5PKN+ebIyNRElVTU5Jj2L91by7TcQL0t9GYLliNUKLt0cuSECKiE638 4qUofQDFi0/0F/YY4KKARUIxHOiHdpWsSad9kkjMhtpjMrkDT2Y11JzsZiKUgihFDw9b/CW5/ GTTgG9nBYkcBQAvWFVRCe4MMixKxtIxT0Jab1igfjfEHJ3spFGPDEqTgjrYmr4OAjxta5AJfs PZaecUAoc9IBB+CrpCvmsPxyy7qWGHQX6nbHsdBmNNreMDVMI6robYDn5VPS3tZFhlRnStaiz cLa0CwJ5iaxeTBMHDPenm/TvirobD+vcZUKNs4JTQatBEBotTsXyBg3vRh0PJOq54y6aVdZrp R62hHWJLjal4gib5vhSFlu1PNiawmV8D8yigWTc3qGVQLM0pXZFFaXrZGc053MNL6zwxIGwgS tBbP9d1Mc+5yDCk+jD84ZCyAl9HyWujgqGVtB+uslKmq++Ybrt0spVnD9IU1Q8FEYsMBaD4CV YxJaO/BFp3MF0I8tsFh9XDO0jrl1x/B7KWHgl2MBavz6NRfiuRTay/qAoWF3As6kZiByQpOO3 cMfpmyx/9yecZkfW91Gv121Dy4kQ6OyX0AJ9ingUccCfGm1mVeHUTIdCkg74trcO6hsXL0Wo/ GeC0UfM5NYePFI/RD4TtYZuZ0HuzrOdGsjiqqngJTOluzl88NwM2OzmggZq2gyY6jF+hrZ5Wd OEj2JFB+ob4tSkS+QmEamaF3oDAs0qkjKWEVV5RhezOzbXX/Lbsn5JdbtccarwHyEAwP1iaDM h79+eqgeCv8aepR779csCEaJ9CNWJLaerOA3W346YpboT03NQyHJE+MHZG5AjjzN828dhjSMW zRFv1ghQOgOqM31GV+rGPpwYbVnpvuoYLVIfA2n0+uKdWSpkIveLc9pqBMSeRbsP2HKPpogrQ 2yPkAmvcfucQ946cbsJz3q2IEeTaunoOfv5cNiILvBaF2BelQR74HZ9DVHmGqMtiS0e7XwCAt FbDzFdrnwUfcpNn8JUtkihbqDPDxuYlg47V4u1LHFh/kTztoLUVhm4HbFVgBgkPLcrAuKUzJq jlGK7amgoeLFxg= Received-SPF: pass client-ip=212.227.15.15; envelope-from=schierlm@gmx.de; helo=mout.gmx.net X-Spam_score_int: -49 X-Spam_score: -5.0 X-Spam_bar: ----- X-Spam_report: (-5.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-2.44, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 21:01:21 -0000 Hello Glenn, Am 07.12.2021 um 10:17 schrieb Glenn Washburn: >> maybe move the conditional before the assignment of ret? > > I'm understanding you to be suggesting to move the assignment of ret to > after the if statement that follows it. Correct. > The only point I see is saving > an assignment in the case that debug=3Dall. Is there more to it? No. It just bugged me to do a definitely never used assignment directly before returning. Feel free to ignore it. > Yep, this is an issue. It was intentional when I had the code only > running in the case "all" was present, in which case skipping the > condition if its the at the start of $debug is fine because the > condition is already enabled. After changing to run also without "all" > being present, this becomes an issue. If "all" still was present I would probably have complained about initializing it to +1 instead of +3 as the first three characters cannot be a match if they are "all". :) > I was using grub_iswordseparator in the original patch, but decided > against it this round because the documentation states that separators > are whitespace or comma. Fair point. I don't think there are any common cases where this backward-incompatible change really matters. Regards, Michael