From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] sched: fix build on Atom without SSE4 support
Date: Sun, 06 Dec 2015 00:47:07 +0100
Message-ID: <2253941.LkXn5DGchi@xps13>
References: <1449354476-8275-1-git-send-email-msowka@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Mike Sowka <msowka@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 831909215
 for <dev@dpdk.org>; Sun,  6 Dec 2015 00:48:19 +0100 (CET)
Received: by wmec201 with SMTP id c201so108251452wme.1
 for <dev@dpdk.org>; Sat, 05 Dec 2015 15:48:19 -0800 (PST)
In-Reply-To: <1449354476-8275-1-git-send-email-msowka@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-05 17:27, Mike Sowka:
> Thanks for the pointers Thomas. Here is a signed-off patch
> re-submission with some explanation, to the best of my experience.

Thanks, it is really well detailed.
It would have been perfect with -v2 --in-reply-to :)

> Irrelevant of the target, the preprocessor #ifdef SSE2 for the
> grinder_pipe_exists function is inadequate since the __mm_testz_si128=

> function requires SSE4.1, PTEST instruction described in
> https://en.wikipedia.org/wiki/SSE4#SSE4.1 (I do no have better spec
> reference). I have bumped the preprocessor #ifdef to require SSE4.
>=20
> The Atom N2600 does not have SSE4, http://ark.intel.com/products/5891=
6,
> and so I had trouble building rte_sched with optimized version of
> grinder_pipe_exists, with following:
> error: inlining failed in call to always_inline _mm_testz_si128=E2=80=
=99:
>        target specific option mismatch
>=20
> GCC 4.9 correctly identifies my target as not having SSE4, and with
> provided patch builds the non-optimized version of grinder_pipe_exist=
s.
>=20
>=20
> Signed-off-by: Mike Sowka <msowka@gmail.com>

Applied, thanks