Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations out of lock

["Heiko Stübner" <heiko@sntech.de>]

Am Sonntag, 3. März 2024, 13:14:10 CET schrieb Andy Shevchenko:
> There is no need to calculate masks under the lock taken.
> Move them out of it.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/clk/clk-fractional-divider.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c
> index a0178182fc72..da057172cc90 100644
> --- a/drivers/clk/clk-fractional-divider.c
> +++ b/drivers/clk/clk-fractional-divider.c
> @@ -195,14 +195,14 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate,
>  		n--;
>  	}
>  
> +	mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> +	nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> +
>  	if (fd->lock)
>  		spin_lock_irqsave(fd->lock, flags);
>  	else
>  		__acquire(fd->lock);
>  
> -	mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> -	nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> -
>  	val = clk_fd_readl(fd);
>  	val &= ~(mmask | nmask);
>  	val |= (m << fd->mshift) | (n << fd->nshift);
>