From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic Date: Wed, 24 Jan 2018 19:08:02 +0100 Message-ID: <2260225.RPhyHJgTVH@xps> References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> <1516803133-17529-1-git-send-email-ophirmu@mellanox.com> <20180124073915.753a4764@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, Ophir Munk , dev@dpdk.org, Olga Shern , Adrien Mazarguil To: Stephen Hemminger , Matan Azrad Return-path: In-Reply-To: <20180124073915.753a4764@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/01/2018 16:39, Stephen Hemminger: > On Wed, 24 Jan 2018 14:12:13 +0000 > Ophir Munk wrote: > > --- a/drivers/net/vdev_netvsc/Makefile > > +++ b/drivers/net/vdev_netvsc/Makefile > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > > # Additional compilation flags. > > CFLAGS += -O3 > > CFLAGS += -g > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra > > +CFLAGS += -Wall -Wextra > > CFLAGS += -D_XOPEN_SOURCE=600 > > CFLAGS += -D_BSD_SOURCE > > CFLAGS += -D_DEFAULT_SOURCE > > Why did this driver not use $(WERROR) like rest of DPDK drivers. It can be a separate patch. Matan?