All of lore.kernel.org
 help / color / mirror / Atom feed
From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/cpio: add host version
Date: Sun, 14 Jul 2019 18:16:33 +0530	[thread overview]
Message-ID: <2262480.0uGyQ1EtkW@msi-manjaro> (raw)
In-Reply-To: <20190714123859.GA8912@scaer>

On Sunday, July 14, 2019 6:08:59 PM IST Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2019-07-14 14:19 +0200, Arnout Vandecappelle spake thusly:
> > On 14/07/2019 11:03, Yann E. MORIN wrote:
> > > The latest cpio has a --reproducible option, which may come handy when
> > > we try to, well, be reproducible...
> > > 
> > > Reported-by: Arnout Vandecappelle <arnout@mind.be>
> > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > > Cc: Arnout Vandecappelle <arnout@mind.be>
> > > Cc: Atharva Lele <itsatharva@gmail.com>
> > > ---
> > > 
> > >  package/cpio/cpio.mk | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/package/cpio/cpio.mk b/package/cpio/cpio.mk
> > > index 9a09279572..d2814b87a5 100644
> > > --- a/package/cpio/cpio.mk
> > > +++ b/package/cpio/cpio.mk
> > > @@ -16,4 +16,7 @@ ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> > > 
> > >  CPIO_DEPENDENCIES += argp-standalone
> > >  endif
> > > 
> > > +HOST_CPIO_CONF_OPTS = --bindir=$(HOST_DIR)/bin
> >  
> >  Why is this needed? For target it is needed because --prefix is set to
> >  /usr so> 
> > it would end up in /usr/bin and we want it in /bin. But for hsot, --prefix
> > is $(HOST_DIR).
> 
> You know what? That is exactly what I think, too. ;-)
> 
> I just did a quick hack locally to test the build time of cpio, and did
> not try to think further, so I stupidly copied the target variant as-is
> without thinking too much.
> 
> Then I saw it worked, got the required timings from a batch of 5 runs,
> finished my reply to Atharva's fs/cpio patch, and decided to send this
> patch too, without realising that it needed a bit more love.
> 
> Atharva, when you respin your fs/cpio patch, can you grab this one in
> your tree and fix it as Arnout pointed out?

I will :)

> Regards,
> Yann E. MORIN.
> 
> >  Regards,
> >  Arnout
> >  
> > > +
> > > 
> > >  $(eval $(autotools-package))
> > > 
> > > +$(eval $(host-autotools-package))

Regards,
Atharva Lele

      reply	other threads:[~2019-07-14 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14  9:03 [Buildroot] [PATCH] package/cpio: add host version Yann E. MORIN
2019-07-14 12:19 ` Arnout Vandecappelle
2019-07-14 12:38   ` Yann E. MORIN
2019-07-14 12:46     ` Atharva Lele [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2262480.0uGyQ1EtkW@msi-manjaro \
    --to=itsatharva@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.