From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] vdev: free reply.msgs memory for secondary
	process
Date: Thu, 25 Oct 2018 09:28:13 +0200
Message-ID: <2263294.kZzMS7uBjY@xps>
References: <20180921162557.48249-1-paul.e.luse@intel.com>
 <ae10c7df-bfe2-9525-f6b7-19a4a81b3789@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Paul Luse <paul.e.luse@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 40FFA4C95
 for <dev@dpdk.org>; Thu, 25 Oct 2018 09:28:16 +0200 (CEST)
In-Reply-To: <ae10c7df-bfe2-9525-f6b7-19a4a81b3789@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/09/2018 15:28, Ferruh Yigit:
> On 9/21/2018 5:25 PM, Paul Luse wrote:
> > From: paul luse <paul.e.luse@intel.com>
> > 
> > This patch fixes an issue caught with ASAN where a vdev_scan()
> > to a secondary bus was failing to free some memory.
> > 
> > Signed-off-by: paul luse <paul.e.luse@intel.com>
> 
> (carry from Anatoly's ack from other thread)
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Adding Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
Cc: stable@dpdk.org

> @Anatoly, what do you think about:
>  diff --git a/lib/librte_eal/common/include/rte_eal.h
> b/lib/librte_eal/common/include/rte_eal.h
>  index e114dcbdc..e1a554f5a 100644
>  --- a/lib/librte_eal/common/include/rte_eal.h
>  +++ b/lib/librte_eal/common/include/rte_eal.h
>  @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg);
>    * This function sends a request message to the peer process, and will
>    * block until receiving reply message from the peer process.
>    *
>  - * @note The caller is responsible to free reply->replies.
>  + * @note The caller is responsible to free reply->msgs.
>    *
>    * @param req
>    *   The req argument contains the customized request message.

Adding this change to the commit.

Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")

All applied, thanks