From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 03 Feb 2015 10:45:47 +0000 Subject: Re: [PATCH] drm: Kconfig: Let all DRM_GEM_CMA_HELPER related macros depend on HAVE_DMA_ATTRS Message-Id: <2264372.TXY4G2KdxT@avalon> List-Id: References: <54CE3361.9090107@sunrus.com.cn> In-Reply-To: <54CE3361.9090107@sunrus.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chen Gang S Cc: linux-sh@vger.kernel.org, jg1.han@samsung.com, nicolas.ferre@atmel.com, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, jcmvbkbc@gmail.com, benjamin.gaignard@linaro.org, chris@zankel.net Hi Chen, Thank you for the patch. On Sunday 01 February 2015 22:08:33 Chen Gang S wrote: > DRM_GEM_CMA_HELPER is depend on HAVE_DMA_ATTRS, or it will break the > building. The related error (with allmodconfig under xtensa): > > CC [M] drivers/gpu/drm/drm_gem_cma_helper.o > drivers/gpu/drm/drm_gem_cma_helper.c: In function 'drm_gem_cma_create': > drivers/gpu/drm/drm_gem_cma_helper.c:110:19: error: implicit declaration > of function 'dma_alloc_writecombine' > [-Werror=implicit-function-declaration] cma_obj->vaddr > dma_alloc_writecombine(drm->dev, size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c:110:17: warning: assignment makes > pointer from integer without a cast [-Wint-conversion] cma_obj->vaddr > dma_alloc_writecombine(drm->dev, size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c: In function > 'drm_gem_cma_free_object': drivers/gpu/drm/drm_gem_cma_helper.c:193:3: > error: implicit declaration of function 'dma_free_writecombine' > [-Werror=implicit-function-declaration] > dma_free_writecombine(gem_obj->dev->dev, cma_obj->base.size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c: In function 'drm_gem_cma_mmap_obj': > drivers/gpu/drm/drm_gem_cma_helper.c:330:8: error: implicit declaration of > function 'dma_mmap_writecombine' [-Werror=implicit-function-declaration] > ret = dma_mmap_writecombine(cma_obj->base.dev->dev, vma, > ^ > > Signed-off-by: Chen Gang > --- > drivers/gpu/drm/Kconfig | 3 ++- > drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +- > drivers/gpu/drm/imx/Kconfig | 2 +- > drivers/gpu/drm/rcar-du/Kconfig | 2 +- > drivers/gpu/drm/shmobile/Kconfig | 2 +- > drivers/gpu/drm/sti/Kconfig | 2 +- > drivers/gpu/drm/tilcdc/Kconfig | 2 +- > 7 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 308c104..151a050 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -62,12 +62,13 @@ config DRM_TTM > > config DRM_GEM_CMA_HELPER > bool > - depends on DRM > + depends on DRM && HAVE_DMA_ATTRS > help > Choose this if you need the GEM CMA helper functions > > config DRM_KMS_CMA_HELPER > bool > + depends on DRM && HAVE_DMA_ATTRS > select DRM_GEM_CMA_HELPER > select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig > b/drivers/gpu/drm/atmel-hlcdc/Kconfig index 1a08562..219fc87 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig > @@ -1,6 +1,6 @@ > config DRM_ATMEL_HLCDC > tristate "DRM Support for ATMEL HLCDC Display Controller" > - depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC > + depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && HAVE_DMA_ATTRS I don't like having to add the explicit dependency to all users of DRM_GEM_CMA_HELPER and DRM_KMS_CMA_HELPER, but there's no way around this given the select vs. depends issues in Kconfig. A better solution in the longer term would be to implement HAVE_DMA_ATTRS support for xtensa (and all the other architectures that miss it), but this patch looks fine to me as an interim solution. Acked-by: Laurent Pinchart > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig > index 5d5e4092..33cdddf 100644 > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -5,7 +5,7 @@ config DRM_IMX > select VIDEOMODE_HELPERS > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > - depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) > + depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) && HAVE_DMA_ATTRS > depends on IMX_IPUV3_CORE > help > enable i.MX graphics support > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > b/drivers/gpu/drm/rcar-du/Kconfig index 2324a52..11485a4 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -1,6 +1,6 @@ > config DRM_RCAR_DU > tristate "DRM Support for R-Car Display Unit" > - depends on DRM && ARM > + depends on DRM && ARM && HAVE_DMA_ATTRS > depends on ARCH_SHMOBILE || COMPILE_TEST > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > diff --git a/drivers/gpu/drm/shmobile/Kconfig > b/drivers/gpu/drm/shmobile/Kconfig index a50fe0e..7321c41 100644 > --- a/drivers/gpu/drm/shmobile/Kconfig > +++ b/drivers/gpu/drm/shmobile/Kconfig > @@ -1,6 +1,6 @@ > config DRM_SHMOBILE > tristate "DRM Support for SH Mobile" > - depends on DRM && ARM > + depends on DRM && ARM && HAVE_DMA_ATTRS > depends on ARCH_SHMOBILE || COMPILE_TEST > select BACKLIGHT_CLASS_DEVICE > select DRM_KMS_HELPER > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > index d6d6b70..1fdb74b 100644 > --- a/drivers/gpu/drm/sti/Kconfig > +++ b/drivers/gpu/drm/sti/Kconfig > @@ -1,6 +1,6 @@ > config DRM_STI > tristate "DRM Support for STMicroelectronics SoC stiH41x Series" > - depends on DRM && (SOC_STIH415 || SOC_STIH416 || ARCH_MULTIPLATFORM) > + depends on DRM && (SOC_STIH415 || SOC_STIH416 || ARCH_MULTIPLATFORM) && > HAVE_DMA_ATTRS select RESET_CONTROLLER > select DRM_KMS_HELPER > select DRM_GEM_CMA_HELPER > diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig > index 7c3ef79..8394a0b 100644 > --- a/drivers/gpu/drm/tilcdc/Kconfig > +++ b/drivers/gpu/drm/tilcdc/Kconfig > @@ -1,6 +1,6 @@ > config DRM_TILCDC > tristate "DRM Support for TI LCDC Display Controller" > - depends on DRM && OF && ARM > + depends on DRM && OF && ARM && HAVE_DMA_ATTRS > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > select DRM_KMS_CMA_HELPER -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: Kconfig: Let all DRM_GEM_CMA_HELPER related macros depend on HAVE_DMA_ATTRS Date: Tue, 03 Feb 2015 12:45:47 +0200 Message-ID: <2264372.TXY4G2KdxT@avalon> References: <54CE3361.9090107@sunrus.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTP id 74EB96E441 for ; Tue, 3 Feb 2015 02:45:05 -0800 (PST) In-Reply-To: <54CE3361.9090107@sunrus.com.cn> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen Gang S Cc: linux-sh@vger.kernel.org, jg1.han@samsung.com, nicolas.ferre@atmel.com, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, jcmvbkbc@gmail.com, benjamin.gaignard@linaro.org, chris@zankel.net List-Id: dri-devel@lists.freedesktop.org SGkgQ2hlbiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gU3VuZGF5IDAxIEZlYnJ1YXJ5 IDIwMTUgMjI6MDg6MzMgQ2hlbiBHYW5nIFMgd3JvdGU6Cj4gRFJNX0dFTV9DTUFfSEVMUEVSIGlz IGRlcGVuZCBvbiBIQVZFX0RNQV9BVFRSUywgb3IgaXQgd2lsbCBicmVhayB0aGUKPiBidWlsZGlu Zy4gVGhlIHJlbGF0ZWQgZXJyb3IgKHdpdGggYWxsbW9kY29uZmlnIHVuZGVyIHh0ZW5zYSk6Cj4g Cj4gICAgIENDIFtNXSAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fY21hX2hlbHBlci5vCj4gICBk cml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9jbWFfaGVscGVyLmM6IEluIGZ1bmN0aW9uICdkcm1fZ2Vt X2NtYV9jcmVhdGUnOgo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fY21hX2hlbHBlci5jOjEx MDoxOTogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uCj4gb2YgZnVuY3Rpb24gJ2RtYV9hbGxv Y193cml0ZWNvbWJpbmUnCj4gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25d IGNtYV9vYmotPnZhZGRyID0KPiBkbWFfYWxsb2Nfd3JpdGVjb21iaW5lKGRybS0+ZGV2LCBzaXpl LAo+ICAgICAgICAgICAgICAgICAgICAgIF4KPiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2Nt YV9oZWxwZXIuYzoxMTA6MTc6IHdhcm5pbmc6IGFzc2lnbm1lbnQgbWFrZXMKPiBwb2ludGVyIGZy b20gaW50ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdpbnQtY29udmVyc2lvbl0gY21hX29iai0+dmFk ZHIgPQo+IGRtYV9hbGxvY193cml0ZWNvbWJpbmUoZHJtLT5kZXYsIHNpemUsCj4gICAgICAgICAg ICAgICAgICAgIF4KPiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2NtYV9oZWxwZXIuYzogSW4g ZnVuY3Rpb24KPiAnZHJtX2dlbV9jbWFfZnJlZV9vYmplY3QnOiBkcml2ZXJzL2dwdS9kcm0vZHJt X2dlbV9jbWFfaGVscGVyLmM6MTkzOjM6Cj4gZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9m IGZ1bmN0aW9uICdkbWFfZnJlZV93cml0ZWNvbWJpbmUnCj4gWy1XZXJyb3I9aW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCj4gZG1hX2ZyZWVfd3JpdGVjb21iaW5lKGdlbV9vYmotPmRldi0+ ZGV2LCBjbWFfb2JqLT5iYXNlLnNpemUsCj4gICAgICBeCj4gICBkcml2ZXJzL2dwdS9kcm0vZHJt X2dlbV9jbWFfaGVscGVyLmM6IEluIGZ1bmN0aW9uICdkcm1fZ2VtX2NtYV9tbWFwX29iaic6Cj4g ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9jbWFfaGVscGVyLmM6MzMwOjg6IGVycm9yOiBpbXBs aWNpdCBkZWNsYXJhdGlvbiBvZgo+IGZ1bmN0aW9uICdkbWFfbW1hcF93cml0ZWNvbWJpbmUnIFst V2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+IHJldCA9IGRtYV9tbWFwX3dy aXRlY29tYmluZShjbWFfb2JqLT5iYXNlLmRldi0+ZGV2LCB2bWEsCj4gICAgICAgICAgIF4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBDaGVuIEdhbmcgPGdhbmcuY2hlbi41aTVqQGdtYWlsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL0tjb25maWcgICAgICAgICAgICAgfCAzICsrLQo+ICBkcml2 ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvS2NvbmZpZyB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJt L2lteC9LY29uZmlnICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L0tj b25maWcgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvS2NvbmZpZyAgICB8 IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3N0aS9LY29uZmlnICAgICAgICAgfCAyICstCj4gIGRy aXZlcnMvZ3B1L2RybS90aWxjZGMvS2NvbmZpZyAgICAgIHwgMiArLQo+ICA3IGZpbGVzIGNoYW5n ZWQsIDggaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL0tjb25maWcgYi9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+IGluZGV4IDMw OGMxMDQuLjE1MWEwNTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL0tjb25maWcKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZwo+IEBAIC02MiwxMiArNjIsMTMgQEAgY29uZmln IERSTV9UVE0KPiAKPiAgY29uZmlnIERSTV9HRU1fQ01BX0hFTFBFUgo+ICAJYm9vbAo+IC0JZGVw ZW5kcyBvbiBEUk0KPiArCWRlcGVuZHMgb24gRFJNICYmIEhBVkVfRE1BX0FUVFJTCj4gIAloZWxw Cj4gIAkgIENob29zZSB0aGlzIGlmIHlvdSBuZWVkIHRoZSBHRU0gQ01BIGhlbHBlciBmdW5jdGlv bnMKPiAKPiAgY29uZmlnIERSTV9LTVNfQ01BX0hFTFBFUgo+ICAJYm9vbAo+ICsJZGVwZW5kcyBv biBEUk0gJiYgSEFWRV9ETUFfQVRUUlMKPiAgCXNlbGVjdCBEUk1fR0VNX0NNQV9IRUxQRVIKPiAg CXNlbGVjdCBEUk1fS01TX0ZCX0hFTFBFUgo+ICAJc2VsZWN0IEZCX1NZU19GSUxMUkVDVAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvS2NvbmZpZwo+IGIvZHJpdmVy cy9ncHUvZHJtL2F0bWVsLWhsY2RjL0tjb25maWcgaW5kZXggMWEwODU2Mi4uMjE5ZmM4NyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvS2NvbmZpZwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9LY29uZmlnCj4gQEAgLTEsNiArMSw2IEBACj4gIGNv bmZpZyBEUk1fQVRNRUxfSExDREMKPiAgCXRyaXN0YXRlICJEUk0gU3VwcG9ydCBmb3IgQVRNRUwg SExDREMgRGlzcGxheSBDb250cm9sbGVyIgo+IC0JZGVwZW5kcyBvbiBEUk0gJiYgT0YgJiYgQ09N TU9OX0NMSyAmJiBNRkRfQVRNRUxfSExDREMKPiArCWRlcGVuZHMgb24gRFJNICYmIE9GICYmIENP TU1PTl9DTEsgJiYgTUZEX0FUTUVMX0hMQ0RDICYmIEhBVkVfRE1BX0FUVFJTCgpJIGRvbid0IGxp a2UgaGF2aW5nIHRvIGFkZCB0aGUgZXhwbGljaXQgZGVwZW5kZW5jeSB0byBhbGwgdXNlcnMgb2Yg CkRSTV9HRU1fQ01BX0hFTFBFUiBhbmQgRFJNX0tNU19DTUFfSEVMUEVSLCBidXQgdGhlcmUncyBu byB3YXkgYXJvdW5kIHRoaXMgCmdpdmVuIHRoZSBzZWxlY3QgdnMuIGRlcGVuZHMgaXNzdWVzIGlu IEtjb25maWcuCgpBIGJldHRlciBzb2x1dGlvbiBpbiB0aGUgbG9uZ2VyIHRlcm0gd291bGQgYmUg dG8gaW1wbGVtZW50IEhBVkVfRE1BX0FUVFJTIApzdXBwb3J0IGZvciB4dGVuc2EgKGFuZCBhbGwg dGhlIG90aGVyIGFyY2hpdGVjdHVyZXMgdGhhdCBtaXNzIGl0KSwgYnV0IHRoaXMgCnBhdGNoIGxv b2tzIGZpbmUgdG8gbWUgYXMgYW4gaW50ZXJpbSBzb2x1dGlvbi4KCkFja2VkLWJ5OiBMYXVyZW50 IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+ICAJc2VsZWN0 IERSTV9HRU1fQ01BX0hFTFBFUgo+ICAJc2VsZWN0IERSTV9LTVNfSEVMUEVSCj4gIAlzZWxlY3Qg RFJNX0tNU19GQl9IRUxQRVIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2lteC9LY29u ZmlnIGIvZHJpdmVycy9ncHUvZHJtL2lteC9LY29uZmlnCj4gaW5kZXggNWQ1ZTQwOTIuLjMzY2Rk ZGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2lteC9LY29uZmlnCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2lteC9LY29uZmlnCj4gQEAgLTUsNyArNSw3IEBAIGNvbmZpZyBEUk1fSU1Y Cj4gIAlzZWxlY3QgVklERU9NT0RFX0hFTFBFUlMKPiAgCXNlbGVjdCBEUk1fR0VNX0NNQV9IRUxQ RVIKPiAgCXNlbGVjdCBEUk1fS01TX0NNQV9IRUxQRVIKPiAtCWRlcGVuZHMgb24gRFJNICYmIChB UkNIX01YQyB8fCBBUkNIX01VTFRJUExBVEZPUk0pCj4gKwlkZXBlbmRzIG9uIERSTSAmJiAoQVJD SF9NWEMgfHwgQVJDSF9NVUxUSVBMQVRGT1JNKSAmJiBIQVZFX0RNQV9BVFRSUwo+ICAJZGVwZW5k cyBvbiBJTVhfSVBVVjNfQ09SRQo+ICAJaGVscAo+ICAJICBlbmFibGUgaS5NWCBncmFwaGljcyBz dXBwb3J0Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L0tjb25maWcKPiBi L2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L0tjb25maWcgaW5kZXggMjMyNGE1Mi4uMTE0ODVhNCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9LY29uZmlnCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvS2NvbmZpZwo+IEBAIC0xLDYgKzEsNiBAQAo+ICBjb25maWcg RFJNX1JDQVJfRFUKPiAgCXRyaXN0YXRlICJEUk0gU3VwcG9ydCBmb3IgUi1DYXIgRGlzcGxheSBV bml0Igo+IC0JZGVwZW5kcyBvbiBEUk0gJiYgQVJNCj4gKwlkZXBlbmRzIG9uIERSTSAmJiBBUk0g JiYgSEFWRV9ETUFfQVRUUlMKPiAgCWRlcGVuZHMgb24gQVJDSF9TSE1PQklMRSB8fCBDT01QSUxF X1RFU1QKPiAgCXNlbGVjdCBEUk1fS01TX0hFTFBFUgo+ICAJc2VsZWN0IERSTV9LTVNfQ01BX0hF TFBFUgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvS2NvbmZpZwo+IGIv ZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL0tjb25maWcgaW5kZXggYTUwZmUwZS4uNzMyMWM0MSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvS2NvbmZpZwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9LY29uZmlnCj4gQEAgLTEsNiArMSw2IEBACj4gIGNvbmZp ZyBEUk1fU0hNT0JJTEUKPiAgCXRyaXN0YXRlICJEUk0gU3VwcG9ydCBmb3IgU0ggTW9iaWxlIgo+ IC0JZGVwZW5kcyBvbiBEUk0gJiYgQVJNCj4gKwlkZXBlbmRzIG9uIERSTSAmJiBBUk0gJiYgSEFW RV9ETUFfQVRUUlMKPiAgCWRlcGVuZHMgb24gQVJDSF9TSE1PQklMRSB8fCBDT01QSUxFX1RFU1QK PiAgCXNlbGVjdCBCQUNLTElHSFRfQ0xBU1NfREVWSUNFCj4gIAlzZWxlY3QgRFJNX0tNU19IRUxQ RVIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9LY29uZmlnIGIvZHJpdmVycy9n cHUvZHJtL3N0aS9LY29uZmlnCj4gaW5kZXggZDZkNmI3MC4uMWZkYjc0YiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vc3RpL0tjb25maWcKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3Rp L0tjb25maWcKPiBAQCAtMSw2ICsxLDYgQEAKPiAgY29uZmlnIERSTV9TVEkKPiAgCXRyaXN0YXRl ICJEUk0gU3VwcG9ydCBmb3IgU1RNaWNyb2VsZWN0cm9uaWNzIFNvQyBzdGlINDF4IFNlcmllcyIK PiAtCWRlcGVuZHMgb24gRFJNICYmIChTT0NfU1RJSDQxNSB8fCBTT0NfU1RJSDQxNiB8fCBBUkNI X01VTFRJUExBVEZPUk0pCj4gKwlkZXBlbmRzIG9uIERSTSAmJiAoU09DX1NUSUg0MTUgfHwgU09D X1NUSUg0MTYgfHwgQVJDSF9NVUxUSVBMQVRGT1JNKSAmJgo+IEhBVkVfRE1BX0FUVFJTIHNlbGVj dCBSRVNFVF9DT05UUk9MTEVSCj4gIAlzZWxlY3QgRFJNX0tNU19IRUxQRVIKPiAgCXNlbGVjdCBE Uk1fR0VNX0NNQV9IRUxQRVIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy9L Y29uZmlnIGIvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy9LY29uZmlnCj4gaW5kZXggN2MzZWY3OS4u ODM5NGEwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL0tjb25maWcKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL0tjb25maWcKPiBAQCAtMSw2ICsxLDYgQEAKPiAg Y29uZmlnIERSTV9USUxDREMKPiAgCXRyaXN0YXRlICJEUk0gU3VwcG9ydCBmb3IgVEkgTENEQyBE aXNwbGF5IENvbnRyb2xsZXIiCj4gLQlkZXBlbmRzIG9uIERSTSAmJiBPRiAmJiBBUk0KPiArCWRl cGVuZHMgb24gRFJNICYmIE9GICYmIEFSTSAmJiBIQVZFX0RNQV9BVFRSUwo+ICAJc2VsZWN0IERS TV9LTVNfSEVMUEVSCj4gIAlzZWxlY3QgRFJNX0tNU19GQl9IRUxQRVIKPiAgCXNlbGVjdCBEUk1f S01TX0NNQV9IRUxQRVIKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683AbbBCKpG (ORCPT ); Tue, 3 Feb 2015 05:45:06 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:55621 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754587AbbBCKpE (ORCPT ); Tue, 3 Feb 2015 05:45:04 -0500 From: Laurent Pinchart To: Chen Gang S Cc: airlied@linux.ie, p.zabel@pengutronix.de, robdclark@gmail.com, boris.brezillon@free-electrons.com, nicolas.ferre@atmel.com, benjamin.gaignard@linaro.org, jg1.han@samsung.com, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, "linux-kernel@vger.kernel.org" , chris@zankel.net, jcmvbkbc@gmail.com Subject: Re: [PATCH] drm: Kconfig: Let all DRM_GEM_CMA_HELPER related macros depend on HAVE_DMA_ATTRS Date: Tue, 03 Feb 2015 12:45:47 +0200 Message-ID: <2264372.TXY4G2KdxT@avalon> User-Agent: KMail/4.14.3 (Linux/3.17.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54CE3361.9090107@sunrus.com.cn> References: <54CE3361.9090107@sunrus.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen, Thank you for the patch. On Sunday 01 February 2015 22:08:33 Chen Gang S wrote: > DRM_GEM_CMA_HELPER is depend on HAVE_DMA_ATTRS, or it will break the > building. The related error (with allmodconfig under xtensa): > > CC [M] drivers/gpu/drm/drm_gem_cma_helper.o > drivers/gpu/drm/drm_gem_cma_helper.c: In function 'drm_gem_cma_create': > drivers/gpu/drm/drm_gem_cma_helper.c:110:19: error: implicit declaration > of function 'dma_alloc_writecombine' > [-Werror=implicit-function-declaration] cma_obj->vaddr = > dma_alloc_writecombine(drm->dev, size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c:110:17: warning: assignment makes > pointer from integer without a cast [-Wint-conversion] cma_obj->vaddr = > dma_alloc_writecombine(drm->dev, size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c: In function > 'drm_gem_cma_free_object': drivers/gpu/drm/drm_gem_cma_helper.c:193:3: > error: implicit declaration of function 'dma_free_writecombine' > [-Werror=implicit-function-declaration] > dma_free_writecombine(gem_obj->dev->dev, cma_obj->base.size, > ^ > drivers/gpu/drm/drm_gem_cma_helper.c: In function 'drm_gem_cma_mmap_obj': > drivers/gpu/drm/drm_gem_cma_helper.c:330:8: error: implicit declaration of > function 'dma_mmap_writecombine' [-Werror=implicit-function-declaration] > ret = dma_mmap_writecombine(cma_obj->base.dev->dev, vma, > ^ > > Signed-off-by: Chen Gang > --- > drivers/gpu/drm/Kconfig | 3 ++- > drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +- > drivers/gpu/drm/imx/Kconfig | 2 +- > drivers/gpu/drm/rcar-du/Kconfig | 2 +- > drivers/gpu/drm/shmobile/Kconfig | 2 +- > drivers/gpu/drm/sti/Kconfig | 2 +- > drivers/gpu/drm/tilcdc/Kconfig | 2 +- > 7 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 308c104..151a050 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -62,12 +62,13 @@ config DRM_TTM > > config DRM_GEM_CMA_HELPER > bool > - depends on DRM > + depends on DRM && HAVE_DMA_ATTRS > help > Choose this if you need the GEM CMA helper functions > > config DRM_KMS_CMA_HELPER > bool > + depends on DRM && HAVE_DMA_ATTRS > select DRM_GEM_CMA_HELPER > select DRM_KMS_FB_HELPER > select FB_SYS_FILLRECT > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig > b/drivers/gpu/drm/atmel-hlcdc/Kconfig index 1a08562..219fc87 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig > +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig > @@ -1,6 +1,6 @@ > config DRM_ATMEL_HLCDC > tristate "DRM Support for ATMEL HLCDC Display Controller" > - depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC > + depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && HAVE_DMA_ATTRS I don't like having to add the explicit dependency to all users of DRM_GEM_CMA_HELPER and DRM_KMS_CMA_HELPER, but there's no way around this given the select vs. depends issues in Kconfig. A better solution in the longer term would be to implement HAVE_DMA_ATTRS support for xtensa (and all the other architectures that miss it), but this patch looks fine to me as an interim solution. Acked-by: Laurent Pinchart > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig > index 5d5e4092..33cdddf 100644 > --- a/drivers/gpu/drm/imx/Kconfig > +++ b/drivers/gpu/drm/imx/Kconfig > @@ -5,7 +5,7 @@ config DRM_IMX > select VIDEOMODE_HELPERS > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > - depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) > + depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM) && HAVE_DMA_ATTRS > depends on IMX_IPUV3_CORE > help > enable i.MX graphics support > diff --git a/drivers/gpu/drm/rcar-du/Kconfig > b/drivers/gpu/drm/rcar-du/Kconfig index 2324a52..11485a4 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -1,6 +1,6 @@ > config DRM_RCAR_DU > tristate "DRM Support for R-Car Display Unit" > - depends on DRM && ARM > + depends on DRM && ARM && HAVE_DMA_ATTRS > depends on ARCH_SHMOBILE || COMPILE_TEST > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > diff --git a/drivers/gpu/drm/shmobile/Kconfig > b/drivers/gpu/drm/shmobile/Kconfig index a50fe0e..7321c41 100644 > --- a/drivers/gpu/drm/shmobile/Kconfig > +++ b/drivers/gpu/drm/shmobile/Kconfig > @@ -1,6 +1,6 @@ > config DRM_SHMOBILE > tristate "DRM Support for SH Mobile" > - depends on DRM && ARM > + depends on DRM && ARM && HAVE_DMA_ATTRS > depends on ARCH_SHMOBILE || COMPILE_TEST > select BACKLIGHT_CLASS_DEVICE > select DRM_KMS_HELPER > diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig > index d6d6b70..1fdb74b 100644 > --- a/drivers/gpu/drm/sti/Kconfig > +++ b/drivers/gpu/drm/sti/Kconfig > @@ -1,6 +1,6 @@ > config DRM_STI > tristate "DRM Support for STMicroelectronics SoC stiH41x Series" > - depends on DRM && (SOC_STIH415 || SOC_STIH416 || ARCH_MULTIPLATFORM) > + depends on DRM && (SOC_STIH415 || SOC_STIH416 || ARCH_MULTIPLATFORM) && > HAVE_DMA_ATTRS select RESET_CONTROLLER > select DRM_KMS_HELPER > select DRM_GEM_CMA_HELPER > diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig > index 7c3ef79..8394a0b 100644 > --- a/drivers/gpu/drm/tilcdc/Kconfig > +++ b/drivers/gpu/drm/tilcdc/Kconfig > @@ -1,6 +1,6 @@ > config DRM_TILCDC > tristate "DRM Support for TI LCDC Display Controller" > - depends on DRM && OF && ARM > + depends on DRM && OF && ARM && HAVE_DMA_ATTRS > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > select DRM_KMS_CMA_HELPER -- Regards, Laurent Pinchart