All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: torvalds@transmeta.com, davem@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: recalc_sigpending() / recalc_sigpending_tsk() ?
Date: Thu, 28 Feb 2002 16:31:25 +0000	[thread overview]
Message-ID: <22659.1014913885@redhat.com> (raw)

I'm looking at merging the changes made to JFFS2 in 2.5, with the intention 
of again having a single codebase that compiles in both 2.5 and 2.4.

I'm a little confused by the changes to recalc_sigpending().

It seems that the name of the function was changed to recalc_sigpending_tsk()
and a new function called recalc_sigpending() was added.

Was there a reason for doing this, rather than just introducing the new 
function with a different name, such as recalc_sigpending_cur()? It breaks 
2.4 source compatibility in a way that seems entirely gratuitous.

Before I have to go and do something evil in my compatmac.h to work round 
this, is there any chance of putting the original recalc_sigpending() back?

Linus, would you accept such a patch?

--
dwmw2

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,5)
#include <linux/sched.h>
/* Grrr. Gratuitous breakage */
#define recalc_sigpending() recalc_sigpending(current)
/* Unfortunately this one can't work, because of the above
#define recalc_sigpending_tsk(t) recalc_sigpending(t)
 */
#endif




             reply	other threads:[~2002-02-28 16:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-28 16:31 David Woodhouse [this message]
2002-02-28 16:59 ` recalc_sigpending() / recalc_sigpending_tsk() ? Linus Torvalds
2002-02-28 18:26   ` David Woodhouse
2002-03-01 15:33   ` David Woodhouse
2002-03-01 15:33     ` David S. Miller
2002-03-01 15:37     ` David Woodhouse
2002-03-01 15:49       ` David S. Miller
2002-03-01 16:28       ` David Woodhouse
2002-03-01 16:49     ` Linus Torvalds
2002-03-01 17:05       ` David Woodhouse
2002-03-01 17:40       ` David Howells
2002-03-01 17:43         ` David Woodhouse
2002-03-01 19:01       ` [PATCH] small proposal Martin Dalecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22659.1014913885@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.