All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: yocto@yoctoproject.org
Subject: Re: is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="?
Date: Tue, 19 Jun 2012 18:52:21 +0100	[thread overview]
Message-ID: <2266259.lx4CelsjGA@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1206190818420.30655@oneiric>

On Tuesday 19 June 2012 08:22:00 Robert P. J. Day wrote:
>   currently, the dev manual (Section 4.2.1) proposes the use of
> 
>   IMAGE_INSTALL += "strace"
> 
> but the poky ref manual in the variable glossary explicitly
> discourages that form, and instead recommends
> 
>   IMAGE_INSTALL_append = " package-name"
> 
>   can we agree that the "_append" form is preferred?  thoughts?

The reference manual is a little unclear on what "ordering issues" means. += 
works just fine, it's just that if you happen to use it at some point before 
core-image.bbclass line sets it with ?= (i.e. either in local.conf or before 
the "inherit core-image" line in your image recipe) the ?= line in core-
image.bbclass will do nothing and you'll end up with much less in the 
IMAGE_INSTALL list than you expected. If you use _append, you can have that 
anywhere you like and it will always work, with the caveat that if you forget 
to add a leading space in the value to be appended, things will break.

Note that the part of 4.2.1 in the dev manual you refer to is specifically 
talking about making a copy of an image recipe and putting the IMAGE_INSTALL 
+= at the end, which will always work and won't suffer from any leading space 
issues. I'm not sure what we should change to improve this...

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2012-06-19 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 12:22 is it "IMAGE_INSTALL +=" or "IMAGE_INSTALL_append ="? Robert P. J. Day
2012-06-19 17:52 ` Paul Eggleton [this message]
2012-06-19 18:47   ` Chris Tapp
2012-06-20  6:23     ` Tomas Frydrych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2266259.lx4CelsjGA@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=rpjday@crashcourse.ca \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.