From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 0/5] consolidate testing apps to app dir
Date: Tue, 26 Feb 2019 15:40:38 +0100
Message-ID: <2268995.D1hX1lYPB6@xps>
References: <20190125202642.66559-1-bruce.richardson@intel.com>
 <20190226121903.5499-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 52C323237
 for <dev@dpdk.org>; Tue, 26 Feb 2019 15:40:43 +0100 (CET)
In-Reply-To: <20190226121903.5499-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/02/2019 13:18, Bruce Richardson:
> The apps for testing are split between the "test" and "app" directories,
> with a not-very-clear distinction between the two (at least to my mind).
> 
> Given how the apps are being built, the easiest path to having
> cmdline_test, test-acl and test-pipeline build using meson is to
> consolidate all these apps back into the app folder and use the logic
> there. The bpf folder doesn't contain an actual application, but
> rather example bpf code which can be loaded into testpmd. That is
> possibly best moved to the examples folder, but I'm open to feedback
> on the best place for it.
> 
> With these changes, the "test" folder then becomes the location for
> unit tests only. However, we can simplify things a little by moving
> that too to the app folder, eliminating the need for the separate
> "test-build" make target, and aligning the output folder for the
> binary from "make test-build" with the source file location in app.
> 
> ---
> V3: * Renamed the cmdline_test subdirectory to test-cmdline as part of the
>       move.
> V2: * Following some discussion with Thomas, moved the autotests to the
>       app folder too.
>     * Updated maintainers file appropriately in each patch.

Applied, thanks