From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 01/10] examples/tep_termination:initialize the VXLAN sample Date: Mon, 22 Jun 2015 09:49:27 +0200 Message-ID: <2269442.FSZeuyxEr5@xps13> References: <1434589417-5395-1-git-send-email-jijiang.liu@intel.com> <1434589417-5395-2-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Jijiang Liu Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id DD858C756 for ; Mon, 22 Jun 2015 09:50:28 +0200 (CEST) Received: by wiga1 with SMTP id a1so68202036wig.0 for ; Mon, 22 Jun 2015 00:50:28 -0700 (PDT) In-Reply-To: <1434589417-5395-2-git-send-email-jijiang.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-18 09:03, Jijiang Liu: > This sample uses the basic virtio devices management function from th= e vHost example, which includes virtio device creation, destroying and = maintenance. Please wrap commit message to about 72 characters. https://github.com/erlang/otp/wiki/Writing-good-commit-messages https://git-scm.com/book/ch5-2.html typo in Makefile: overriden -> overridden There are 2 functions where ret is incremented but never initialized: examples/tep_termination/main.c:473:6: error: =E2=80=98ret=E2=80=99 may= be used uninitialized in this function examples/tep_termination/main.c:536:8: error: =E2=80=98ret=E2=80=99 may= be used uninitialized in this function Making a patch buildable with recent GCC and clang is the minimum befor= e submitting it.