From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nywuT-0006lp-FG for mharc-grub-devel@gnu.org; Wed, 08 Jun 2022 10:43:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nywuR-0006hr-KV for grub-devel@gnu.org; Wed, 08 Jun 2022 10:43:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:59753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nywuP-00041v-L6 for grub-devel@gnu.org; Wed, 08 Jun 2022 10:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654699420; bh=kFiXUTmB0fh39k/TsltfvXk9e2gA4Ho00RfFktMj7vY=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=k8E1xZvt23Evw/bnKgk8sTOiR7VO0qwb2rq3bB9MT2+8pIXNAAmUpno9TVyB3WalS nqquBmlbywK6oD8+yb2mIuVfv370tkJgDPQmN8XEaj9FvuZW/U/getANf12x3ZV9ob zETerXzR1HVigko1jdO0sSd7LcLIa3ZMuTK/CYKY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([91.8.164.217]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3siA-1nYRoK1LdY-00zjex; Wed, 08 Jun 2022 16:43:40 +0200 Date: Wed, 08 Jun 2022 16:42:36 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH 2/3] grub-mkrescue: Preserve a copy of the EFI bootloaders on the ISO9660 file system Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: pete@akeo.ie References: <20220606165034.811-3-pete@akeo.ie> In-Reply-To: <20220606165034.811-3-pete@akeo.ie> Message-Id: <22728369466976794222@scdbackup.webframe.org> X-Provags-ID: V03:K1:mSPWl9RbSVz1kc/rJtTGYmQcLjOSjSIVvI9YFgNatDWqhUlkvYy JM08b892IVJk161ao/LToimGrgeI8LZDZuKiP9tQG2jhkAPZ5UdUg++/KaQ477GMXMggvZQ Ggv3APOS3NHIiflSgiPRAhB3V6/e7HtQfeGqf9d4/txuD6YeHEO8AWt+y8RfY+7lacWcyc+ el0L5fQQGldj47Q8bUdzQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ER3W75h+Grg=:+u0xlej+yoLv1jnObGcy4M k8odAggNjTGr4xN3pbt3ZXdoHcOvyg03LlewgZFIKW/mGarAWURldXuO53mkSClevTuBHlDRy f0qYZFR+qV1p88DWzT1xsBAPECCvoGcGHeRK0eMxXdsm04zTDGs0K98NOBML74hhLL+S5iWUv EKTO6rrAzY8rieRFIZSJCDJOfdcc0u8oo813oXmOBbJ/uAOnqFXOpIv75jCM+riiDs60WmAHg WXcTUyKPWBmyKI9ZKGdm5Xw58rB7j0e/jsCTna1TXZ0fHc2zvXTxKzVF8GXsL2wUcq5FL7vEu 8JvvYlnojgYRfzt3wSf+b5noKYc+c2TGtbpzSVYAfCxO6SddyFswXZ5UF84q+4iDLZTY01Dkd bEm9WnU+6Oamj67sjmPapiJxnJdNIrd7NIwuZXxfR/ITjULXshrnWG0Gd29hYgajZAtcr5JmH f9QVOnIj1r5vpxqOu1QFNrwZyGAhzD6KCC+aN0UbMsZJzFr20idnsjcG9BGMCV4KpybV1IxPC ITphc0gnDTeLUaV9UQLcUflSfH9Fj9EH0KjNcJUjXB1CcBgJFLaJH2ZSxQU/0bP+wWHfKfdeo xFPaUzWnX1BN4PcpedNE90xDuhIUAbS5KUDj99LegWqEuhKOUAVj6i18QbBAsid365dLOzADC NzAyDDG4LeqAmYvXN8pEcEv+VdiyupFHEMlPqV3DUnPy4rl+46LRd1ZXSk+vg/FrgDpOT7zQi Rt1ACABU84GsYXhqG2dyx/MJ5e9FmVpKaAF0yr2ZGAu5nAciorvArGA5EdjqnEi9wQZyDNzzO WgeDlG3XwH3DTr43FVCPo6BLHdLVIsNfANKex163Td5vFWjPFr5pvRw+NMiCn2Pcs49RETK8H xFbQxisal332xU0YZXztcT7NpVheY4mWCp41127qTjef9XrEesTzy4FIkOjMib3TXZIqGUGxI 9ytxM2QW2qrIWgGuSXIPRQdQT/kVYYzGm3wXbIsM9TTB39agmEHwUfmpODpSDFLBh6y/6m0/z Wwsn4tZTPsmOWKml4dqWOcZTwYqqGrOQSiVKcDyY9jd39VOviXIaFsiP3wFT+XOSaxAwMHk+k PZWhxWnFmNFBmLf42zRntldhVFG5k3S0zPed3LPz1QKOY9xq7ZIoJ4hlw== Received-SPF: pass client-ip=212.227.15.19; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 14:43:47 -0000 Hi, On Mon, 6 Jun 2022 17:50:32 +0100, Pete Batard wrote: > To enable file system transposition support for UEFI, we also must ensur= e that > there exists a copy of the EFI bootloaders, that are currently embedded = in the > efi.img for xorriso, at their expected UEFI location on the ISO9660 file= system. > > This is accomplished by removing the use of a temporary directory to cre= ate the > efi/ content, to instead place it at the root of the ISO9660 content. > > Signed-off-by: Pete Batard Reviewed-by: Thomas Schmitt Tested-by: Thomas Schmitt I reviewed (modulo style aspects) and applied the patch [2/3] to a freshly pulled grub-mkrescue.c . It compiles and produces (on Debian) an ISO with: grub/grub-mkrescue -d /usr/lib/grub/x86_64-efi \ --locale-directory=3D/usr/share -o test.iso minimal (It would be more realistic if i knew how the Debian binary of grub-mkresc= ue knows that there is also /usr/lib/grub/i386-pc and combines it with x86_64-efi. If i use two -d options, then the latter overrides the former= .) Whatever, the resulting test.iso has EFI boot equipment of the same size a= s the ISO from Debian's grub-mkrescue with the same arguments as above. Different than with Debian's binary, there is now a directory tree /efi in the ISO with 146 KiB of storage space (measured by xorriso -dus). Have a nice day :) Thomas