From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com,
yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
pallavi.kadam@intel.com, ranjit.menon@intel.com,
olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu,
nhorman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows
Date: Tue, 30 Jun 2020 01:26:29 +0200 [thread overview]
Message-ID: <2273109.IVLB8IxS53@thomas> (raw)
In-Reply-To: <20200622115528.22928-2-fady@mellanox.com>
22/06/2020 13:55, Fady Bader:
> Function versioning is not needed on Windows, also the function versioning
> implementation is not supported by Windows.
I think it was said that "not needed" is not right.
Let's just say that it is not supported for now.
> Function versioning was disabled on Windows.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
> ---
> --- a/lib/librte_eal/include/rte_function_versioning.h
> +++ b/lib/librte_eal/include/rte_function_versioning.h
> +#ifdef RTE_EXEC_ENV_WINDOWS
> +#undef RTE_BUILD_SHARED_LIB
> +#endif
This trick is a bit weird but works.
A comment is missing to explain that function versioning is disabled
but shared libraries are allowed for Windows.
next prev parent reply other threads:[~2020-06-29 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <'20200531124151.16848-2-fady@mellanox.com'>
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 0/4] build mempool on Windows Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning " Fady Bader
2020-06-29 23:26 ` Thomas Monjalon [this message]
2020-07-02 10:25 ` Fady Bader
2020-06-30 10:49 ` Kinsella, Ray
2020-07-02 14:56 ` Kinsella, Ray
2020-07-05 7:00 ` Fady Bader
2020-07-05 8:37 ` Thomas Monjalon
2020-07-05 8:51 ` Fady Bader
2020-07-05 9:00 ` Thomas Monjalon
2020-07-05 20:00 ` Thomas Monjalon
2020-07-07 7:57 ` Kinsella, Ray
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 2/4] mempool: use generic memory management Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool Fady Bader
2020-06-29 23:28 ` Thomas Monjalon
2020-07-02 10:24 ` Fady Bader
2020-06-22 11:55 ` [dpdk-dev] [PATCH v3 4/4] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2273109.IVLB8IxS53@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.