All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Aaron Conole <aconole@redhat.com>,
	Timothy Redaelli <tredaelli@redhat.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Jan Viktorin <viktorin@rehivetech.com>,
	Jianbo Liu <jianbo.liu@arm.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Chao Zhu <chaozhu@linux.vnet.ibm.com>,
	Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH v2] eal: abstract away the auxiliary vector
Date: Wed, 11 Apr 2018 23:34:27 +0200	[thread overview]
Message-ID: <22739292.VNXgVMcpcx@xps> (raw)
In-Reply-To: <20180402182434.14045-1-aconole@redhat.com>

Anyone to review, please?

02/04/2018 20:24, Aaron Conole:
> Rather than attempting to load the contents of the auxv directly,
> prefer to use an exposed API - and if that doesn't exist then attempt
> to load the vector.  This is because on some systems, when a user
> is downgraded, the /proc/self/auxv file retains the old ownership
> and permissions.  The original method of /proc/self/auxv is retained.
> 
> This also removes a potential abort() in the code when compiled with
> NDEBUG.  A quick parse of the code shows that many (if not all) of
> the CPU flag parsing isn't used internally, so it should be okay.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>

  reply	other threads:[~2018-04-11 21:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 15:35 [PATCH] eal: abstract away the auxiliary vector Aaron Conole
2018-03-22 16:08 ` Wiles, Keith
2018-03-22 17:39   ` Aaron Conole
2018-04-02 18:24 ` [PATCH v2] " Aaron Conole
2018-04-11 21:34   ` Thomas Monjalon [this message]
2018-04-25  2:36     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22739292.VNXgVMcpcx@xps \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@arm.com \
    --cc=keith.wiles@intel.com \
    --cc=tredaelli@redhat.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.