From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 11 Mar 2014 16:32:26 +0000 Subject: Re: [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework Message-Id: <2274545.CyQ67zvVqo@avalon> List-Id: References: <1394531952-3905-1-git-send-email-geert@linux-m68k.org> <1802214.NxZUiJcWLG@avalon> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Mark Brown , linux-spi , Linux-sh list , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Magnus Damm On Tuesday 11 March 2014 17:23:37 Geert Uytterhoeven wrote: > Hi Laurent, > > On Tue, Mar 11, 2014 at 4:55 PM, Laurent Pinchart wrote: > > Does this require drivers/sh/pm_runtime.c to be compiled in ? > > Let's check... > > My koelsch-legacy kernel has drivers/sh/pm_runtime.c compiled in. > My koelsch-reference kernel hasn't. > > However, under the -reference kernel many MSTP clocks (incl. MSIOF) > seem to be enabled all the time, while under -legacy they are enabled and > disabled on demand. Is PM_RUNTIME enabled in both cases ? There's something fishy in there that we should try to fix without too further much delay. Ben Dooks has pointed out the problem a couple of months ago, but the discussion on the mailing list just died. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework Date: Tue, 11 Mar 2014 17:32:26 +0100 Message-ID: <2274545.CyQ67zvVqo@avalon> References: <1394531952-3905-1-git-send-email-geert@linux-m68k.org> <1802214.NxZUiJcWLG@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Mark Brown , linux-spi , Linux-sh list , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Magnus Damm To: Geert Uytterhoeven Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Tuesday 11 March 2014 17:23:37 Geert Uytterhoeven wrote: > Hi Laurent, > > On Tue, Mar 11, 2014 at 4:55 PM, Laurent Pinchart wrote: > > Does this require drivers/sh/pm_runtime.c to be compiled in ? > > Let's check... > > My koelsch-legacy kernel has drivers/sh/pm_runtime.c compiled in. > My koelsch-reference kernel hasn't. > > However, under the -reference kernel many MSTP clocks (incl. MSIOF) > seem to be enabled all the time, while under -legacy they are enabled and > disabled on demand. Is PM_RUNTIME enabled in both cases ? There's something fishy in there that we should try to fix without too further much delay. Ben Dooks has pointed out the problem a couple of months ago, but the discussion on the mailing list just died. -- Regards, Laurent Pinchart