From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus Date: Tue, 23 Apr 2019 12:26:02 +0200 Message-ID: <2275367.P1g2IIHPGP@phil> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1033F890B0 for ; Tue, 23 Apr 2019 10:26:08 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jonas Karlman Cc: Archit Taneja , Neil Armstrong , David Airlie , Jernej Skrabec , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Sean Paul , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org QW0gU29ubnRhZywgMjEuIEFwcmlsIDIwMTksIDEwOjI1OjUwIENFU1Qgc2NocmllYiBKb25hcyBL YXJsbWFuOgo+IFdoZW4gZGRjLWkyYy1idXMgcHJvcGVydHkgaXMgdXNlZCwgYSBOVUxMIHBvaW50 ZXIgZGVyZWZlcmVuY2UgaXMgcmVwb3J0ZWQ6Cj4gCj4gWyAgIDMxLjA0MTY2OV0gVW5hYmxlIHRv IGhhbmRsZSBrZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IHZpcnR1YWwgYWRkcmVz cyAwMDAwMDAwOAo+IFsgICAzMS4wNDE2NzFdIHBnZCA9IDRkM2MxNmY2Cj4gWyAgIDMxLjA0MTY3 M10gWzAwMDAwMDA4XSAqcGdkPTAwMDAwMDAwCj4gWyAgIDMxLjA0MTY3OF0gSW50ZXJuYWwgZXJy b3I6IE9vcHM6IDUgWyMxXSBTTVAgQVJNCj4gCj4gWyAgIDMxLjA0MTcxMV0gSGFyZHdhcmUgbmFt ZTogUm9ja2NoaXAgKERldmljZSBUcmVlKQo+IFsgICAzMS4wNDE3MThdIFBDIGlzIGF0IGkyY190 cmFuc2ZlcisweDgvMHhlNAo+IFsgICAzMS4wNDE3MjFdIExSIGlzIGF0IGRybV9zY2RjX3JlYWQr MHg1NC8weDg0Cj4gWyAgIDMxLjA0MTcyM10gcGMgOiBbPGMwNzMyNzNjPl0gICAgbHIgOiBbPGMw NTkyNmM0Pl0gICAgcHNyOiAyODBmMDAxMwo+IFsgICAzMS4wNDE3MjVdIHNwIDogZWRmZmRhZDAg IGlwIDogNWNjYjU1MTEgIGZwIDogMDAwMDAwNTgKPiBbICAgMzEuMDQxNzI3XSByMTA6IDAwMDAw NzgwICByOSA6IGVkZjkxNjA4ICByOCA6IGMxMWIwZjQ4Cj4gWyAgIDMxLjA0MTcyOF0gcjcgOiAw MDAwMDQzOCAgcjYgOiAwMDAwMDAwMCAgcjUgOiAwMDAwMDAwMCAgcjQgOiAwMDAwMDAwMAo+IFsg ICAzMS4wNDE3MzBdIHIzIDogZWRmZmRhZTcgIHIyIDogMDAwMDAwMDIgIHIxIDogZWRmZmRhZWMg IHIwIDogMDAwMDAwMDAKPiAKPiBbICAgMzEuMDQxOTA4XSBbPGMwNzMyNzNjPl0gKGkyY190cmFu c2ZlcikgZnJvbSBbPGMwNTkyNmM0Pl0gKGRybV9zY2RjX3JlYWQrMHg1NC8weDg0KQo+IFsgICAz MS4wNDE5MTNdIFs8YzA1OTI2YzQ+XSAoZHJtX3NjZGNfcmVhZCkgZnJvbSBbPGMwNTkyODU4Pl0g KGRybV9zY2RjX3NldF9zY3JhbWJsaW5nKzB4MzAvMHhiYykKPiBbICAgMzEuMDQxOTE5XSBbPGMw NTkyODU4Pl0gKGRybV9zY2RjX3NldF9zY3JhbWJsaW5nKSBmcm9tIFs8YzA1Y2MwZjQ+XSAoZHdf aGRtaV91cGRhdGVfcG93ZXIrMHgxNDQwLzB4MTYxMCkKPiBbICAgMzEuMDQxOTI2XSBbPGMwNWNj MGY0Pl0gKGR3X2hkbWlfdXBkYXRlX3Bvd2VyKSBmcm9tIFs8YzA1Y2M1NzQ+XSAoZHdfaGRtaV9i cmlkZ2VfZW5hYmxlKzB4MmMvMHg3MCkKPiBbICAgMzEuMDQxOTMyXSBbPGMwNWNjNTc0Pl0gKGR3 X2hkbWlfYnJpZGdlX2VuYWJsZSkgZnJvbSBbPGMwNWFlZDQ4Pl0gKGRybV9icmlkZ2VfZW5hYmxl KzB4MjQvMHgzNCkKPiBbICAgMzEuMDQxOTM4XSBbPGMwNWFlZDQ4Pl0gKGRybV9icmlkZ2VfZW5h YmxlKSBmcm9tIFs8YzA1OTEwNjA+XSAoZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVzZXRf ZW5hYmxlcysweDExNC8weDIyMCkKPiBbICAgMzEuMDQxOTQzXSBbPGMwNTkxMDYwPl0gKGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXMpIGZyb20gWzxjMDVjM2ZlMD5dIChy b2NrY2hpcF9hdG9taWNfaGVscGVyX2NvbW1pdF90YWlsX3JwbSsweDI4LzB4NjQpCj4gCj4gaGRt aS0+aTJjIG1heSBub3QgYmUgc2V0IHdoZW4gZGRjLWkyYy1idXMgcHJvcGVydHkgaXMgdXNlZCBp biBkZXZpY2UgdHJlZS4KPiBGaXggdGhpcyBieSB1c2luZyBoZG1pLT5kZGMgYXMgdGhlIGkyYyBh ZGFwdGVyIHdoZW4gY2FsbGluZyBkcm1fc2NkY18qKCkuCj4gQWxzbyByZXBvcnQgdGhhdCBTQ0RD IGlzIG5vdCBzdXBwb3J0ZWQgd2hlbiB0aGVyZSBpcyBubyBEREMgYnVzLgo+IAo+IEZpeGVzOiAy NjRmY2U2Y2MyYzEgKCJkcm0vYnJpZGdlOiBkdy1oZG1pOiBBZGQgU0NEQyBhbmQgVE1EUyBTY3Jh bWJsaW5nIHN1cHBvcnQiKQo+IFNpZ25lZC1vZmYtYnk6IEpvbmFzIEthcmxtYW4gPGpvbmFzQGt3 aWJvby5zZT4KCkkndmUgbG9va2VkIHRoYXQgdXAgYW5kIHllYWgsIGhkbWktPmRkYyBzZWVtcyB0 aGUgcmlnaHQgdGhpbmcgdG8gdXNlCmFzIGl0IHBvaW50cyBlaXRoZXIgdG8gdGhlIGV4dGVybmFs IGkyYyBvciB0aGUgaW50ZXJuYWwgb25lLCBzbwoKUmV2aWV3ZWQtYnk6IEhlaWtvIFN0dWVibmVy IDxoZWlrb0BzbnRlY2guZGU+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9w c3lzL2R3LWhkbWkuYyB8IDEyICsrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lu b3BzeXMvZHctaGRtaS5jCj4gaW5kZXggN2E0N2M2NWQ4ZWNiLi5mZDFjMzE5YTRlZTAgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYwo+IEBAIC0xMDQ2LDYg KzEwNDYsMTAgQEAgc3RhdGljIGJvb2wgZHdfaGRtaV9zdXBwb3J0X3NjZGMoc3RydWN0IGR3X2hk bWkgKmhkbWkpCj4gIAlpZiAoaGRtaS0+dmVyc2lvbiA8IDB4MjAwYSkKPiAgCQlyZXR1cm4gZmFs c2U7Cj4gIAo+ICsJLyogRGlzYWJsZSBpZiBubyBEREMgYnVzICovCj4gKwlpZiAoIWhkbWktPmRk YykKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICAJLyogRGlzYWJsZSBpZiBTQ0RDIGlzIG5vdCBz dXBwb3J0ZWQsIG9yIGlmIGFuIEhGLVZTREIgYmxvY2sgaXMgYWJzZW50ICovCj4gIAlpZiAoIWRp c3BsYXktPmhkbWkuc2NkYy5zdXBwb3J0ZWQgfHwKPiAgCSAgICAhZGlzcGxheS0+aGRtaS5zY2Rj LnNjcmFtYmxpbmcuc3VwcG9ydGVkKQo+IEBAIC0xNjgzLDEzICsxNjg3LDEzIEBAIHN0YXRpYyB2 b2lkIGhkbWlfYXZfY29tcG9zZXIoc3RydWN0IGR3X2hkbWkgKmhkbWksCj4gIAkJCSAqIFNvdXJj ZSBEZXZpY2VzIGNvbXBsaWFudCBzaGFsbCBzZXQgdGhlCj4gIAkJCSAqIFNvdXJjZSBWZXJzaW9u ID0gMS4KPiAgCQkJICovCj4gLQkJCWRybV9zY2RjX3JlYWRiKCZoZG1pLT5pMmMtPmFkYXAsIFND RENfU0lOS19WRVJTSU9OLAo+ICsJCQlkcm1fc2NkY19yZWFkYihoZG1pLT5kZGMsIFNDRENfU0lO S19WRVJTSU9OLAo+ICAJCQkJICAgICAgICZieXRlcyk7Cj4gLQkJCWRybV9zY2RjX3dyaXRlYigm aGRtaS0+aTJjLT5hZGFwLCBTQ0RDX1NPVVJDRV9WRVJTSU9OLAo+ICsJCQlkcm1fc2NkY193cml0 ZWIoaGRtaS0+ZGRjLCBTQ0RDX1NPVVJDRV9WRVJTSU9OLAo+ICAJCQkJbWluX3QodTgsIGJ5dGVz LCBTQ0RDX01JTl9TT1VSQ0VfVkVSU0lPTikpOwo+ICAKPiAgCQkJLyogRW5hYmxlZCBTY3JhbWJs aW5nIGluIHRoZSBTaW5rICovCj4gLQkJCWRybV9zY2RjX3NldF9zY3JhbWJsaW5nKCZoZG1pLT5p MmMtPmFkYXAsIDEpOwo+ICsJCQlkcm1fc2NkY19zZXRfc2NyYW1ibGluZyhoZG1pLT5kZGMsIDEp Owo+ICAKPiAgCQkJLyoKPiAgCQkJICogVG8gYWN0aXZhdGUgdGhlIHNjcmFtYmxlciBmZWF0dXJl LCB5b3UgbXVzdCBlbnN1cmUKPiBAQCAtMTcwNSw3ICsxNzA5LDcgQEAgc3RhdGljIHZvaWQgaGRt aV9hdl9jb21wb3NlcihzdHJ1Y3QgZHdfaGRtaSAqaGRtaSwKPiAgCQkJaGRtaV93cml0ZWIoaGRt aSwgMCwgSERNSV9GQ19TQ1JBTUJMRVJfQ1RSTCk7Cj4gIAkJCWhkbWlfd3JpdGViKGhkbWksICh1 OCl+SERNSV9NQ19TV1JTVFpfVE1EU1NXUlNUX1JFUSwKPiAgCQkJCSAgICBIRE1JX01DX1NXUlNU Wik7Cj4gLQkJCWRybV9zY2RjX3NldF9zY3JhbWJsaW5nKCZoZG1pLT5pMmMtPmFkYXAsIDApOwo+ ICsJCQlkcm1fc2NkY19zZXRfc2NyYW1ibGluZyhoZG1pLT5kZGMsIDApOwo+ICAJCX0KPiAgCX0K PiAgCj4gLS0gCj4gMi4xNy4xCj4gCj4gCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C3BC10F14 for ; Tue, 23 Apr 2019 10:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA05C2175B for ; Tue, 23 Apr 2019 10:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbfDWK0O (ORCPT ); Tue, 23 Apr 2019 06:26:14 -0400 Received: from gloria.sntech.de ([185.11.138.130]:60428 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfDWK0O (ORCPT ); Tue, 23 Apr 2019 06:26:14 -0400 Received: from p57b772a1.dip0.t-ipconnect.de ([87.183.114.161] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hIsck-0001oz-Sc; Tue, 23 Apr 2019 12:26:02 +0200 From: Heiko Stuebner To: Jonas Karlman Cc: "dri-devel@lists.freedesktop.org" , Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Neil Armstrong , Sean Paul , Jernej Skrabec , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus Date: Tue, 23 Apr 2019 12:26:02 +0200 Message-ID: <2275367.P1g2IIHPGP@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, 21. April 2019, 10:25:50 CEST schrieb Jonas Karlman: > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual address 00000008 > [ 31.041671] pgd = 4d3c16f6 > [ 31.041673] [00000008] *pgd=00000000 > [ 31.041678] Internal error: Oops: 5 [#1] SMP ARM > > [ 31.041711] Hardware name: Rockchip (Device Tree) > [ 31.041718] PC is at i2c_transfer+0x8/0xe4 > [ 31.041721] LR is at drm_scdc_read+0x54/0x84 > [ 31.041723] pc : [] lr : [] psr: 280f0013 > [ 31.041725] sp : edffdad0 ip : 5ccb5511 fp : 00000058 > [ 31.041727] r10: 00000780 r9 : edf91608 r8 : c11b0f48 > [ 31.041728] r7 : 00000438 r6 : 00000000 r5 : 00000000 r4 : 00000000 > [ 31.041730] r3 : edffdae7 r2 : 00000002 r1 : edffdaec r0 : 00000000 > > [ 31.041908] [] (i2c_transfer) from [] (drm_scdc_read+0x54/0x84) > [ 31.041913] [] (drm_scdc_read) from [] (drm_scdc_set_scrambling+0x30/0xbc) > [ 31.041919] [] (drm_scdc_set_scrambling) from [] (dw_hdmi_update_power+0x1440/0x1610) > [ 31.041926] [] (dw_hdmi_update_power) from [] (dw_hdmi_bridge_enable+0x2c/0x70) > [ 31.041932] [] (dw_hdmi_bridge_enable) from [] (drm_bridge_enable+0x24/0x34) > [ 31.041938] [] (drm_bridge_enable) from [] (drm_atomic_helper_commit_modeset_enables+0x114/0x220) > [ 31.041943] [] (drm_atomic_helper_commit_modeset_enables) from [] (rockchip_atomic_helper_commit_tail_rpm+0x28/0x64) > > hdmi->i2c may not be set when ddc-i2c-bus property is used in device tree. > Fix this by using hdmi->ddc as the i2c adapter when calling drm_scdc_*(). > Also report that SCDC is not supported when there is no DDC bus. > > Fixes: 264fce6cc2c1 ("drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support") > Signed-off-by: Jonas Karlman I've looked that up and yeah, hdmi->ddc seems the right thing to use as it points either to the external i2c or the internal one, so Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 7a47c65d8ecb..fd1c319a4ee0 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1046,6 +1046,10 @@ static bool dw_hdmi_support_scdc(struct dw_hdmi *hdmi) > if (hdmi->version < 0x200a) > return false; > > + /* Disable if no DDC bus */ > + if (!hdmi->ddc) > + return false; > + > /* Disable if SCDC is not supported, or if an HF-VSDB block is absent */ > if (!display->hdmi.scdc.supported || > !display->hdmi.scdc.scrambling.supported) > @@ -1683,13 +1687,13 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, > * Source Devices compliant shall set the > * Source Version = 1. > */ > - drm_scdc_readb(&hdmi->i2c->adap, SCDC_SINK_VERSION, > + drm_scdc_readb(hdmi->ddc, SCDC_SINK_VERSION, > &bytes); > - drm_scdc_writeb(&hdmi->i2c->adap, SCDC_SOURCE_VERSION, > + drm_scdc_writeb(hdmi->ddc, SCDC_SOURCE_VERSION, > min_t(u8, bytes, SCDC_MIN_SOURCE_VERSION)); > > /* Enabled Scrambling in the Sink */ > - drm_scdc_set_scrambling(&hdmi->i2c->adap, 1); > + drm_scdc_set_scrambling(hdmi->ddc, 1); > > /* > * To activate the scrambler feature, you must ensure > @@ -1705,7 +1709,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, > hdmi_writeb(hdmi, 0, HDMI_FC_SCRAMBLER_CTRL); > hdmi_writeb(hdmi, (u8)~HDMI_MC_SWRSTZ_TMDSSWRST_REQ, > HDMI_MC_SWRSTZ); > - drm_scdc_set_scrambling(&hdmi->i2c->adap, 0); > + drm_scdc_set_scrambling(hdmi->ddc, 0); > } > } > > -- > 2.17.1 > >