From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37084 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbeJWWjG (ORCPT ); Tue, 23 Oct 2018 18:39:06 -0400 From: Laurent Pinchart To: Daniel Vetter Cc: Souptick Joarder , noralf@tronnes.org, Gustavo Padovan , Maarten Lankhorst , sean@poorly.run, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume() Date: Tue, 23 Oct 2018 17:15:27 +0300 Message-ID: <2275810.TWHE3rLQ5u@avalon> In-Reply-To: <20181023134041.GO324@phenom.ffwll.local> References: <20180918163903.GA11172@jordon-HP-15-Notebook-PC> <20181023134041.GO324@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Daniel, On Tuesday, 23 October 2018 16:40:41 EEST Daniel Vetter wrote: > On Mon, Oct 22, 2018 at 01:51:35PM +0530, Souptick Joarder wrote: > > On Thu, Oct 11, 2018 at 1:48 PM Daniel Vetter wrote: > >> On Mon, Oct 08, 2018 at 09:57:52PM +0530, Souptick Joarder wrote: > >>> On Mon, Oct 1, 2018 at 6:12 PM Noralf Tr=F8nnes wrote: > >>>> Den 01.10.2018 13.56, skrev Laurent Pinchart: > >>>>> On Monday, 1 October 2018 09:52:20 EEST Daniel Vetter wrote: > >>>>>> On Fri, Sep 28, 2018 at 06:30:35PM +0300, Laurent Pinchart wrote: > >>>>>>> On Friday, 28 September 2018 18:05:18 EEST Laurent Pinchart wrote: > >>>>>>>> On Thursday, 27 September 2018 09:34:18 EEST Souptick Joarder=20 wrote: > >>>>>>>>> On Tue, Sep 18, 2018 at 10:05 PM Souptick Joarder wrote: > >>>>>>>>>> convert drm_atomic_helper_suspend/resume() to use > >>>>>>>>>> drm_mode_config_helper_suspend/resume(). > >>>>>>>>>>=20 > >>>>>>>>>> remove suspend_state field from the rcar_du_device > >>>>>>>>>> structure as it is no more required. > >>>>>>>>>>=20 > >>>>>>>>>> With this conversion, also > >>>>>>>>>> drm_fbdev_cma_set_suspend_unlocked() > >>>>>>>>>> will left with no consumer. So this function can be removed. > >>>>>>>>>>=20 > >>>>>>>>>> Signed-off-by: Souptick Joarder > >>>>>>>>>=20 > >>>>>>>>> Laurent, any comment on this patch ?? > >>>>>>>>=20 > >>>>>>>> Sorry for the delay, and thanks for pinging me. > >>>>>>>>=20 > >>>>>>>> Reviewed-by: Laurent Pinchart > >>>>>>>> > >>>>>>>>=20 > >>>>>>>> Should I apply this to my tree or do you plan to merge it > >>>>>>>> through drm-misc as it touches drm_fb_cma_helper.c ? > >>>>>>>=20 > >>>>>>> I just realized that the same patch got supplied by Noralf > >>>>>>> Tr=F8nnes nearly a year ago, and was later superseded by > >>>>>>> https://patchwork.freedesktop.org/patch/247861/. I think we > >>>>>>> should thus apply Noralf's patches instead (once he sends v4 > >>>>>>> out). > >>>>>>=20 > >>>>>> I don't think Noralf is still actively working on this, he's busy > >>>>>> with the fbdev emulation stuff. Probably better if you pick up > >>>>>> one of the existing ones, than waiting another year or so :-) > >>>>>=20 > >>>>> Isn't https://patchwork.freedesktop.org/patch/247861/ part of the > >>>>> fbdev emulation stuff ? That patch series is from less than a > >>>>> month ago, so I thought it was actively developed. > >>>>>=20 > >>>>> Let's ask him. Noralf, any comment ? :-) > >>>>=20 > >>>> I see now that I've caused some confusion here. > >>>>=20 > >>>> I did some refactoring of the fbdev stuff in the CMA helper last > >>>> year. In the last series of that work there is this patch: > >>>>=20 > >>>> [v3,07/11] drm/rcar-du: Use drm_mode_config_helper_suspend/resume() > >>>> https://patchwork.freedesktop.org/patch/192414/ > >>>>=20 > >>>> During Christmas I got the idea that maybe it was possible to use a > >>>> dumb buffer to do generic fbdev emulation. That work took me 6 > >>>> months before a solution using a general internal DRM client was > >>>> hammered out. By the time I started to convert drivers I had > >>>> forgotten about that patch. > >>>>=20 > >>>> When I wrote the patch (#247861) to convert rcar to the generic > >>>> fbdev, I just bundled up the suspend/resume change with the fbdev > >>>> conversion. Laurent and Sam commented on that bundling, so I said > >>>> that I would split it up in the next version. > >>>>=20 > >>>> All that being said, I think that this patch should be applied and > >>>> I'll just rebase the rcar fbdev conversion patch on top of that. > >>>> It's the easiest for me at least :-) > >>>=20 > >>> Any conclusion on this patch ? :-) > >>=20 > >> Laurent should pick it up and apply to his rcar-du tree I think. We can > >> also stuff it into drm-misc as a fallback. > >=20 > > Can we get this patch in queue for 4.20 ? >=20 > 5.1, 4.20 is already done. >=20 > But yes, I pulled this into drm-misc-next. Thanks for your patch. I would have preferred applying this through my tree. I'm currently at ELCE= =20 and had to prepare for the conference, hence the delay. > >>>>>>>>>> drivers/gpu/drm/drm_fb_cma_helper.c | 18 ------------------ > >>>>>>>>>> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 ++---------------= =2D- > >>>>>>>>>> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 - > >>>>>>>>>> include/drm/drm_fb_cma_helper.h | 2 -- > >>>>>>>>>> 4 files changed, 2 insertions(+), 40 deletions(-) =2D-=20 Regards, Laurent Pinchart