From: Dave Jiang <dave.jiang@intel.com>
To: Logan Gunthorpe <logang@deltatee.com>,
Jeff Kirsher <jkirsher@ixsystems.com>,
jdmason@kudzu.us, allenbh@gmail.com
Cc: linux-ntb@googlegroups.com, Alexander Motin <mav@ixsystems.com>
Subject: Re: [RFC] ntb/plx: Add support for PLX hardware
Date: Fri, 21 May 2021 08:22:14 -0700 [thread overview]
Message-ID: <2275dc4e-fea1-dafd-c256-0f6f32f9e3fc@intel.com> (raw)
In-Reply-To: <533937f2-7d41-7bfc-9323-e67c8d4878c9@deltatee.com>
On 5/20/2021 6:13 PM, Logan Gunthorpe wrote:
>
>
> On 2021-05-20 6:17 p.m., Jeff Kirsher wrote:
>> Is this something new that all NTB drivers are expected to adopt? Just
>> asking because I used the Intel and AMD drivers as examples and they
>> are still using pci_iomap(), etc...
> I can't speak to expectations, I'm not the gatekeeper, only a previewer
> passing by.
>
> I believe they are newer than the AMD and Intel drivers and there are
> new ones added here and there. I think generally, kernel wide, they're a
> better choice. You'll find your code will be a lot cleaner, smaller and
> easier to understand if you adopt them.
The Intel driver is pre devm allocators. Maybe one of these days when I
have time I'll clean that up and covert it. But I agree with Logan that
things will be cleaner and smaller with devm_ calls.
> Logan
next prev parent reply other threads:[~2021-05-21 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 22:23 [RFC] ntb/plx: Add support for PLX hardware Jeff Kirsher
2021-05-20 23:48 ` Logan Gunthorpe
2021-05-21 0:17 ` Jeff Kirsher
2021-05-21 1:13 ` Logan Gunthorpe
2021-05-21 1:15 ` Jeff Kirsher
2021-05-21 15:22 ` Dave Jiang [this message]
2021-05-21 18:33 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2275dc4e-fea1-dafd-c256-0f6f32f9e3fc@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jkirsher@ixsystems.com \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
--cc=mav@ixsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.