From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/enic: fix crash when changing number of Rx or Tx queues Date: Fri, 15 Jul 2016 23:28:43 +0200 Message-ID: <2276333.lY5HiAz0Gq@xps13> References: <1468185330-19713-1-git-send-email-johndale@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com To: John Daley Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id EEFEE5587 for ; Fri, 15 Jul 2016 23:28:44 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i5so45546358wmg.0 for ; Fri, 15 Jul 2016 14:28:44 -0700 (PDT) In-Reply-To: <1468185330-19713-1-git-send-email-johndale@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-10 14:15, John Daley: > The check that all Tx and Rx queues were set up was not > adequate when reconfiguring with a different number of > queues. Only the number of completion queues (CQs) was > being used to make the determination, but the CQ array > is shared between the underlying Rx and Tx queues. > > Check that the internal Rx, Tx and CQs are all set up > before completing port configuration. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar Applied, thanks