From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 19 Oct 2016 11:53:30 +0300 Subject: [PATCH 2/3] ARM: bus: da8xx-syscfg: new driver In-Reply-To: References: <1476721850-454-1-git-send-email-bgolaszewski@baylibre.com> <4369153.vCOQzI7OET@avalon> Message-ID: <2278105.geKhb8xoNC@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bartosz, On Wednesday 19 Oct 2016 10:26:57 Bartosz Golaszewski wrote: > 2016-10-18 22:49 GMT+02:00 Laurent Pinchart: > > On Monday 17 Oct 2016 18:30:49 Bartosz Golaszewski wrote: > >> Create the driver for the da8xx System Configuration and implement > >> support for writing to the three Master Priority registers. > >> > >> Signed-off-by: Bartosz Golaszewski > > [snip] > > >> + > >> +Documentation: > >> +OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf > >> + > >> +Required properties: > >> + > >> +- compatible: "ti,da850-syscfg" > > > > Don't you need a reg property ? > > Yes, Kevin already pointed that out. I'll add it in v2. Same for [1/3]. > > >> +Optional properties: > >> + > >> +The below properties are used to specify the priority of master > >> peripherals. > >> +They must be between 0-7 where 0 is the highest priority and 7 is the > >> lowest. > >> + > >> +- ti,pri-arm-i: ARM_I port priority. > >> + > >> +- ti,pri-arm-d: ARM_D port priority. > >> + > >> +- ti,pri-upp: uPP port priority. > >> + > >> +- ti,pri-sata: SATA port priority. > >> + > >> +- ti,pri-pru0: PRU0 port priority. > >> + > >> +- ti,pri-pru1: PRU1 port priority. > >> + > >> +- ti,pri-edma30tc0: EDMA3_0_TC0 port priority. > >> + > >> +- ti,pri-edma30tc1: EDMA3_0_TC1 port priority. > >> + > >> +- ti,pri-edma31tc0: EDMA3_1_TC0 port priority. > >> + > >> +- ti,pri-vpif-dma-0: VPIF DMA0 port priority. > >> + > >> +- ti,pri-vpif-dma-1: VPIF DMA1 port priority. > >> + > >> +- ti,pri-emac: EMAC port priority. > >> + > >> +- ti,pri-usb0cfg: USB0 CFG port priority. > >> + > >> +- ti,pri-usb0cdma: USB0 CDMA port priority. > >> + > >> +- ti,pri-uhpi: HPI port priority. > >> + > >> +- ti,pri-usb1: USB1 port priority. > >> + > >> +- ti,pri-lcdc: LCDC port priority. > > > > I'm afraid this looks more like system configuration than hardware > > description to me. > > While you're certainly right, this approach is already implemented in > several other memory and bus drivers and it was also suggested by > Sekhar in one of the tilcdc rev1 threads. There's also no real > alternative that I know of. The fact that other drivers get it wrong is no excuse for copying them :-) > > There was a BoF session about how to support this kind of performance > > knobs at ELCE last week: > > https://openiotelceurope2016.sched.org/event/7rss/bof-linux-device-perfor > > mance-framework-michael-turquette-baylibre :-) > > I know, I was there. ;) That's why I mentioned it :-) > Unfortunately it was just a discussion about potential approaches - > there's no code yet. Patches are welcome ;-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/3] ARM: bus: da8xx-syscfg: new driver Date: Wed, 19 Oct 2016 11:53:30 +0300 Message-ID: <2278105.geKhb8xoNC@avalon> References: <1476721850-454-1-git-send-email-bgolaszewski@baylibre.com> <4369153.vCOQzI7OET@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bartosz Golaszewski Cc: Mark Rutland , linux-devicetree , Tomi Valkeinen , Kevin Hilman , Michael Turquette , Sekhar Nori , Russell King , linux-drm , LKML , Peter Ujfalusi , Rob Herring , Jyri Sarha , Frank Rowand , arm-soc List-Id: devicetree@vger.kernel.org SGkgQmFydG9zeiwKCk9uIFdlZG5lc2RheSAxOSBPY3QgMjAxNiAxMDoyNjo1NyBCYXJ0b3N6IEdv bGFzemV3c2tpIHdyb3RlOgo+IDIwMTYtMTAtMTggMjI6NDkgR01UKzAyOjAwIExhdXJlbnQgUGlu Y2hhcnQ6Cj4gPiBPbiBNb25kYXkgMTcgT2N0IDIwMTYgMTg6MzA6NDkgQmFydG9zeiBHb2xhc3pl d3NraSB3cm90ZToKPiA+PiBDcmVhdGUgdGhlIGRyaXZlciBmb3IgdGhlIGRhOHh4IFN5c3RlbSBD b25maWd1cmF0aW9uIGFuZCBpbXBsZW1lbnQKPiA+PiBzdXBwb3J0IGZvciB3cml0aW5nIHRvIHRo ZSB0aHJlZSBNYXN0ZXIgUHJpb3JpdHkgcmVnaXN0ZXJzLgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYt Ynk6IEJhcnRvc3ogR29sYXN6ZXdza2kgPGJnb2xhc3pld3NraUBiYXlsaWJyZS5jb20+Cj4gCj4g W3NuaXBdCj4gCj4gPj4gKwo+ID4+ICtEb2N1bWVudGF0aW9uOgo+ID4+ICtPTUFQLUwxMzggKERB ODUwKSAtIGh0dHA6Ly93d3cudGkuY29tL2xpdC91Zy9zcHJ1aDgyYy9zcHJ1aDgyYy5wZGYKPiA+ PiArCj4gPj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPj4gKwo+ID4+ICstIGNvbXBhdGlibGU6 ICAgICAgICAgICAgICAgICJ0aSxkYTg1MC1zeXNjZmciCj4gPiAKPiA+IERvbid0IHlvdSBuZWVk IGEgcmVnIHByb3BlcnR5ID8KPiAKPiBZZXMsIEtldmluIGFscmVhZHkgcG9pbnRlZCB0aGF0IG91 dC4gSSdsbCBhZGQgaXQgaW4gdjIuIFNhbWUgZm9yIFsxLzNdLgo+IAo+ID4+ICtPcHRpb25hbCBw cm9wZXJ0aWVzOgo+ID4+ICsKPiA+PiArVGhlIGJlbG93IHByb3BlcnRpZXMgYXJlIHVzZWQgdG8g c3BlY2lmeSB0aGUgcHJpb3JpdHkgb2YgbWFzdGVyCj4gPj4gcGVyaXBoZXJhbHMuCj4gPj4gK1Ro ZXkgbXVzdCBiZSBiZXR3ZWVuIDAtNyB3aGVyZSAwIGlzIHRoZSBoaWdoZXN0IHByaW9yaXR5IGFu ZCA3IGlzIHRoZQo+ID4+IGxvd2VzdC4KPiA+PiArCj4gPj4gKy0gdGkscHJpLWFybS1pOiAgICAg ICAgICAgICAgQVJNX0kgcG9ydCBwcmlvcml0eS4KPiA+PiArCj4gPj4gKy0gdGkscHJpLWFybS1k OiAgICAgICAgICAgICAgQVJNX0QgcG9ydCBwcmlvcml0eS4KPiA+PiArCj4gPj4gKy0gdGkscHJp LXVwcDogICAgICAgICAgICAgICAgdVBQIHBvcnQgcHJpb3JpdHkuCj4gPj4gKwo+ID4+ICstIHRp LHByaS1zYXRhOiAgICAgICAgICAgICAgIFNBVEEgcG9ydCBwcmlvcml0eS4KPiA+PiArCj4gPj4g Ky0gdGkscHJpLXBydTA6ICAgICAgICAgICAgICAgUFJVMCBwb3J0IHByaW9yaXR5Lgo+ID4+ICsK PiA+PiArLSB0aSxwcmktcHJ1MTogICAgICAgICAgICAgICBQUlUxIHBvcnQgcHJpb3JpdHkuCj4g Pj4gKwo+ID4+ICstIHRpLHByaS1lZG1hMzB0YzA6ICBFRE1BM18wX1RDMCBwb3J0IHByaW9yaXR5 Lgo+ID4+ICsKPiA+PiArLSB0aSxwcmktZWRtYTMwdGMxOiAgRURNQTNfMF9UQzEgcG9ydCBwcmlv cml0eS4KPiA+PiArCj4gPj4gKy0gdGkscHJpLWVkbWEzMXRjMDogIEVETUEzXzFfVEMwIHBvcnQg cHJpb3JpdHkuCj4gPj4gKwo+ID4+ICstIHRpLHByaS12cGlmLWRtYS0wOiBWUElGIERNQTAgcG9y dCBwcmlvcml0eS4KPiA+PiArCj4gPj4gKy0gdGkscHJpLXZwaWYtZG1hLTE6IFZQSUYgRE1BMSBw b3J0IHByaW9yaXR5Lgo+ID4+ICsKPiA+PiArLSB0aSxwcmktZW1hYzogICAgICAgICAgICAgICBF TUFDIHBvcnQgcHJpb3JpdHkuCj4gPj4gKwo+ID4+ICstIHRpLHByaS11c2IwY2ZnOiAgICBVU0Iw IENGRyBwb3J0IHByaW9yaXR5Lgo+ID4+ICsKPiA+PiArLSB0aSxwcmktdXNiMGNkbWE6ICAgVVNC MCBDRE1BIHBvcnQgcHJpb3JpdHkuCj4gPj4gKwo+ID4+ICstIHRpLHByaS11aHBpOiAgICAgICAg ICAgICAgIEhQSSBwb3J0IHByaW9yaXR5Lgo+ID4+ICsKPiA+PiArLSB0aSxwcmktdXNiMTogICAg ICAgICAgICAgICBVU0IxIHBvcnQgcHJpb3JpdHkuCj4gPj4gKwo+ID4+ICstIHRpLHByaS1sY2Rj OiAgICAgICAgICAgICAgIExDREMgcG9ydCBwcmlvcml0eS4KPiA+IAo+ID4gSSdtIGFmcmFpZCB0 aGlzIGxvb2tzIG1vcmUgbGlrZSBzeXN0ZW0gY29uZmlndXJhdGlvbiB0aGFuIGhhcmR3YXJlCj4g PiBkZXNjcmlwdGlvbiB0byBtZS4KPiAKPiBXaGlsZSB5b3UncmUgY2VydGFpbmx5IHJpZ2h0LCB0 aGlzIGFwcHJvYWNoIGlzIGFscmVhZHkgaW1wbGVtZW50ZWQgaW4KPiBzZXZlcmFsIG90aGVyIG1l bW9yeSBhbmQgYnVzIGRyaXZlcnMgYW5kIGl0IHdhcyBhbHNvIHN1Z2dlc3RlZCBieQo+IFNla2hh ciBpbiBvbmUgb2YgdGhlIHRpbGNkYyByZXYxIHRocmVhZHMuIFRoZXJlJ3MgYWxzbyBubyByZWFs Cj4gYWx0ZXJuYXRpdmUgdGhhdCBJIGtub3cgb2YuCgpUaGUgZmFjdCB0aGF0IG90aGVyIGRyaXZl cnMgZ2V0IGl0IHdyb25nIGlzIG5vIGV4Y3VzZSBmb3IgY29weWluZyB0aGVtIDotKQoKPiA+IFRo ZXJlIHdhcyBhIEJvRiBzZXNzaW9uIGFib3V0IGhvdyB0byBzdXBwb3J0IHRoaXMga2luZCBvZiBw ZXJmb3JtYW5jZQo+ID4ga25vYnMgYXQgRUxDRSBsYXN0IHdlZWs6Cj4gPiBodHRwczovL29wZW5p b3RlbGNldXJvcGUyMDE2LnNjaGVkLm9yZy9ldmVudC83cnNzL2JvZi1saW51eC1kZXZpY2UtcGVy Zm9yCj4gPiBtYW5jZS1mcmFtZXdvcmstbWljaGFlbC10dXJxdWV0dGUtYmF5bGlicmUgOi0pCj4K PiBJIGtub3csIEkgd2FzIHRoZXJlLiA7KQoKVGhhdCdzIHdoeSBJIG1lbnRpb25lZCBpdCA6LSkK Cj4gVW5mb3J0dW5hdGVseSBpdCB3YXMganVzdCBhIGRpc2N1c3Npb24gYWJvdXQgcG90ZW50aWFs IGFwcHJvYWNoZXMgLQo+IHRoZXJlJ3Mgbm8gY29kZSB5ZXQuCgpQYXRjaGVzIGFyZSB3ZWxjb21l IDstKQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757160AbcJSJGV (ORCPT ); Wed, 19 Oct 2016 05:06:21 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:33972 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756146AbcJSJEU (ORCPT ); Wed, 19 Oct 2016 05:04:20 -0400 From: Laurent Pinchart To: Bartosz Golaszewski Cc: Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie Subject: Re: [PATCH 2/3] ARM: bus: da8xx-syscfg: new driver Date: Wed, 19 Oct 2016 11:53:30 +0300 Message-ID: <2278105.geKhb8xoNC@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: References: <1476721850-454-1-git-send-email-bgolaszewski@baylibre.com> <4369153.vCOQzI7OET@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, On Wednesday 19 Oct 2016 10:26:57 Bartosz Golaszewski wrote: > 2016-10-18 22:49 GMT+02:00 Laurent Pinchart: > > On Monday 17 Oct 2016 18:30:49 Bartosz Golaszewski wrote: > >> Create the driver for the da8xx System Configuration and implement > >> support for writing to the three Master Priority registers. > >> > >> Signed-off-by: Bartosz Golaszewski > > [snip] > > >> + > >> +Documentation: > >> +OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf > >> + > >> +Required properties: > >> + > >> +- compatible: "ti,da850-syscfg" > > > > Don't you need a reg property ? > > Yes, Kevin already pointed that out. I'll add it in v2. Same for [1/3]. > > >> +Optional properties: > >> + > >> +The below properties are used to specify the priority of master > >> peripherals. > >> +They must be between 0-7 where 0 is the highest priority and 7 is the > >> lowest. > >> + > >> +- ti,pri-arm-i: ARM_I port priority. > >> + > >> +- ti,pri-arm-d: ARM_D port priority. > >> + > >> +- ti,pri-upp: uPP port priority. > >> + > >> +- ti,pri-sata: SATA port priority. > >> + > >> +- ti,pri-pru0: PRU0 port priority. > >> + > >> +- ti,pri-pru1: PRU1 port priority. > >> + > >> +- ti,pri-edma30tc0: EDMA3_0_TC0 port priority. > >> + > >> +- ti,pri-edma30tc1: EDMA3_0_TC1 port priority. > >> + > >> +- ti,pri-edma31tc0: EDMA3_1_TC0 port priority. > >> + > >> +- ti,pri-vpif-dma-0: VPIF DMA0 port priority. > >> + > >> +- ti,pri-vpif-dma-1: VPIF DMA1 port priority. > >> + > >> +- ti,pri-emac: EMAC port priority. > >> + > >> +- ti,pri-usb0cfg: USB0 CFG port priority. > >> + > >> +- ti,pri-usb0cdma: USB0 CDMA port priority. > >> + > >> +- ti,pri-uhpi: HPI port priority. > >> + > >> +- ti,pri-usb1: USB1 port priority. > >> + > >> +- ti,pri-lcdc: LCDC port priority. > > > > I'm afraid this looks more like system configuration than hardware > > description to me. > > While you're certainly right, this approach is already implemented in > several other memory and bus drivers and it was also suggested by > Sekhar in one of the tilcdc rev1 threads. There's also no real > alternative that I know of. The fact that other drivers get it wrong is no excuse for copying them :-) > > There was a BoF session about how to support this kind of performance > > knobs at ELCE last week: > > https://openiotelceurope2016.sched.org/event/7rss/bof-linux-device-perfor > > mance-framework-michael-turquette-baylibre :-) > > I know, I was there. ;) That's why I mentioned it :-) > Unfortunately it was just a discussion about potential approaches - > there's no code yet. Patches are welcome ;-) -- Regards, Laurent Pinchart