From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 10 Mar 2015 14:42:24 +0100 Subject: [PATCH] ARM: at91: force CPU selection In-Reply-To: <20150310094209.GD9188@piout.net> References: <1425970798-14015-1-git-send-email-computersforpeace@gmail.com> <2216832.iXiqHye8YX@wuerfel> <20150310094209.GD9188@piout.net> Message-ID: <2279482.Ohk2PcyWHV@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 10 March 2015 10:42:09 Alexandre Belloni wrote: > > > > I actually added a bunch of these in other places, but have stopped > > doing so because Russell didn't like them, and I tend to follow > > his argument now that it's actually pretty confusing. > > > > In case of at91, we can do better now, once we have multiplatform > > enabled, and we can simply remove the SOC_SAM_V7 and SOC_SAM_V4_V5 > > symbols entirely (if Alexandre's patch doesn't already do that). > > > > I didn't remove it to keep the sub menus SOC_SAM_V7 -> SOC_SAMA5D4 and > SOC_SAMA5D3, SOC_SAM_V4_V5 -> SOC_AT91SAM9 and SOC_AT91RM9200. But I can > also expose SOC_AT91RM9200, SOC_AT91SAM9, SOC_SAMA5D3 and SOC_SAMA5D4 > instead of SOC_SAM_V7 and SOC_SAM_V4_V5 and remove them. Exposing multiple levels won't help here since you can never enable both v4/v5 and v7 at the same time in multiplatform. Just use one level for a 'menuconfig ARCH_AT91' entry and put the four options below that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbbCJNme (ORCPT ); Tue, 10 Mar 2015 09:42:34 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63294 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbbCJNmc (ORCPT ); Tue, 10 Mar 2015 09:42:32 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Alexandre Belloni , Nicolas Ferre , linux-kernel@vger.kernel.org, Brian Norris , Jean-Christophe Plagniol-Villard , Andrew Victor Subject: Re: [PATCH] ARM: at91: force CPU selection Date: Tue, 10 Mar 2015 14:42:24 +0100 Message-ID: <2279482.Ohk2PcyWHV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150310094209.GD9188@piout.net> References: <1425970798-14015-1-git-send-email-computersforpeace@gmail.com> <2216832.iXiqHye8YX@wuerfel> <20150310094209.GD9188@piout.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:LSk6gRG/33+e3c3mEvSgst5GEa8UJHrvSVb85eq6FGtHXFxfziM fvCa+Mui8zOD/sj3HJRDzwFFi+sW57W6FKyFjWEfcRZHZUngPyzOLr1MdNmaR3uflmeSDbG JcqyakYUqpSIeuv8BQg9DAevVuLLWlM/XBsuXjfSAUHvBd6Ts5sKc6MQx4TEtYsmzthPYoy 2K0/9vOLQFWGdKhhPPtBg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 March 2015 10:42:09 Alexandre Belloni wrote: > > > > I actually added a bunch of these in other places, but have stopped > > doing so because Russell didn't like them, and I tend to follow > > his argument now that it's actually pretty confusing. > > > > In case of at91, we can do better now, once we have multiplatform > > enabled, and we can simply remove the SOC_SAM_V7 and SOC_SAM_V4_V5 > > symbols entirely (if Alexandre's patch doesn't already do that). > > > > I didn't remove it to keep the sub menus SOC_SAM_V7 -> SOC_SAMA5D4 and > SOC_SAMA5D3, SOC_SAM_V4_V5 -> SOC_AT91SAM9 and SOC_AT91RM9200. But I can > also expose SOC_AT91RM9200, SOC_AT91SAM9, SOC_SAMA5D3 and SOC_SAMA5D4 > instead of SOC_SAM_V7 and SOC_SAM_V4_V5 and remove them. Exposing multiple levels won't help here since you can never enable both v4/v5 and v7 at the same time in multiplatform. Just use one level for a 'menuconfig ARCH_AT91' entry and put the four options below that. Arnd