From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 09/21] modetest: Allow specifying plane position Date: Mon, 25 Mar 2013 23:41:21 +0100 Message-ID: <2279969.E0Cttns2Pm@avalon> References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com> <1363704962-14077-10-git-send-email-laurent.pinchart@ideasonboard.com> <514FEB4B.90700@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id D7E3FE5C4D for ; Mon, 25 Mar 2013 15:40:34 -0700 (PDT) In-Reply-To: <514FEB4B.90700@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Archit Taneja Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Archit, On Monday 25 March 2013 11:44:35 Archit Taneja wrote: > Hi Laurent, > > On Tuesday 19 March 2013 08:25 PM, Laurent Pinchart wrote: > > Extend the -P option to allow specifying the plane x and y offsets. The > > position is optional, if not specified the plane will be positioned at > > the center of the screen as before. > > Thanks for this series. I tested the patches with a Panda ES board. > > I was facing issues with the plane position though, when I execute this > on the command line: > > ./modetest -s 12:1440x900 -P 6:(0,0)/300x200 > > I get a syntax error by bash saying it doesn't expect "(". I guess there > are ways around to get over this, I use ./modetest -s 12:1440x900 -P '6:(0,0)/300x200' > but I was wondering if we could get rid of the braces all together to keep > it simple? The "/" character could be used to figure out whether the user > has also mentioned position or not. It makes parsing the option a bit more complex, but I can do that if you think it's better. -- Regards, Laurent Pinchart