From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/bonding: not handle vlan slow packet Date: Tue, 1 Nov 2016 10:46:39 +0000 Message-ID: <227a3391-019d-3a4c-e76f-d1775466261b@intel.com> References: <1477885947-35804-1-git-send-email-haifeng.lin@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit To: linhaifeng , dev@dpdk.org, declan.doherty@intel.com Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 372FB2A58 for ; Tue, 1 Nov 2016 11:46:41 +0100 (CET) In-Reply-To: <1477885947-35804-1-git-send-email-haifeng.lin@huawei.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Haifeng, On 10/31/2016 3:52 AM, linhaifeng wrote: > From: Haifeng Lin > > if rx vlan offload is enable we should not handle vlan slow > packets too. > > Signed-off-by: Haifeng Lin > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 09ce7bf..ca17898 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -169,7 +169,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, > /* Remove packet from array if it is slow packet or slave is not > * in collecting state or bondign interface is not in promiscus > * mode and packet address does not match. */ > - if (unlikely(hdr->ether_type == ether_type_slow_be || > + if (unlikely((hdr->ether_type == ether_type_slow_be && > + !bufs[j]->vlan_tci) || > !collecting || (!promisc && > !is_multicast_ether_addr(&hdr->d_addr) && > !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) { > There are a few version of this patch, I guess this one is the correct one, can you please confirm? Also this one supersede following one, right? http://dpdk.org/dev/patchwork/patch/16840/ It helps a lot if you use versioning in the patches [PATCH -vN] and add a description of changes in commit log (after "---") between patch versions. Thanks, ferruh