From: David Ahern <dsahern@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>,
netdev@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net-next] net: remove redundant check in ip_metrics_convert()
Date: Thu, 3 Nov 2022 21:15:52 -0600 [thread overview]
Message-ID: <227cb15b-40ca-e674-6dca-a05699a64d8a@kernel.org> (raw)
In-Reply-To: <20221104022513.168868-1-shaozhengchao@huawei.com>
On 11/3/22 8:25 PM, Zhengchao Shao wrote:
> Now ip_metrics_convert() is only called by ip_fib_metrics_init(). Before
> ip_fib_metrics_init() invokes ip_metrics_convert(), it checks whether
> input parameter fc_mx is NULL. Therefore, ip_metrics_convert() doesn't
> need to check fc_mx.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> net/ipv4/metrics.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-11-04 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 2:25 [PATCH net-next] net: remove redundant check in ip_metrics_convert() Zhengchao Shao
2022-11-04 3:15 ` David Ahern [this message]
2022-11-05 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=227cb15b-40ca-e674-6dca-a05699a64d8a@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.