All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
	"Jiang, JunyuX" <junyux.jiang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Jiang, JunyuX" <junyux.jiang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] examples/vmdq: fix RSS	configuration
Date: Fri, 3 Apr 2020 03:15:12 +0000	[thread overview]
Message-ID: <227f31abc5af4e5b81737d0192def807@intel.com> (raw)
In-Reply-To: <dcc3d1941edc4488b67c92f7dc159341@intel.com>

> > > +	rss_hf_tmp = port_conf.rx_adv_conf.rss_conf.rss_hf;
> > > +	port_conf.rx_adv_conf.rss_conf.rss_hf &=
> > > +		dev_info.flow_type_rss_offloads;
> > > +	if (port_conf.rx_adv_conf.rss_conf.rss_hf != rss_hf_tmp) {
> > > +		printf("Port %u modified RSS hash function based on hardware
> > support,"
> >
> > This is RSS offload type but not hash function.
> 
> * The *rss_hf* field of the *rss_conf* structure indicates the different
>  * types of IPv4/IPv6 packets to which the RSS hashing must be applied.
>  * Supplying an *rss_hf* equal to zero disables the RSS feature.
> 
> And in testpmd, it's the same.
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> 				rss_hf & port->dev_info.flow_type_rss_offloads;

OK. I got, the definition of rss_hf at the beginning might be hash function which also the same as RSS offload type.
Ignore my comments then.

BTW hash function is also indicating TOEPLITZ/XOR... in somewhere. 


Thanks
Jingjng

  reply	other threads:[~2020-04-03  3:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  9:16 [dpdk-dev] [PATCH] examples/vmdq: fix RSS configuration Junyu Jiang
2020-03-05  2:02 ` Li, Xiaoyun
2020-03-27  8:33   ` Han, YingyaX
2020-03-09 16:44 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-03-25  6:32 ` [dpdk-dev] [PATCH v2 0/2] " Junyu Jiang
2020-03-25  6:32   ` [dpdk-dev] [PATCH v2 1/2] doc: add user guide for VMDq Junyu Jiang
2020-04-03  0:11     ` Wu, Jingjing
2020-03-25  6:32   ` [dpdk-dev] [PATCH v2 2/2] examples/vmdq: fix RSS configuration Junyu Jiang
2020-03-30  2:35     ` Han, YingyaX
2020-04-03  0:08     ` Wu, Jingjing
2020-04-03  1:35       ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2020-04-03  3:15         ` Wu, Jingjing [this message]
2020-03-26  1:36   ` [dpdk-dev] [PATCH v2 0/2] " Han, YingyaX
2020-04-07 16:07   ` Ferruh Yigit
2020-04-22 13:56   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=227f31abc5af4e5b81737d0192def807@intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=junyux.jiang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.