From: "Duje Mihanović" <duje@dujemihanovic.xyz>
To: David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Karel Balej" <balejk@matfyz.cz>, "Lee Jones" <lee@kernel.org>,
"David Wronek" <david@mainlining.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC
Date: Sat, 30 Aug 2025 15:07:12 +0200 [thread overview]
Message-ID: <22825864.EfDdHjke4D@radijator> (raw)
In-Reply-To: <CAHp75Vd+hAucOyjqLj=rY3oLSySiReVupRQdBjwoLQSPAZMNMQ@mail.gmail.com>
On Saturday, 30 August 2025 06:41:58 Central European Summer Time Andy
Shevchenko wrote:
> On Sat, Aug 30, 2025 at 7:37 AM Andy Shevchenko
>
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Aug 29, 2025 at 2:41 AM David Lechner <dlechner@baylibre.com>
wrote:
> > > On 8/28/25 5:17 PM, Duje Mihanović wrote:
> ...
>
> > > > + ret = regmap_bulk_read(*map, regs[chan], buf, 2);
>
> On top, please drop a double pointer and use map directly. That's
> already a pointer, what's the issue with it to begin with?
struct regmap is only defined in a regmap-internal header, so it has to
be a double pointer or a struct containing a regmap pointer. I went
with David's advice and created this struct.
Regards,
--
Duje
next prev parent reply other threads:[~2025-08-30 13:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 22:17 [PATCH 0/2] Marvell 88PM886 PMIC GPADC driver Duje Mihanović
2025-08-28 22:17 ` [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC Duje Mihanović
2025-08-28 23:40 ` David Lechner
2025-08-29 15:20 ` Duje Mihanović
2025-08-29 15:52 ` David Lechner
2025-08-30 4:37 ` Andy Shevchenko
2025-08-30 4:41 ` Andy Shevchenko
2025-08-30 13:07 ` Duje Mihanović [this message]
2025-08-30 15:05 ` Andy Shevchenko
2025-08-30 19:41 ` Jonathan Cameron
2025-08-30 13:03 ` Duje Mihanović
2025-08-30 14:53 ` Andy Shevchenko
2025-08-30 16:29 ` Duje Mihanović
2025-08-29 16:27 ` Jonathan Cameron
2025-08-29 17:40 ` Duje Mihanović
2025-08-29 20:38 ` Karel Balej
2025-08-28 22:17 ` [PATCH 2/2] mfd: 88pm886: Add GPADC cell Duje Mihanović
2025-08-29 15:47 ` Andy Shevchenko
2025-08-29 20:30 ` Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22825864.EfDdHjke4D@radijator \
--to=duje@dujemihanovic.xyz \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=balejk@matfyz.cz \
--cc=david@mainlining.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.