All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com
Subject: Re: [PATCH v2] service: fix shifts to operate on 64 bit integers
Date: Mon, 31 Jul 2017 22:12:47 +0200	[thread overview]
Message-ID: <2283012.f371VpG1HL@xps> (raw)
In-Reply-To: <1501519135-122347-1-git-send-email-harry.van.haaren@intel.com>

31/07/2017 18:38, Harry van Haaren:
> This commit fixes shifts to an integer (1 << shift) which
> is assumed to be a 32-bit integer. In this case, the shift is
> variable and expected to be valid for 64-bit integers. Given that
> the expectation to work with 64 bits exists, we must ensure that
> the (1 << shift) one in that formula is actually a uin64_t.
> 
> The UINT64_C() macro portably adds the correct suffix to a constant,
> informing the compiler that the value is to be assigned 64 bits.
> 
> The issue would only manifests when there were greater than 31
> services registered.
> 
> Fixes: 21698354c832 ("service: introduce service cores concept")
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks

      reply	other threads:[~2017-07-31 20:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 15:58 [PATCH] service: fix shifts to operate on 64 bit integers Harry van Haaren
2017-07-31 16:17 ` Gaëtan Rivet
2017-07-31 16:20   ` Van Haaren, Harry
2017-07-31 16:38 ` [PATCH v2] " Harry van Haaren
2017-07-31 20:12   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2283012.f371VpG1HL@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.