All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Michał Krawczyk" <mk@semihalf.com>
Cc: stable@dpdk.org, Maciej Bielski <mba@semihalf.com>,
	dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
	Guy Tzalik <gtzalik@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Eduard Serra <eduser25@gmail.com>,
	igorc.mail@gmail.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ena: fix L4 cksum flags condition for TX
Date: Mon, 05 Aug 2019 19:44:25 +0200	[thread overview]
Message-ID: <2289104.F6p8LDoDFh@xps> (raw)
In-Reply-To: <CAJMMOfN02+EeKGjz9OP+aoF368m38rMtdjzkHpg0M1eub86_cw@mail.gmail.com>

01/08/2019 14:08, Michał Krawczyk:
> czw., 1 sie 2019 o 13:45 Maciej Bielski <mba@semihalf.com> napisał(a):
> >
> > During an if-condition evaluation, a 2-bit flag evaluates to 'true' for
> > '0x1', '0x2' and '0x3'. Thus, from this perspective these flags are
> > indistinguishable. To make them distinct, respective bits must be
> > extracted with a mask and then checked for strict equality.
> >
> > Specifically here, even if `PKT_TX_UDP_CKSUM` (value '0x3') was set, the
> > expression `mbuf->ol_flags & PKT_TX_TCP` (the second flag of value
> > '0x1') is evaluated first and the result is 'true'. In consequence, for
> > UDP packets the execution flow enters an incorrect branch.
> >
> > Fixes: 56b8b9b7e5d2 (net/ena: convert to new Tx offloads API)
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Maciej Bielski <mba@semihalf.com>
> > Reported-by: Eduard Serra <eduser25@gmail.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>

Applied, thanks




      reply	other threads:[~2019-08-05 17:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 11:45 [dpdk-dev] [PATCH] net/ena: fix L4 cksum flags condition for TX Maciej Bielski
2019-08-01 12:08 ` Michał Krawczyk
2019-08-05 17:44   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2289104.F6p8LDoDFh@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=eduser25@gmail.com \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=igorc.mail@gmail.com \
    --cc=mba@semihalf.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.