From: Vlastimil Babka <vbabka@suse.cz>
To: Kuan-Wei Chiu <visitorckw@gmail.com>, akpm@linux-foundation.org
Cc: cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev,
harry.yoo@oracle.com, glittao@gmail.com, jserv@ccns.ncku.edu.tw,
chuang@cs.nycu.edu.tw, cfmc.cs13@nycu.edu.tw,
jhcheng.cs13@nycu.edu.tw, c.yuanhaur@wustl.edu,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] mm/slub: Fix debugfs stack trace sorting and simplify sort call
Date: Wed, 27 Aug 2025 11:55:46 +0200 [thread overview]
Message-ID: <229010f4-a68c-400a-94bf-4532ee451ef5@suse.cz> (raw)
In-Reply-To: <20250826062315.644520-1-visitorckw@gmail.com>
On 8/26/25 08:23, Kuan-Wei Chiu wrote:
> Fix the comparison function used for sorting stack trace locations in
> the slub debugfs interface. The original implementation violated the
> antisymmetry property required by sort(), which could lead to
> unreliable ordering of the output. The patches correct the comparison
> function to return 0 when counts are equal and replace the unnecessary
> use of sort_r() with the simpler sort().
> ---
> Changes in v2:
> * Use cmp_int().
> * Drop Cc stable.
>
> v1: https://lore.kernel.org/lkml/20250825013419.240278-1-visitorckw@gmail.com/
>
> Kuan-Wei Chiu (2):
> mm/slub: Fix cmp_loc_by_count() to return 0 when counts are equal
> mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting
Applied to slab/for-next, thanks!
> mm/slub.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
prev parent reply other threads:[~2025-08-27 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 6:23 [PATCH v2 0/2] mm/slub: Fix debugfs stack trace sorting and simplify sort call Kuan-Wei Chiu
2025-08-26 6:23 ` [PATCH v2 1/2] mm/slub: Fix cmp_loc_by_count() to return 0 when counts are equal Kuan-Wei Chiu
2025-08-29 2:13 ` Harry Yoo
2025-08-26 6:23 ` [PATCH v2 2/2] mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting Kuan-Wei Chiu
2025-08-29 2:14 ` Harry Yoo
2025-08-27 9:55 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229010f4-a68c-400a-94bf-4532ee451ef5@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=c.yuanhaur@wustl.edu \
--cc=cfmc.cs13@nycu.edu.tw \
--cc=chuang@cs.nycu.edu.tw \
--cc=cl@gentwo.org \
--cc=glittao@gmail.com \
--cc=harry.yoo@oracle.com \
--cc=jhcheng.cs13@nycu.edu.tw \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.