From: Thomas Monjalon <thomas@monjalon.net>
To: guohongzhi1@huawei.com
Cc: dev@dpdk.org, olivier.matz@6wind.com, mb@smartsharesystems.com,
konstantin.ananyev@intel.com, jiayu.hu@intel.com,
ferruh.yigit@intel.com, nicolas.chautru@intel.com,
cristian.dumitrescu@intel.com, zhoujingbin@huawei.com,
chenchanghu@huawei.com, jerry.lilijun@huawei.com,
haifeng.lin@huawei.com
Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating
Date: Sun, 24 May 2020 17:12:27 +0200 [thread overview]
Message-ID: <2292747.XxK6CxzJO9@thomas> (raw)
In-Reply-To: <20200515130850.12760-1-guohongzhi1@huawei.com>
15/05/2020 15:08, guohongzhi:
> 1.rte_ipv4_cksum will return invalid checksum value like 0xffff.(rfc1624)
> 2.__rte_raw_cksum should consider Big Endian.
> 3.checksum 0x0000 is invalid for udp, but valid for tcp.(rfc768)
Please consider doing 3 patches, thanks.
It was sent late for 20.05, I prefer not taking any risk,
and wait for maintainers approval.
The patches must be reviewed and discussed in 20.08 timeframe.
next prev parent reply other threads:[~2020-05-24 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 13:08 [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating guohongzhi
2020-05-15 13:48 ` Morten Brørup
2020-05-24 15:12 ` Thomas Monjalon [this message]
2020-05-24 15:31 ` Morten Brørup
2020-05-24 15:39 ` Thomas Monjalon
2020-05-24 16:25 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksumcalculating Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2292747.XxK6CxzJO9@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.