From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear' Date: Wed, 07 Aug 2013 13:16:21 +0200 Message-ID: <229314766.ZCcIACZPNp@avalon> References: <5202032e.Bh5xEyiO9yK+nGxr%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 6450DE5FC7 for ; Wed, 7 Aug 2013 04:15:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Dave Airlie , kbuild test robot , kbuild-all@01.org List-Id: dri-devel@lists.freedesktop.org Hi David, On Wednesday 07 August 2013 11:57:54 David Herrmann wrote: > On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot wrote: > > tree: git://people.freedesktop.org/~danvet/drm-intel.git > > drm-intel-nightly head: 3224cf6c3ee5ab9c280052c9fbed4f660310c411 > > commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move > > AGP cleanup paths to drm_agpsupport.c config: x86_64-randconfig-a02-0807 > > (attached as .config) > > > > All error/warnings: > > drivers/built-in.o: In function `drm_lastclose': > >>> (.text+0x904a0): undefined reference to `drm_agp_clear' > > We called drm_agp_release() in the same code-path before. How did that > work without CONFIG_AGP? Ugh, *confused* drm_agp_release() was only called if drm_core_has_AGP() was true, and that function is defined as a macro that just returns 0 when __OS_HAS_AGP isn't defined. The compiler thus optimized the drm_agp_release() call away. -- Regards, Laurent Pinchart