From: Richard Weinberger <richard@sigma-star.at>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, netdev@vger.kernel.org,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Subject: Re: [PATCH bpf 2/3] bpf: fix build issues on um due to mising bpf_perf_event.h
Date: Tue, 12 Dec 2017 08:55:13 +0100 [thread overview]
Message-ID: <22932655.glUV7elTyr@blindfold> (raw)
In-Reply-To: <20171212012532.30268-3-daniel@iogearbox.net>
Am Dienstag, 12. Dezember 2017, 02:25:31 CET schrieb Daniel Borkmann:
> Since c895f6f703ad ("bpf: correct broken uapi for
> BPF_PROG_TYPE_PERF_EVENT program type") um (uml) won't build
> on i386 or x86_64:
>
> [...]
> CC init/main.o
> In file included from ../include/linux/perf_event.h:18:0,
> from ../include/linux/trace_events.h:10,
> from ../include/trace/syscall.h:7,
> from ../include/linux/syscalls.h:82,
> from ../init/main.c:20:
> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error:
> asm/bpf_perf_event.h: No such file or directory #include
> <asm/bpf_perf_event.h>
> [...]
>
> Lets add missing bpf_perf_event.h also to um arch. This seems
> to be the only one still missing.
>
> Fixes: c895f6f703ad ("bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT
> program type") Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Richard Weinberger <richard@sigma-star.at>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> Cc: Richard Weinberger <richard@sigma-star.at>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> ---
> arch/um/include/asm/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/include/asm/Kbuild b/arch/um/include/asm/Kbuild
> index 50a32c3..73c57f6 100644
> --- a/arch/um/include/asm/Kbuild
> +++ b/arch/um/include/asm/Kbuild
> @@ -1,4 +1,5 @@
> generic-y += barrier.h
> +generic-y += bpf_perf_event.h
> generic-y += bug.h
> generic-y += clkdev.h
> generic-y += current.h
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
--
sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria
ATU66964118 - FN 374287y
next prev parent reply other threads:[~2017-12-12 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 1:25 [PATCH bpf 0/3] Misc BPF fixes Daniel Borkmann
2017-12-12 1:25 ` [PATCH bpf 1/3] bpf: fix corruption on concurrent perf_event_output calls Daniel Borkmann
2017-12-12 1:25 ` [PATCH bpf 2/3] bpf: fix build issues on um due to mising bpf_perf_event.h Daniel Borkmann
2017-12-12 7:55 ` Richard Weinberger [this message]
2017-12-12 1:25 ` [PATCH bpf 3/3] bpf: fix broken BPF selftest build Daniel Borkmann
2017-12-18 9:28 ` Hendrik Brueckner
2017-12-18 10:50 ` Daniel Borkmann
2017-12-12 18:07 ` [PATCH bpf 0/3] Misc BPF fixes Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22932655.glUV7elTyr@blindfold \
--to=richard@sigma-star.at \
--cc=ast@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.