From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313EB3EE1FD for ; Mon, 29 Jun 2026 08:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782720953; cv=none; b=JhhOAHtbz2oAdoSRTxzs5icWDbXfei+hrpJKVn9H7BrRzn7xDRV0phIPnDNYxC2Bpwk9ZkJUX64ltICbn/3gTS89gFtmaKV6Qqa2gGkt54Em4PGGlS09D38dMCJKaV+RIAoGBhtbiRJMfjPD1MX/9q2u4iv8etcCRcq47zwDEbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782720953; c=relaxed/simple; bh=QI9R0eS7nUwY6qBrk5bTZtoyBCqFqprL3pqH+d/REb0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RrcNJShNhN/6fJHr64jSzf6unX2R+n6KMTJ6zrFSjU/936VkvHUdmkQIIAztxr6KIJ8Dg8QQj6duyEAYH+xy/IHjEUOmbsU3Uc2WBEP1VJb+EsUY6siFV+tcd87+cmMBbpEPr8YZmK4TXNyczqGtrViNRe+S7ZeN9FdkhH0OnWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QBMPbCQv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QBMPbCQv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9735D1F000E9; Mon, 29 Jun 2026 08:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782720949; bh=JtMbXTDOfzndkZDer6uzHrvmb1CYxZ6yVGY/SmOu0IE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=QBMPbCQvs8hYi+N2xX2u0QDcm1wrcGDS5O2DtLv065DQclG99S1G9A5HOq4J1OJwP isEkn2hV9P3LbgfwQet+yfkqrMwb/pq45HV+O0r/ES7Eh9cTsvdDqOzm3HTgmpzSEs RNY4dpenZXlcPovycZKcE5kcUP0PDqr8SYDaVaNnK8J+mISy8EDMblt3sNUa2Emc0P 66VhmyI95dDgAVtNcUiUMKNN0Qcy+ibLbD/WvKjOy3r/LfktR3w+D21HmkF3oIMBSz eSccLWkHJMSEhSo2GPeiGCh0NCrNj5cbbl+iT4BhhF9d0b2Djqlf634fpD1O29TKye 0faJpaQAgxpVQ== Message-ID: <2293328e-ae86-4568-9353-7f4d2cdfc415@kernel.org> Date: Mon, 29 Jun 2026 10:15:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] mm/page_owner: drop redundant page_owner prefix from static symbols Content-Language: en-US To: Ye Liu , Andrew Morton Cc: Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260626024550.25677-1-ye.liu@linux.dev> <20260626024550.25677-7-ye.liu@linux.dev> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <20260626024550.25677-7-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/26/26 04:45, Ye Liu wrote: > All of these symbols are file-scoped (static) in page_owner.c, so the > page_owner_ prefix is pure noise. Rename them to shorter, still-clear > names: > > page_owner_stack_op -> stack_op > page_owner_stack_open -> stack_open > page_owner_stack_fops -> stack_fops > page_owner_pages_threshold -> pages_threshold > page_owner_threshold_get -> threshold_get > page_owner_threshold_set -> threshold_set > page_owner_threshold_fops -> threshold_fops > > No functional change. > > Signed-off-by: Ye Liu Reviewed-by: Vlastimil Babka (SUSE) Nit: > -static int page_owner_threshold_set(void *data, u64 val) > +static int threshold_set(void *data, u64 val) > { > - WRITE_ONCE(page_owner_pages_threshold, val); > + WRITE_ONCE(pages_threshold, val); > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(page_owner_threshold_fops, &page_owner_threshold_get, > - &page_owner_threshold_set, "%llu\n"); > - > +DEFINE_SIMPLE_ATTRIBUTE(threshold_fops, &threshold_get, > + &threshold_set, "%llu\n"); We can now do make it a single line? 82 characters are fine unless hch sees this. checkpatch now warns on 100 chars > > static int __init pageowner_init(void) > { > @@ -999,17 +998,17 @@ static int __init pageowner_init(void) > debugfs_create_file("show_stacks", 0400, dir, > (void *)(STACK_PRINT_FLAG_STACK | > STACK_PRINT_FLAG_PAGES), > - &page_owner_stack_fops); > + &stack_fops); > debugfs_create_file("show_handles", 0400, dir, > (void *)(STACK_PRINT_FLAG_HANDLE | > STACK_PRINT_FLAG_PAGES), > - &page_owner_stack_fops); > + &stack_fops); > debugfs_create_file("show_stacks_handles", 0400, dir, > (void *)(STACK_PRINT_FLAG_STACK | > STACK_PRINT_FLAG_HANDLE), > - &page_owner_stack_fops); > + &stack_fops); > debugfs_create_file("count_threshold", 0600, dir, NULL, > - &page_owner_threshold_fops); > + &threshold_fops); > return 0; > } > late_initcall(pageowner_init)