diff for duplicates of <22951681.102711393197819005.JavaMail.weblogic@epml01> diff --git a/a/1.txt b/N1/1.txt index 9a3fee7..7f2f829 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,37 @@ -T24gRnJpZGF5LCBGZWJydWFyeSAyMSwgMjAxNCA2OjE1IFBNLCBmdWdhbmcuZHVhbkBmcmVlc2Nh -bGUuY29tIHdyb3RlOg0KPiANCj4gRnJvbTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv -cmFjbGUuY29tPg0KPiBEYXRhOiBGcmlkYXksIEZlYnJ1YXJ5IDIxLCAyMDE0IDQ6NTUgUE0NCj4g -DQo+ID5UbzogRG1pdHJ5IFRvcm9raG92DQo+ID5DYzogUGF1bCBHb3J0bWFrZXI7IEppbmdvbyBI -YW47IER1YW4gRnVnYW5nLUIzODYxMTsgQmVuc29uIExldW5nOyBEYW5pZWwgS3VydHo7DQo+ID5s -aW51eC1pbnB1dEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5v -cmcNCj4gPlN1YmplY3Q6IFtwYXRjaF0gSW5wdXQ6IHJlbW92ZSBhIGR1cGxpY2F0aXZlIE5VTEwg -dGVzdA0KPiA+DQo+ID4icGRhdGEiIGlzIG5vbi1OVUxMIGhlcmUuICBXZSB2ZXJpZmllZCB0aGF0 -IGF0IHRoZSBzdGFydCBvZiB0aGUgZnVuY3Rpb24uDQo+ID4NCj4gPlNpZ25lZC1vZmYtYnk6IERh -biBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCj4gPg0KPiA+ZGlmZiAtLWdp -dCBhL2RyaXZlcnMvaW5wdXQvdG91Y2hzY3JlZW4vYXRtZWxfbXh0X3RzLmMNCj4gPmIvZHJpdmVy -cy9pbnB1dC90b3VjaHNjcmVlbi9hdG1lbF9teHRfdHMuYw0KPiA+aW5kZXggYTcwNDAwNzU0ZTky -Li40MGFiZTkwY2M5MjQgMTAwNjQ0DQo+ID4tLS0gYS9kcml2ZXJzL2lucHV0L3RvdWNoc2NyZWVu -L2F0bWVsX214dF90cy5jDQo+ID4rKysgYi9kcml2ZXJzL2lucHV0L3RvdWNoc2NyZWVuL2F0bWVs -X214dF90cy5jDQo+ID5AQCAtMTE0Niw3ICsxMTQ2LDcgQEAgc3RhdGljIGludCBteHRfcHJvYmUo -c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwNCj4gPiAJCWdvdG8gZXJyX2ZyZWVfbWVtOw0KPiA+ -IAl9DQo+ID4NCj4gPi0JZGF0YS0+aXNfdHAgPSBwZGF0YSAmJiBwZGF0YS0+aXNfdHA7DQo+ID4r -CWRhdGEtPmlzX3RwID0gcGRhdGEtPmlzX3RwOw0KPiA+DQo+ID4gCWlucHV0X2Rldi0+bmFtZSA9 -IChkYXRhLT5pc190cCkgPyAiQXRtZWwgbWFYVG91Y2ggVG91Y2hwYWQiIDoNCj4gPiAJCQkJCSAg -IkF0bWVsIG1hWFRvdWNoIFRvdWNoc2NyZWVuIjsNCj4gPg0KPiBBZ3JlZSwgaXQgaXMgcmVkdW5k -YW50LiBBbmQgaWYgeW91IGhhdmUgZnJlZSB0aW1lLCB5b3UgY2FuIGNvbnZlcnQgdGhlIGRyaXZl -ciB0byBzdXBwb3J0IGRldmljZXRyZWUuDQo+IA0KPiBBY2tlZC1ieTogRnVnYW5nIER1YW4gPEIz -ODYxMUBmcmVlc2NhbGUuY29tPg0KDQpSZXZpZXdlZC1ieTogSmluZ29vIEhhbiA8amcxLmhhbkBz -YW1zdW5nLmNvbT4NCg0KQmVzdCByZWdhcmRzLA0KSmluZ29vIEhhbg0K +On Friday, February 21, 2014 6:15 PM, fugang.duan@freescale.com wrote: +> +> From: Dan Carpenter <dan.carpenter@oracle.com> +> Data: Friday, February 21, 2014 4:55 PM +> +> >To: Dmitry Torokhov +> >Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel Kurtz; +> >linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org +> >Subject: [patch] Input: remove a duplicative NULL test +> > +> >"pdata" is non-NULL here. We verified that at the start of the function. +> > +> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> > +> >diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c +> >b/drivers/input/touchscreen/atmel_mxt_ts.c +> >index a70400754e92..40abe90cc924 100644 +> >--- a/drivers/input/touchscreen/atmel_mxt_ts.c +> >+++ b/drivers/input/touchscreen/atmel_mxt_ts.c +> >@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client, +> > goto err_free_mem; +> > } +> > +> >- data->is_tp = pdata && pdata->is_tp; +> >+ data->is_tp = pdata->is_tp; +> > +> > input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" : +> > "Atmel maXTouch Touchscreen"; +> > +> Agree, it is redundant. And if you have free time, you can convert the driver to support devicetree. +> +> Acked-by: Fugang Duan <B38611@freescale.com> + +Reviewed-by: Jingoo Han <jg1.han@samsung.com> + +Best regards, +Jingoo Han diff --git a/a/content_digest b/N1/content_digest index 78cb237..8cb63fc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,6 @@ - "ref\020140221085506.GB13185@elgon.mountain\0" "From\0Jingoo Han <jg1.han@samsung.com>\0" "Subject\0Re: [patch] Input: remove a duplicative NULL test\0" - "Date\0Sun, 23 Feb 2014 23:23:42 +0000\0" + "Date\0Sun, 23 Feb 2014 23:23:42 +0000 (GMT)\0" "To\0fugang.duan@freescale.com <fugang.duan@freescale.com>" Dan Carpenter <dan.carpenter@oracle.com> " Dmitry Torokhov <dmitry.torokhov@gmail.com>\0" @@ -13,29 +12,42 @@ " Jingoo Han <jg1.han@samsung.com>\0" "\00:1\0" "b\0" - "T24gRnJpZGF5LCBGZWJydWFyeSAyMSwgMjAxNCA2OjE1IFBNLCBmdWdhbmcuZHVhbkBmcmVlc2Nh\n" - "bGUuY29tIHdyb3RlOg0KPiANCj4gRnJvbTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv\n" - "cmFjbGUuY29tPg0KPiBEYXRhOiBGcmlkYXksIEZlYnJ1YXJ5IDIxLCAyMDE0IDQ6NTUgUE0NCj4g\n" - "DQo+ID5UbzogRG1pdHJ5IFRvcm9raG92DQo+ID5DYzogUGF1bCBHb3J0bWFrZXI7IEppbmdvbyBI\n" - "YW47IER1YW4gRnVnYW5nLUIzODYxMTsgQmVuc29uIExldW5nOyBEYW5pZWwgS3VydHo7DQo+ID5s\n" - "aW51eC1pbnB1dEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5v\n" - "cmcNCj4gPlN1YmplY3Q6IFtwYXRjaF0gSW5wdXQ6IHJlbW92ZSBhIGR1cGxpY2F0aXZlIE5VTEwg\n" - "dGVzdA0KPiA+DQo+ID4icGRhdGEiIGlzIG5vbi1OVUxMIGhlcmUuICBXZSB2ZXJpZmllZCB0aGF0\n" - "IGF0IHRoZSBzdGFydCBvZiB0aGUgZnVuY3Rpb24uDQo+ID4NCj4gPlNpZ25lZC1vZmYtYnk6IERh\n" - "biBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCj4gPg0KPiA+ZGlmZiAtLWdp\n" - "dCBhL2RyaXZlcnMvaW5wdXQvdG91Y2hzY3JlZW4vYXRtZWxfbXh0X3RzLmMNCj4gPmIvZHJpdmVy\n" - "cy9pbnB1dC90b3VjaHNjcmVlbi9hdG1lbF9teHRfdHMuYw0KPiA+aW5kZXggYTcwNDAwNzU0ZTky\n" - "Li40MGFiZTkwY2M5MjQgMTAwNjQ0DQo+ID4tLS0gYS9kcml2ZXJzL2lucHV0L3RvdWNoc2NyZWVu\n" - "L2F0bWVsX214dF90cy5jDQo+ID4rKysgYi9kcml2ZXJzL2lucHV0L3RvdWNoc2NyZWVuL2F0bWVs\n" - "X214dF90cy5jDQo+ID5AQCAtMTE0Niw3ICsxMTQ2LDcgQEAgc3RhdGljIGludCBteHRfcHJvYmUo\n" - "c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwNCj4gPiAJCWdvdG8gZXJyX2ZyZWVfbWVtOw0KPiA+\n" - "IAl9DQo+ID4NCj4gPi0JZGF0YS0+aXNfdHAgPSBwZGF0YSAmJiBwZGF0YS0+aXNfdHA7DQo+ID4r\n" - "CWRhdGEtPmlzX3RwID0gcGRhdGEtPmlzX3RwOw0KPiA+DQo+ID4gCWlucHV0X2Rldi0+bmFtZSA9\n" - "IChkYXRhLT5pc190cCkgPyAiQXRtZWwgbWFYVG91Y2ggVG91Y2hwYWQiIDoNCj4gPiAJCQkJCSAg\n" - "IkF0bWVsIG1hWFRvdWNoIFRvdWNoc2NyZWVuIjsNCj4gPg0KPiBBZ3JlZSwgaXQgaXMgcmVkdW5k\n" - "YW50LiBBbmQgaWYgeW91IGhhdmUgZnJlZSB0aW1lLCB5b3UgY2FuIGNvbnZlcnQgdGhlIGRyaXZl\n" - "ciB0byBzdXBwb3J0IGRldmljZXRyZWUuDQo+IA0KPiBBY2tlZC1ieTogRnVnYW5nIER1YW4gPEIz\n" - "ODYxMUBmcmVlc2NhbGUuY29tPg0KDQpSZXZpZXdlZC1ieTogSmluZ29vIEhhbiA8amcxLmhhbkBz\n" - YW1zdW5nLmNvbT4NCg0KQmVzdCByZWdhcmRzLA0KSmluZ29vIEhhbg0K + "On Friday, February 21, 2014 6:15 PM, fugang.duan@freescale.com wrote:\n" + "> \n" + "> From: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> Data: Friday, February 21, 2014 4:55 PM\n" + "> \n" + "> >To: Dmitry Torokhov\n" + "> >Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel Kurtz;\n" + "> >linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org\n" + "> >Subject: [patch] Input: remove a duplicative NULL test\n" + "> >\n" + "> >\"pdata\" is non-NULL here. We verified that at the start of the function.\n" + "> >\n" + "> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> >\n" + "> >diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c\n" + "> >b/drivers/input/touchscreen/atmel_mxt_ts.c\n" + "> >index a70400754e92..40abe90cc924 100644\n" + "> >--- a/drivers/input/touchscreen/atmel_mxt_ts.c\n" + "> >+++ b/drivers/input/touchscreen/atmel_mxt_ts.c\n" + "> >@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client,\n" + "> > \t\tgoto err_free_mem;\n" + "> > \t}\n" + "> >\n" + "> >-\tdata->is_tp = pdata && pdata->is_tp;\n" + "> >+\tdata->is_tp = pdata->is_tp;\n" + "> >\n" + "> > \tinput_dev->name = (data->is_tp) ? \"Atmel maXTouch Touchpad\" :\n" + "> > \t\t\t\t\t \"Atmel maXTouch Touchscreen\";\n" + "> >\n" + "> Agree, it is redundant. And if you have free time, you can convert the driver to support devicetree.\n" + "> \n" + "> Acked-by: Fugang Duan <B38611@freescale.com>\n" + "\n" + "Reviewed-by: Jingoo Han <jg1.han@samsung.com>\n" + "\n" + "Best regards,\n" + Jingoo Han -121e4534a1e0780ae21411a5ded3cf53f8dc1c17eceba62897e76856e19bc663 +0045ad28d6cc47d0172038f28bfb90f9fff8248adeedfbde405fb78c1da40568
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.