Re: [PATCH 0/6] Extensions to test-pmd

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hi Cyril,

2014-04-03 10:30, Cyril Chemparathy:
> This patch series contains a few minor extensions to test-pmd.  These
> changes have been added primarily for convenience while testing out various
> scenarios with DPDK.
> 
> Cyril Chemparathy (6):
>   test-pmd: add support for single port loopback topology
>   test-pmd: add support for auto-start when interactive
>   test-pmd: allow command line selection of forwarding mode
>   test-pmd: allow txpkts to be setup via command line
>   test-pmd: add mac swap forwarding mode
>   test-pmd: add flowgen forwarding engine

Thanks for these new features.

This is not the first time a new engine is added by copy/pasting the most part 
of an existing engine. For instance, the "mac-retry" engine was added by Intel 
as a copy/paste of the original "mac" one.
This is acceptable but not the perfect way to implement engines.
To address this issue, a new engine function could be introduced to setup some 
parameters to be used by "packet_fwd" function. This way, similar engines 
could be removed.

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied for version 1.7.0.
-- 
Thomas