All of lore.kernel.org
 help / color / mirror / Atom feed
From: JinGoo Han <jg1.han@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] drivers/video/udlfb bind framebuffer to interface.
Date: Mon, 11 Jul 2011 04:26:14 +0000	[thread overview]
Message-ID: <22966736.78901310358374131.JavaMail.weblogic@epv6ml05> (raw)
In-Reply-To: <1309910651-3483-1-git-send-email-bernie@plugable.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1840 bytes --]

Hi, Bernie Thompson.
> -----Original Message-----
> From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
> owner@vger.kernel.org] On Behalf Of bernie@plugable.com
> Sent: Wednesday, July 06, 2011 9:04 AM
> To: linux-fbdev@vger.kernel.org
> Cc: lethal@linux-sh.org; Kay Sievers; Bernie Thompson
> Subject: [PATCH] drivers/video/udlfb bind framebuffer to interface.
> 
> From: Kay Sievers <kay.sievers@vrfy.org>
> 
> Udlfb has been binding the framebuffer device to its parent, which
> isn't correct and causes confusion with operations like udev remove.
> 
> Coming plug and play multiseat support is dependent on this fix.
> 
> Signed-off-by: Bernie Thompson <bernie@plugable.com>
This patch author seems to be Kay Sievers <kay.sievers@vrfy.org>.
Should you add Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> ?
> ---
>  drivers/video/udlfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
> index 816a4fd..c6584c9 100644
> --- a/drivers/video/udlfb.c
> +++ b/drivers/video/udlfb.c
> @@ -1549,7 +1549,7 @@ static int dlfb_usb_probe(struct usb_interface
> *interface,
>  	/* We don't register a new USB class. Our client interface is fbdev
> */
> 
>  	/* allocates framebuffer driver structure, not framebuffer memory
> */
> -	info = framebuffer_alloc(0, &usbdev->dev);
> +	info = framebuffer_alloc(0, &interface->dev);
>  	if (!info) {
>  		retval = -ENOMEM;
>  		pr_err("framebuffer_alloc failed\n");
> --
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

  reply	other threads:[~2011-07-11  4:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06  0:04 [PATCH] drivers/video/udlfb bind framebuffer to interface bernie
2011-07-11  4:26 ` JinGoo Han [this message]
2011-07-13  8:17 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22966736.78901310358374131.JavaMail.weblogic@epv6ml05 \
    --to=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.