From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next 2/2] tcp: do not increment BeyondWindow MIB for old seq
Date: Sat, 19 Jul 2025 00:16:48 +0200 [thread overview]
Message-ID: <22c46310-191e-4a67-bec7-6cb0cb37193b@kernel.org> (raw)
In-Reply-To: <33f764b857dd28273784da12a3bac8dac039fbcb.1752859383.git.pabeni@redhat.com>
Hi Paolo,
On 18/07/2025 19:25, Paolo Abeni wrote:
> The mentioned MIB is currently incremented even when a packet
> with an old sequence number (i.e. a zero window probe) is received,
> which is IMHO misleading.
>
> Explicitly restrict such MIB increment at the relevant events.
Good idea, it is less confusing!
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-07-18 22:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 17:25 [PATCH net-next 0/2] tcp: a couple of fixes Paolo Abeni
2025-07-18 17:25 ` [PATCH net-next 1/2] tcp: do not set a zero size receive buffer Paolo Abeni
2025-07-18 22:15 ` Matthieu Baerts
2025-07-21 8:04 ` Eric Dumazet
2025-07-21 10:50 ` Paolo Abeni
2025-07-21 12:30 ` Eric Dumazet
2025-07-21 12:41 ` Eric Dumazet
2025-07-21 13:32 ` Paolo Abeni
2025-07-21 13:52 ` Eric Dumazet
2025-07-21 14:56 ` Paolo Abeni
2025-07-21 15:21 ` Eric Dumazet
2025-07-21 16:17 ` Paolo Abeni
2025-07-21 15:27 ` Jakub Kicinski
2025-07-21 15:30 ` Jakub Kicinski
2025-07-21 16:50 ` Eric Dumazet
2025-07-18 17:25 ` [PATCH net-next 2/2] tcp: do not increment BeyondWindow MIB for old seq Paolo Abeni
2025-07-18 22:16 ` Matthieu Baerts [this message]
2025-07-21 8:28 ` Eric Dumazet
2025-07-21 9:13 ` [PATCH net-next 0/2] tcp: a couple of fixes Matthieu Baerts
2025-07-21 16:47 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c46310-191e-4a67-bec7-6cb0cb37193b@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.