From: Paul Durrant <xadimgnik@gmail.com>
To: Simone Ballarin <simone.ballarin@bugseng.com>,
xen-devel@lists.xenproject.org
Cc: consulting@bugseng.com, sstabellini@kernel.org,
"Gianluca Luparini" <gianluca.luparini@bugseng.com>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [XEN PATCH v5 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2
Date: Tue, 12 Sep 2023 08:21:34 +0200 [thread overview]
Message-ID: <22cf127f-9348-d449-cc6c-7f87c4d01de4@xen.org> (raw)
In-Reply-To: <4581fc2e3292f761336639a1881e05775e681874.1693219887.git.simone.ballarin@bugseng.com>
On 28/08/2023 12:03, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@bugseng.com>
>
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type and also to other
> literals used in the same contexts or near violations, when their positive
> nature is immediately clear. The latter changes are done for the sake of
> uniformity.
>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@bugseng.com>
> Signed-off-by: Simone Ballarin <simone.ballarin@bugseng.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v4:
> - change commit headline
> - add Reviewed-by
>
> Changes in v3:
> - create this commit for 'viridian.c' and 'hyperv-tlfs.h'
> ---
> xen/arch/x86/hvm/viridian/viridian.c | 2 +-
> xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 ++++++++++----------
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
Reviewed-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2023-09-12 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:02 [XEN PATCH v5 0/4] xen: address violations of MISRA C:2012 Rule 7.2 Simone Ballarin
2023-08-28 11:02 ` [XEN PATCH v5 1/4] x86/vmx: " Simone Ballarin
2023-08-28 11:03 ` [XEN PATCH v5 2/4] xen/vpci: " Simone Ballarin
2023-08-28 11:03 ` [XEN PATCH v5 3/4] x86/viridian: " Simone Ballarin
2023-09-12 6:21 ` Paul Durrant [this message]
2023-08-28 11:03 ` [XEN PATCH v5 4/4] xen/x86: " Simone Ballarin
2023-08-29 13:13 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22cf127f-9348-d449-cc6c-7f87c4d01de4@xen.org \
--to=xadimgnik@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=consulting@bugseng.com \
--cc=gianluca.luparini@bugseng.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=simone.ballarin@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.