From: Yunseong Kim <yunseong.kim@est.tech>
To: Stefan Metzmacher <metze@samba.org>,
Bernard Metzler <bernard.metzler@linux.dev>,
Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Jacob Moroni <jmoroni@google.com>,
Bart Van Assche <bvanassche@acm.org>,
Namjae Jeon <linkinjeon@kernel.org>, Tom Talpey <tom@talpey.com>,
Yunseong Kim <yunseong.kim@ericsson.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [RFC PATCH] RDMA/iwcm: allow aborting an active connect awaiting CONNECT_REPLY
Date: Tue, 3 Nov 2026 10:13:35 +0100 [thread overview]
Message-ID: <22e50a64-ea78-4ac7-8680-845b7651db07@est.tech> (raw)
In-Reply-To: <473d9515-b951-4cff-a553-b8ed471d0112@samba.org>
Hi Stefan,
On 16/10/2026 11:25 am, Stefan Metzmacher wrote:
> Am 03.09.26 um 12:42 schrieb Bernard Metzler:
>> On 01.09.2026 18:50, Stefan Metzmacher wrote:
>>> Hi Leon,
>>>
>>>> On Wed, Aug 05, 2026 at 02:02:00AM +0200, Yunseong Kim wrote:
>>>>> [snip...]
> It actually still hangs in here:
>
> For an active iWarp connect that is still waiting for the MPA reply
> (e.g. the peer accepted the TCP connection, but never answers the
> MPA request), irdma doesn't flush the marker before the pending
> connect is aborted, which only happens in rdma_destroy_id().
> smbdirect_socket_destroy_sync() calls ib_drain_qp() before that, so
> it waits forever:
>
> __ib_drain_sq+0x139/0x1b0 [ib_core]
> ib_drain_sq+0x7f/0x90 [ib_core]
> ib_drain_qp+0x16/0x40 [ib_core]
> smbdirect_socket_destroy_sync+0x2bd/0xa90 [smbdirect]
> smbdirect_socket_release+0x61/0xb0 [smbdirect]
> smbd_get_connection+0x22c/0x280 [cifs]
>
>
> Here's my work in progress branch to fix these problems:
> https://git.samba.org/?p=metze/linux/wip.git;a=shortlog;h=refs/heads/for-7.3/rdma-backport-testing
Thank you again for checking this!
> There I'm able to eliminate all hangs I was able to reproduce with siw, rxe, iw_cxgb4, irdma, mlx5_ib.
> I tested the following situations:
> - server iptables drop (port 5445 and 4791)
> - server nc -lk 5445 (tcp connection accepted by no responses)
> - ip address del (on the client)
> - ip link down (on the client)
>
> It likely takes a while until I rechecked all commits
> and submit them in small chunks, but it's good to see
> that it's possible to avoid deadlocks or very large timeouts.
>
> So at least that patch doesn't solve all problems.
>
> metze
I'll also rerun my automated tests based on your branch when I have some time.
Best regards,
Yunseong
next prev parent reply other threads:[~2026-11-03 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 0:02 [RFC PATCH] RDMA/iwcm: allow aborting an active connect awaiting CONNECT_REPLY Yunseong Kim
2026-09-01 12:41 ` Leon Romanovsky
2026-09-01 16:50 ` Stefan Metzmacher
2026-09-02 7:15 ` Leon Romanovsky
2026-09-03 10:42 ` Bernard Metzler
2026-10-16 9:25 ` Stefan Metzmacher
2026-11-03 9:13 ` Yunseong Kim [this message]
2026-11-03 10:52 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e50a64-ea78-4ac7-8680-845b7651db07@est.tech \
--to=yunseong.kim@est.tech \
--cc=bernard.metzler@linux.dev \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=jmoroni@google.com \
--cc=leon@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=metze@samba.org \
--cc=samba-technical@lists.samba.org \
--cc=tom@talpey.com \
--cc=yunseong.kim@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.