From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, 'Weiguo Li' <liwg06@foxmail.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/txgbe: fix a bit with boolean operator
Date: Wed, 2 Mar 2022 17:34:30 +0000 [thread overview]
Message-ID: <22ea3217-36e3-ea18-d768-9506d545a6bb@intel.com> (raw)
In-Reply-To: <004601d82e0b$e60ab910$b2202b30$@trustnetic.com>
On 3/2/2022 8:02 AM, Jiawen Wu wrote:
> On March 1, 2022 2:09 PM, Weiguo Li wrote:
>> Since boolean value is in 0 and 1, it's strange to combines a boolean
> value with
>> a bit operator.
>>
>> Thus it's highly possible a typo error with "if (A & !B)", and more
> probably to
>> use "if (A & ~B)" instead.
>>
>> Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping")
>>
>> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
>
> Acked-by: Jiawen Wu <jiawenwu@trustnetic.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-03-02 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:08 [PATCH] net/txgbe: fix a bit with boolean operator Weiguo Li
2022-03-02 8:02 ` Jiawen Wu
2022-03-02 17:23 ` Ferruh Yigit
2022-03-03 13:31 ` Weiguo Li
2022-03-03 15:18 ` Ferruh Yigit
2022-03-03 16:16 ` Stephen Hemminger
2022-03-02 17:34 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22ea3217-36e3-ea18-d768-9506d545a6bb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=liwg06@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.