From: kgene@kernel.org
To: 'Sachin Kamat' <sachin.kamat@linaro.org>, linux-mtd@lists.infradead.org
Cc: computersforpeace@gmail.com, linux-samsung-soc@vger.kernel.org,
patches@linaro.org
Subject: RE: [PATCH 1/1] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
Date: Sat, 04 Jan 2014 10:46:18 +0900 [thread overview]
Message-ID: <22ed01cf08ee$c2ea08f0$48be1ad0$@kernel.org> (raw)
In-Reply-To: <1388638630-1353-1-git-send-email-sachin.kamat@linaro.org>
Sachin Kamat wrote:
>
> plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> are no other users, merge this file into the driver code to remove
> platform dependency.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> The earlier version of this patch was titled
> "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd".
> Please ignore that.
> ---
>
> arch/arm/plat-samsung/include/plat/regs-nand.h | 123 -------------------
> -----
> drivers/mtd/nand/s3c2410.c | 104
+++++++++++++++++++-
> 2 files changed, 103 insertions(+), 124 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
>
Moving looks good, but if some of them are not used, we don't need to keep
them while moving.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org
To: 'Sachin Kamat' <sachin.kamat@linaro.org>, linux-mtd@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, computersforpeace@gmail.com,
patches@linaro.org
Subject: RE: [PATCH 1/1] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
Date: Sat, 04 Jan 2014 10:46:18 +0900 [thread overview]
Message-ID: <22ed01cf08ee$c2ea08f0$48be1ad0$@kernel.org> (raw)
In-Reply-To: <1388638630-1353-1-git-send-email-sachin.kamat@linaro.org>
Sachin Kamat wrote:
>
> plat/regs-nand.h is used only by S3C2410 nand driver. Since there
> are no other users, merge this file into the driver code to remove
> platform dependency.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> The earlier version of this patch was titled
> "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd".
> Please ignore that.
> ---
>
> arch/arm/plat-samsung/include/plat/regs-nand.h | 123 -------------------
> -----
> drivers/mtd/nand/s3c2410.c | 104
+++++++++++++++++++-
> 2 files changed, 103 insertions(+), 124 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h
>
Moving looks good, but if some of them are not used, we don't need to keep
them while moving.
Thanks,
Kukjin
next prev parent reply other threads:[~2014-01-04 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 4:57 [PATCH 1/1] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c Sachin Kamat
2014-01-02 4:57 ` Sachin Kamat
2014-01-02 5:14 ` Jingoo Han
2014-01-02 5:14 ` Jingoo Han
2014-01-04 1:46 ` kgene [this message]
2014-01-04 1:46 ` kgene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='22ed01cf08ee$c2ea08f0$48be1ad0$@kernel.org' \
--to=kgene@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.