From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D720EF48D3 for ; Fri, 13 Feb 2026 06:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q97xm++TdeHJ0n3tmDXIDr9JsvTHbC1CgrTzBdBlc6k=; b=KsGWeNXyr2UgId u2ZfvHMUmTpmjb0OqHssj5pe6W2Gj0+gjIzlMRw08J9cExmH0DWrHXXB3G9gEfyYYiRsOmSl/6K4f oJ3V5/DNVBRuZo+jnHb3gba4ngEh8bj9iVl0vqzEJACgpnCDJhqpsVrWKot+08Je3F/7QlKOful2S DAs8RCFEEW1UPxhKcEEcc/KaGGlXOdAnxg8vkbp8/sRaujcdyn541dlYIA+kN6cKOx2fLPC/Jp6hB AJUyhyAwGP8Q9qWuY37FATEomKItST1wt4/t9aAi+ThOpHErvJmuRphIl119jA5uX6XuBTi3Nq6F5 0g7O0g7uoub7iXOcLlgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqmXh-000000033rB-2NVI; Fri, 13 Feb 2026 06:20:41 +0000 Received: from azure-sdnproxy.icoremail.net ([4.193.249.245]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqmXd-000000033qj-2Qml for linux-phy@lists.infradead.org; Fri, 13 Feb 2026 06:20:40 +0000 Received: from luyulin$eswincomputing.com ( [10.12.96.77] ) by ajax-webmail-app2 (Coremail) ; Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00) X-Originating-IP: [10.12.96.77] Date: Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Yulin Lu" To: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, fenglin@eswincomputing.com Subject: Re: [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2024.2-cmXT6 build 20241203(6b039d88) Copyright (c) 2002-2026 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: <20260205082009.1780-1-luyulin@eswincomputing.com> References: <20260205082009.1780-1-luyulin@eswincomputing.com> MIME-Version: 1.0 Message-ID: <22fea2d6.370e.19c55a86a72.Coremail.luyulin@eswincomputing.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: TQJkCgAnPqGqwo5pRkcAAA--.180W X-CM-SenderInfo: pox13z1lq6v25zlqu0xpsx3x1qjou0bp/1tbiAgERA2mOAQQQ8QAB sT X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260212_222038_009307_7C41A4E3 X-CRM114-Status: UNSURE ( 8.14 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org > Updates: > v9 -> v8: > - eswin,eic7700-sata-phy.yaml > - Modify the format of the "default" field in the > "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" > properties. > - phy-eic7700-sata.c > - Correct the incorrectly formatted symbol "-" in the comments. > - Link to v8: https://lore.kernel.org/lkml/20260123024823.1612-1-luyulin@eswincomputing.com/ > > v8 -> v7: > - eswin,eic7700-sata-phy.yaml > - Add "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning" > properties, because these parameters may vary across different > circuit boards. > - Delete reviewed-by tag of Krzysztof Kozlowski, because the tuning > properties are introduced. > - phy-eic7700-sata.c > - Try to get SATA PHY transmitter amplitude and pre-emphasis signal > eye diagram tuning parameters from dts instead of hardcoded values > in the code. Because, these parameters may vary across different > circuit boards. Define default tuning parameters and use it when > these properties are not declared in dts. > - Add a comment to explain the reason for mapping I/O resources with > platform_get_resource and devm_ioremap instead of using the > devm_platform_ioremap_resource API. > - Link to v7: https://lore.kernel.org/lkml/20260106062944.1529-1-luyulin@eswincomputing.com/ Hi Vinod, all, In v7, I got driver review comments from Vinod. After fixing and submitting v8, I received yaml comments from Krzysztof. v9 now has Reviewed-by from Krzysztof. So I want to confirm whether there are any further comments on the driver code in v9 and if it meets the requirements for merging. Best regards, Yulin Lu -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sgoci-sdnproxy-4.icoremail.net (sgoci-sdnproxy-4.icoremail.net [129.150.39.64]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C4661DE8BF; Fri, 13 Feb 2026 06:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=129.150.39.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770963645; cv=none; b=R85s5SGId6uOwTyvyTYPm8fziXrZyWxBO924xrfKqKCj2/kEotSGos99+/BU0tfuCJ0w7DzirqVYGyy2NbtndYUgp1qciydS34wszXYvNq60wPXCo+JwGnh/+dbkmMTx1WzhRzi64aNEDw5YpeFUmFdz2kfZiI81nQx1rxiT/V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770963645; c=relaxed/simple; bh=vlUaZYWsQrIcdh8gkDf4J87iIEnfkC5YyC1wucluai8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type: MIME-Version:Message-ID; b=Ryj70NjrI1f1j1NOorsmwr+9B5CSALkaeUWhF549nuB7aWVVVQQZHl1ZXfRmXJ8f8GthSXZ4xncplCdFoKAmR2tF8HKINus8/Lll+VSsZ58KKVT3XnpBCk6n1pJpk8k9tRG+gTtB3ukPSAIwT3jsw2alD1lAbdkwX5bynNhFL/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com; spf=pass smtp.mailfrom=eswincomputing.com; arc=none smtp.client-ip=129.150.39.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from luyulin$eswincomputing.com ( [10.12.96.77] ) by ajax-webmail-app2 (Coremail) ; Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00) Date: Fri, 13 Feb 2026 14:20:26 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Yulin Lu" To: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com, fenglin@eswincomputing.com Subject: Re: [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2024.2-cmXT6 build 20241203(6b039d88) Copyright (c) 2002-2026 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: <20260205082009.1780-1-luyulin@eswincomputing.com> References: <20260205082009.1780-1-luyulin@eswincomputing.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <22fea2d6.370e.19c55a86a72.Coremail.luyulin@eswincomputing.com> X-Coremail-Locale: zh_CN X-CM-TRANSID:TQJkCgAnPqGqwo5pRkcAAA--.180W X-CM-SenderInfo: pox13z1lq6v25zlqu0xpsx3x1qjou0bp/1tbiAgERA2mOAQQQ8QAB sT X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= PiBVcGRhdGVzOgo+ICAgdjkgLT4gdjg6Cj4gICAgIC0gZXN3aW4sZWljNzcwMC1zYXRhLXBoeS55 YW1sCj4gICAgICAgLSBNb2RpZnkgdGhlIGZvcm1hdCBvZiB0aGUgImRlZmF1bHQiIGZpZWxkIGlu IHRoZQo+ICAgICAgICAgImVzd2luLHR4LWFtcGxpdHVkZS10dW5pbmciIGFuZCAiZXN3aW4sdHgt cHJlZW1waC10dW5pbmciCj4gICAgICAgICBwcm9wZXJ0aWVzLgo+ICAgICAtIHBoeS1laWM3NzAw LXNhdGEuYwo+ICAgICAgIC0gQ29ycmVjdCB0aGUgaW5jb3JyZWN0bHkgZm9ybWF0dGVkIHN5bWJv bCAiLSIgaW4gdGhlIGNvbW1lbnRzLgo+ICAgICAtIExpbmsgdG8gdjg6IGh0dHBzOi8vbG9yZS5r ZXJuZWwub3JnL2xrbWwvMjAyNjAxMjMwMjQ4MjMuMTYxMi0xLWx1eXVsaW5AZXN3aW5jb21wdXRp bmcuY29tLwo+IAo+ICAgdjggLT4gdjc6Cj4gICAgIC0gZXN3aW4sZWljNzcwMC1zYXRhLXBoeS55 YW1sCj4gICAgICAgLSBBZGQgImVzd2luLHR4LWFtcGxpdHVkZS10dW5pbmciIGFuZCAiZXN3aW4s dHgtcHJlZW1waC10dW5pbmciCj4gICAgICAgICBwcm9wZXJ0aWVzLCBiZWNhdXNlIHRoZXNlIHBh cmFtZXRlcnMgbWF5IHZhcnkgYWNyb3NzIGRpZmZlcmVudAo+ICAgICAgICAgY2lyY3VpdCBib2Fy ZHMuCj4gICAgICAgLSBEZWxldGUgcmV2aWV3ZWQtYnkgdGFnIG9mIEtyenlzenRvZiBLb3psb3dz a2ksIGJlY2F1c2UgdGhlIHR1bmluZwo+ICAgICAgICAgcHJvcGVydGllcyBhcmUgaW50cm9kdWNl ZC4KPiAgICAgLSBwaHktZWljNzcwMC1zYXRhLmMKPiAgICAgICAtIFRyeSB0byBnZXQgU0FUQSBQ SFkgdHJhbnNtaXR0ZXIgYW1wbGl0dWRlIGFuZCBwcmUtZW1waGFzaXMgc2lnbmFsCj4gICAgICAg ICBleWUgZGlhZ3JhbSB0dW5pbmcgcGFyYW1ldGVycyBmcm9tIGR0cyBpbnN0ZWFkIG9mIGhhcmRj b2RlZCB2YWx1ZXMKPiAgICAgICAgIGluIHRoZSBjb2RlLiBCZWNhdXNlLCB0aGVzZSBwYXJhbWV0 ZXJzIG1heSB2YXJ5IGFjcm9zcyBkaWZmZXJlbnQKPiAgICAgICAgIGNpcmN1aXQgYm9hcmRzLiBE ZWZpbmUgZGVmYXVsdCB0dW5pbmcgcGFyYW1ldGVycyBhbmQgdXNlIGl0IHdoZW4KPiAgICAgICAg IHRoZXNlIHByb3BlcnRpZXMgYXJlIG5vdCBkZWNsYXJlZCBpbiBkdHMuCj4gICAgICAgLSBBZGQg YSBjb21tZW50IHRvIGV4cGxhaW4gdGhlIHJlYXNvbiBmb3IgbWFwcGluZyBJL08gcmVzb3VyY2Vz IHdpdGgKPiAgICAgICAgIHBsYXRmb3JtX2dldF9yZXNvdXJjZSBhbmQgZGV2bV9pb3JlbWFwIGlu c3RlYWQgb2YgdXNpbmcgdGhlCj4gICAgICAgICBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3Vy Y2UgQVBJLgo+ICAgICAtIExpbmsgdG8gdjc6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwv MjAyNjAxMDYwNjI5NDQuMTUyOS0xLWx1eXVsaW5AZXN3aW5jb21wdXRpbmcuY29tLwoKSGkgVmlu b2QsIGFsbCwKCkluIHY3LCBJIGdvdCBkcml2ZXIgcmV2aWV3IGNvbW1lbnRzIGZyb20gVmlub2Qu IEFmdGVyIGZpeGluZyBhbmQgc3VibWl0dGluZyB2OCwKSSByZWNlaXZlZCB5YW1sIGNvbW1lbnRz IGZyb20gS3J6eXN6dG9mLiB2OSBub3cgaGFzIFJldmlld2VkLWJ5IGZyb20gS3J6eXN6dG9mLgpT byBJIHdhbnQgdG8gY29uZmlybSB3aGV0aGVyIHRoZXJlIGFyZSBhbnkgZnVydGhlciBjb21tZW50 cyBvbiB0aGUgZHJpdmVyIGNvZGUKaW4gdjkgYW5kIGlmIGl0IG1lZXRzIHRoZSByZXF1aXJlbWVu dHMgZm9yIG1lcmdpbmcuCgpCZXN0IHJlZ2FyZHMsCll1bGluIEx1Cg==