From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs Date: Thu, 16 May 2013 02:18:40 +0000 (GMT) Message-ID: <23026896.124001368670717989.JavaMail.weblogic@epml12> Reply-To: jg1.han@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=euc-kr Content-Transfer-Encoding: base64 Return-path: MIME-version: 1.0 Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa , Linus Walleij Cc: Heiko St?bner , Russell King - ARM Linux , Dan Williams , Vinod Koul , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" , Jingoo Han List-Id: linux-samsung-soc@vger.kernel.org T24gVHVlc2RheSwgTWF5IDE0LCAyMDEzIDExOjIyIFBNIFRvbWFzeiBGaWdhIHdyb3RlOg0KPiAN Cj4gSGkgTGludXMsIEhlaWtvLA0KPiANCj4gT24gVHVlc2RheSAxNCBvZiBNYXkgMjAxMyAxNDo0 NzoxOSBMaW51cyBXYWxsZWlqIHdyb3RlOg0KPiA+IE9uIFNhdCwgTWF5IDExLCAyMDEzIGF0IDE6 MzEgUE0sIEhlaWtvIFN0P2JuZXIgPGhlaWtvQHNudGVjaC5kZT4gd3JvdGU6DQo+ID4gPiBDb25j ZXB0dWFsbHkgdGhlIHMzYzI0eHgtZG1hIGZlZWxzIGxpa2UgYSBkaXN0YW50IHJlbGF0aXZlIG9m IHRoZSBwbDA4eA0KPiA+ID4gd2l0aCBudW1lcm91cyB2aXJ0dWFsIGNoYW5uZWxzIGJlaW5nIG1h cHBlZCB0byBhIGxvdCBsZXNzIHBoeXNpY2FsIG9uZXMuDQo+ID4gPiBUaGUgZHJpdmVyIHRoZXJl Zm9yZSBib3Jyb3dzIGEgbG90IGZyb20gdGhlIGFtYmEtcGwwOHggZHJpdmVyIGluIHRoaXMNCj4g PiA+IHJlZ2FyZC4gRnVuY3Rpb25hbGl0eS13aXNlIHRoZSBkcml2ZXIgZ2FpbnMgYSBtZW1jcHkg YWJpbGl0eSBpbiBhZGRpdGlvbg0KPiA+ID4gdG8gdGhlIHNsYXZlX3NnIG9uZS4NCj4gPiA+DQo+ ID4gPiBUaGUgZHJpdmVyIGN1cnJlbnRseSBvbmx5IHN1cHBvcnRzIHRoZSAibmV3ZXIiIFNvQ3Mg d2hpY2ggY2FuIHVzZSBhbnkNCj4gPiA+IHBoeXNpY2FsIGNoYW5uZWwgZm9yIGFueSBkbWEgc2xh dmUuIFN1cHBvcnQgZm9yIHRoZSBvbGRlciBTb0NzIHdoZXJlDQo+ID4gPiBlYWNoIGNoYW5uZWwg b25seSBzdXBwb3J0cyBhIHN1YnNldCBvZiBwb3NzaWJsZSBkbWEgc2xhdmVzIHdpbGwgaGF2ZSB0 bw0KPiA+ID4gYmUgYWRkZWQgbGF0ZXIuDQo+ID4gPg0KPiA+ID4gVGVzdGVkIG9uIGEgczNjMjQx Ni1iYXNlZCBib2FyZCwgbWVtY3B5IHVzaW5nIHRoZSBkbWF0ZXN0IG1vZHVsZSBhbmQNCj4gPiA+ IHNsYXZlX3NnIHBhcnRpYWxseSB1c2luZyB0aGUgc3BpLXMzYzY0eHggZHJpdmVyLg0KPiA+ID4N Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+DQo+ ID4NCj4gPiBTbyBoYXZlIEkgdW5kZXJzdG9vZCBjb3JyZWN0bHkgaWYgSSBhc3N1bWUgdGhhdCAq c29tZSogUzNDDQo+ID4gdmFyaWFudHMsIGkuZS4gdGhpczogYXJjaC9hcm0vbWFjaC1zM2M2NHh4 L2RtYS5jDQo+ID4gaGF2ZSBhIHZhbmlsbGEsIHVubW9kaWZpZWQsIG9yIGp1c3Qgc2xpZ2h0bHkg bW9kaWZpZWQNCj4gPiBQTDA4eCBibG9jaywgd2hpbGUgdGhpcyBETUFDIGlzIHNvbWV0aGluZyBw cm9iYWJseSBiYXNlZCBvbg0KPiA+IHRoZSBQTDA4eCB3aGVyZSBzb21lIEFTSUMgZW5naW5lZXIg aGFzIGhhZCBhIGdvb2QgdGltZSBoYWNraW5nDQo+ID4gYXJvdW5kIGluIHRoZSBWSERMIGNvZGUg dG8gbWVldCBzb21lIGZlYXR1cmUgcmVxdWlyZW1lbnRzLg0KPiA+IENvcnJlY3Q/IE9yIHBsYXVz aWJsZSBndWVzcz8NCj4gPg0KPiA+IEV4YWN0bHkgKmhvdyogZmFyIGF3YXkgZnJvbSB0aGUgcGww OHggaGFyZHdhcmUgaXMgaXQ/DQo+IA0KPiBBRkFJSyB0aGUgRE1BQyBvZiBTM0MyNHh4IGlzIGNv bXBsZXRlbHkgZGlmZmVyZW50IGZyb20gUEwwOHguIEkgdGhpbmsgSGVpa28NCj4ganVzdCBtZWFu dCB0aGF0IGl0IHVzZXMgc2ltaWxhciBjb25jZXB0cywgbGlrZSB2aXJ0dWFsIGNoYW5uZWxzLg0K DQpZZXMsIHJpZ2h0Lg0KdGhlIERNQUMgb2YgUzNDMjR4eCBpcyBjb21wbGV0ZWx5IGRpZmZlcmVu dCBmcm9tIFBMMDh4Lg0KQXMgSGVpa28gbWVudGlvbmVkLCB0aGUgRE1BQyBvZiBTM0MyNHh4IGlz ICdob21lIGdyb3duJyBhcyBvdGhlciBJUHMgb2YgUzNDMjR4eC4NCg0KQmVzdCByZWdhcmRzLA0K SmluZ29vIEhhbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904Ab3EPCSo (ORCPT ); Wed, 15 May 2013 22:18:44 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:29601 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521Ab3EPCSm (ORCPT ); Wed, 15 May 2013 22:18:42 -0400 X-AuditID: cbfee68f-b7f436d000000f81-a1-51944200b4e2 Date: Thu, 16 May 2013 02:18:40 +0000 (GMT) From: Jingoo Han Subject: Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs To: Tomasz Figa , Linus Walleij Cc: Heiko St?bner , Russell King - ARM Linux , Dan Williams , Vinod Koul , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" , Jingoo Han Reply-to: jg1.han@samsung.com MIME-version: 1.0 X-MTR: 20130516021223232@jg1.han Msgkey: 20130516021223232@jg1.han X-EPLocale: en_US.euc-kr X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20130516021223232@jg1.han X-ParentMTR: X-ArchiveUser: EV X-CPGSPASS: N Content-type: text/plain; charset=euc-kr MIME-version: 1.0 Message-id: <23026896.124001368670717989.JavaMail.weblogic@epml12> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMJsWRmVeSWpSXmKPExsVy+t8zY10GpymBBt2XNS0u75rD5sDo8XmT XABjVAOjTWJRckZmWapCal5yfkpmXrqtUmiIm66FkkJGfnGJrVK0kYGxnpGpiZ6RibmepUGs lZGpkkJeYm6qrVKFLlSvkkJRcgFQbW5lMdCAnFQ9qLhecWpeikNWfinIJXrFibnFpXnpesn5 uUoKZYk5pUAjlPQTpjJmTJ76mLngmnDFwYUdjA2ME4S7GDk5hASUJCad3MsIYksImEjsWfwQ yhaTuHBvPVsXIxdQzTJGiaf/m5lhihad+sgMkZjPKPHg4xV2kASLgKpE38vvTCA2m4C6xITf zSwgtrCAp8TzGStYQWwRgRCJj5uXsIA0MwvsY5b4dLyLFeIMWYl7k2eDbeAVEJQ4OfMJUBEH 0DYFiSu/wiDCihJ93z6wQhwhIXHn/n4om1diRvtTFghbTmLa1zVQh0pLnJ+1Ae6bxd8fQ8X5 JY7d3sEEMZ5X4sn9YJgxuzd/YYOwBSSmnjkI1aoq0bXvFtR4Pok1C99C2YISp691M8P03t8y F+x1ZqAzp3Q/ZIewtSS+/NjHhu4rXgEniT3zhCYwKs9CkpmFpHsWkm5kNQsYWVYxiqYWJBcU J6UXGSNH9iZGSBrs38F494D1Icb9jMAomcgsJZqcD0ykeSXxhsZmRhamJqbGRuaWZhQKm5ha WJgYUUVYSZxXrcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOjkpRorOYXzWqZZO+gjCOS VXmXZjOET+05nNy72a3s1ARuZ20V3fPGV/gP3pjBs/5Pf6rEptze8MktNxjvdrnfWsPJMidy 95sptZrd2lmRmabc9tLTWCax3y/TFbVvlI1eckQh787qKd+3JM0zT7UxO55s9nxGhaN5usl0 u+eyV6+mc3/kc1ViKc5INNRiLipOBABtlbXK9gMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkk+LIzCtJLcpLzFFi42I5/e/2TF0GpymBBkvOqFpc3jWHzYHR4/Mm uQDGqAybjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWgjA2M9I1MTPSNjAz1jy1grQwMDI1OgqoSM jMlTHzMXXBOuOLiwg7GBcYJwFyMnh5CAksSkk3sZQWwJAROJRac+MkPYYhIX7q1n62LkAqqZ zyjx4OMVdpAEi4CqRN/L70wgNpuAusSE380sILawgKfE8xkrWEFsEYEQiY+bl7CANDML7GOW +HS8ixVim6zEvcmzwTbwCghKnJz5BKiIA2ibgsSVX2EQYUWJvm8fWCGOkJC4c38/lM0rMaP9 KQuELScx7esaqEOlJc7P2sAIc/Ti74+h4vwSx27vYIIYzyvx5H4wzJjdm7+wQdgCElPPHIRq VZXo2ncLajyfxJqFb6FsQYnT17qZYXrvb5kL9joz0JlTuh+yQ9haEl9+7GND9xWvgJPEnnlC ExjlZiHJzELSPQtJN7KaBYwsqxhFUwuSC4qT0iuM9IoTc4tL89L1kvNzNzGCE9SzRTsY/523 PsQowMGoxMPrYDIlUIg1say4MvcQowQHs5IIr4INUIg3JbGyKrUoP76oNCe1+BBjMjD+JjJL iSbnA5NnXkm8obGxiZmJqbmBhYGlOWnCSuK8z1qtA4UE0hNLUrNTUwtSi2C2MHFwSjUw6t0X NKt79sQnZWotw5+9T/vfthj7LV8xwf2KYdHfi3LR107W5WgfOlT6aLG8jcyunDsp14o1+bfV 3Txxqk0p7NvMuvSeUr+oaK3FXI1Zbeqpp26vvH2w915Osah+ic+kiWtl2Q9WvnuxcMPE5rOC v7Ypyqb3/CjVDLO+uGetjc/hPVJJSqteKrEUZyQaajEXFScCAB2v+PeUAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4G2Ioe9018999 On Tuesday, May 14, 2013 11:22 PM Tomasz Figa wrote: > > Hi Linus, Heiko, > > On Tuesday 14 of May 2013 14:47:19 Linus Walleij wrote: > > On Sat, May 11, 2013 at 1:31 PM, Heiko St?bner wrote: > > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > > > with numerous virtual channels being mapped to a lot less physical ones. > > > The driver therefore borrows a lot from the amba-pl08x driver in this > > > regard. Functionality-wise the driver gains a memcpy ability in addition > > > to the slave_sg one. > > > > > > The driver currently only supports the "newer" SoCs which can use any > > > physical channel for any dma slave. Support for the older SoCs where > > > each channel only supports a subset of possible dma slaves will have to > > > be added later. > > > > > > Tested on a s3c2416-based board, memcpy using the dmatest module and > > > slave_sg partially using the spi-s3c64xx driver. > > > > > > Signed-off-by: Heiko Stuebner > > > > So have I understood correctly if I assume that *some* S3C > > variants, i.e. this: arch/arm/mach-s3c64xx/dma.c > > have a vanilla, unmodified, or just slightly modified > > PL08x block, while this DMAC is something probably based on > > the PL08x where some ASIC engineer has had a good time hacking > > around in the VHDL code to meet some feature requirements. > > Correct? Or plausible guess? > > > > Exactly *how* far away from the pl08x hardware is it? > > AFAIK the DMAC of S3C24xx is completely different from PL08x. I think Heiko > just meant that it uses similar concepts, like virtual channels. Yes, right. the DMAC of S3C24xx is completely different from PL08x. As Heiko mentioned, the DMAC of S3C24xx is 'home grown' as other IPs of S3C24xx. Best regards, Jingoo Han{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I